fix: replace text-white with theme-aware color tokens#7908
Conversation
dosubot
bot
added
the
size:M
📝 WalkthroughWalkthroughReplaced hardcoded white/black/smoke Tailwind classes with semantic theme tokens (e.g., Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (14)
🧰 Additional context used📓 Path-based instructions (9)src/**/*.vue📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{vue,ts}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/{composables,components}/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/*.{vue,ts,tsx}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/{components,composables}/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/components/**/*.vue📄 CodeRabbit inference engine (src/components/CLAUDE.md)
Files:
src/components/**/*.{vue,css}📄 CodeRabbit inference engine (src/components/CLAUDE.md)
Files:
src/components/**/*.{vue,ts,js}📄 CodeRabbit inference engine (src/components/CLAUDE.md)
Files:
🧠 Learnings (28)📓 Common learnings📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-18T16:03:02.066ZApplied to files:
📚 Learning: 2025-12-09T03:49:52.828ZApplied to files:
📚 Learning: 2025-12-09T21:40:12.361ZApplied to files:
📚 Learning: 2025-12-16T22:26:49.463ZApplied to files:
📚 Learning: 2025-12-22T21:36:08.369ZApplied to files:
📚 Learning: 2026-01-08T02:26:18.357ZApplied to files:
📚 Learning: 2025-12-11T12:25:15.470ZApplied to files:
📚 Learning: 2025-12-18T02:07:38.870ZApplied to files:
📚 Learning: 2025-12-18T21:15:46.862ZApplied to files:
📚 Learning: 2025-12-21T01:06:02.786ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-12-18T20:39:30.137ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2026-01-09T00:50:57.103ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:34.324ZApplied to files:
📚 Learning: 2025-11-24T19:47:02.860ZApplied to files:
📚 Learning: 2026-01-09T00:50:57.103ZApplied to files:
📚 Learning: 2025-11-24T19:47:45.616ZApplied to files:
📚 Learning: 2025-11-24T19:47:34.324ZApplied to files:
📚 Learning: 2026-01-09T00:50:57.103ZApplied to files:
📚 Learning: 2025-12-11T03:55:51.755ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 01/09/2026, 01:31:44 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 01/09/2026, 01:36:59 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.23 MB (baseline 3.23 MB) • 🔴 +20 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 1.05 MB (baseline 1.05 MB) • 🔴 +69 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.63 kB (baseline 6.63 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 300 kB (baseline 300 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 198 kB (baseline 197 kB) • 🔴 +377 BReusable component library chunks
Status: 8 added / 8 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.19 MB (baseline 9.19 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 16 added / 16 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/components/load3d/controls/LightControls.vue (1)
19-19: Inconsistent with PR's theme token migration.This panel background still uses
bg-black/50instead of a semantic token. Based on the PR objectives and the pattern used in ExportControls.vue (line 19), this should be updated tobg-interface-menu-surfacefor consistency.🎨 Proposed fix
<div v-show="showLightIntensity" - class="absolute top-0 left-12 rounded-lg bg-black/50 p-4 shadow-lg" + class="absolute top-0 left-12 rounded-lg bg-interface-menu-surface p-4 shadow-lg" style="width: 150px" >Based on learnings and coding guidelines for using semantic tokens from the design system.
src/components/load3d/Load3DControls.vue (1)
46-46: Inconsistent token usage — update to match Line 3.Line 46 still uses the old
bg-smoke-700/30class, while Line 3 was updated tobg-backdrop/30. For consistency with the PR's theme-aware token migration, this line should be updated as well.🎨 Proposed fix
- <div v-show="activeCategory" class="rounded-lg bg-smoke-700/30"> + <div v-show="activeCategory" class="rounded-lg bg-backdrop/30">src/components/load3d/LoadingOverlay.vue (1)
24-41: Refactor spinner to use Tailwind for theme consistency.The
<style scoped>block uses hardcoded colors (#f3f3f3, #3498db) that don't adapt to the active theme. Since this PR updates color tokens for theme awareness, consider refactoring the spinner to use Tailwind utilities for consistency.♻️ Proposed Tailwind-based spinner
Replace the template and remove the
<style>block:<div class="flex flex-col items-center"> - <div class="spinner" /> + <div + class="h-12 w-12 animate-spin rounded-full border-4 border-border-subtle border-t-blue-500" + /> <div class="mt-4 text-lg text-base-foreground"> {{ loadingMessage }} </div> </div>Then remove the entire
<style scoped>block (lines 24-41).As per coding guidelines, use Tailwind CSS only for styling.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (14)
src/components/TopMenuSection.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/LightControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vue
🧰 Additional context used
📓 Path-based instructions (12)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3.5+ with TypeScript in.vuefiles, exclusively using Composition API with<script setup lang="ts">syntax
Use Tailwind 4 for styling in Vue components; avoid<style>blocks
Name Vue components using PascalCase (e.g.,MenuHamburger.vue)
Use Vue 3.5 TypeScript-style default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
Prefercomputed()overrefwithwatchwhen deriving values
PreferuseModelover separately defining prop and emit for two-way binding
Usevue-i18nin composition API for string literals; place new translation entries insrc/locales/en/main.json
Usecn()utility function from@/utils/tailwindUtilfor merging Tailwind class names; do not use:class="[]"syntax
Do not use thedark:Tailwind variant; use semantic values from thestyle.csstheme instead (e.g.,bg-node-component-surface)
Do not use!importantor the!important prefix for Tailwind classes; find and correct interfering!importantclasses instead
Avoid new usage of PrimeVue components; use VueUse, shadcn/vue, or Reka UI instead
Leverage VueUse functions for performance-enhancing styles in Vue components
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not useanytype oras anytype assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
**/*.{ts,tsx,vue,js,jsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width
Files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
🧠 Learnings (26)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Do not use the `dark:` Tailwind variant; use semantic values from the `style.css` theme instead (e.g., `bg-node-component-surface`)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use Tailwind 4 for styling in Vue components; avoid `<style>` blocks
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use Tailwind CSS only for styling (no custom CSS)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use Tailwind CSS for styling
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Do not use the `dark:` Tailwind variant; use semantic values from the `style.css` theme instead (e.g., `bg-node-component-surface`)
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/load3d/controls/LightControls.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/TopMenuSection.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/components/input/MultiSelect.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/PopupSlider.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-12-18T20:39:30.137Z
Learnt from: jtydhr88
Repo: Comfy-Org/ComfyUI_frontend PR: 7621
File: src/components/load3d/Load3DScene.vue:4-4
Timestamp: 2025-12-18T20:39:30.137Z
Learning: In src/components/load3d/Load3DScene.vue, the scoped `<style>` block with `!important` declarations for the canvas element is necessary because Three.js dynamically creates the canvas with inline styles, preventing direct application of Tailwind classes. This is a valid exception to the Tailwind-only styling guideline.
Applied to files:
src/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/Load3DControls.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/Load3DControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Applied to files:
src/components/load3d/controls/ExportControls.vuesrc/components/load3d/Load3DControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
src/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/RecordingControls.vue
📚 Learning: 2025-12-21T06:04:12.562Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use `cn()` utility function from `@/utils/tailwindUtil` for merging Tailwind class names; do not use `:class="[]"` syntax
Applied to files:
src/components/load3d/controls/ModelControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/PopupSlider.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Applied to files:
src/components/load3d/LoadingOverlay.vue
📚 Learning: 2025-12-11T03:55:51.755Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels
Applied to files:
src/components/load3d/controls/PopupSlider.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/components/load3d/controls/PopupSlider.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: test
- GitHub Check: lint-and-format
- GitHub Check: collect
🔇 Additional comments (14)
src/components/input/MultiSelect.vue (1)
163-163: LGTM! Theme-aware token correctly applied.The replacement of
text-whitewithtext-base-foregroundaligns with the PR objectives and ensures the check icon is visible in both light and dark themes.As per the PR test plan, verify that the checkbox icon has sufficient contrast against the
bg-primary-backgroundin both light and dark themes.src/components/load3d/controls/AnimationControls.vue (1)
18-18: LGTM! Theme token migration applied correctly.The text color updates from
text-whitetotext-base-foregroundcorrectly implement theme-aware styling for both the play/pause icon and the time display, ensuring proper visibility across light and dark themes.Based on learnings and coding guidelines for using semantic tokens from the design system.
Also applies to: 49-49
src/components/load3d/controls/LightControls.vue (1)
15-15: LGTM! Icon color updated correctly.The sun icon color change to
text-base-foregroundaligns with the theme-aware token migration.Based on learnings and coding guidelines for using semantic tokens from the design system.
src/components/TopMenuSection.vue (1)
52-52: LGTM! Badge text color updated correctly.The queue count badge text color change to
text-base-foregroundensures proper theme-aware visibility and aligns with the PR's objective of replacing hardcoded white text.Based on learnings and coding guidelines for using semantic tokens from the design system.
src/renderer/extensions/vueNodes/VideoPreview.vue (1)
23-33: LGTM! Error state styling migrated correctly.The error state UI appropriately uses
bg-muted-backgroundandtext-muted-foregroundtokens, providing proper theme-aware styling with appropriate visual hierarchy for error messages.Based on learnings and coding guidelines for using semantic tokens from the design system.
src/components/load3d/controls/ExportControls.vue (1)
15-15: LGTM! Export controls theme tokens applied correctly.All three styling updates properly implement theme-aware tokens:
- Icon uses
text-base-foreground- Panel surface uses
bg-interface-menu-surface- Button text uses
text-base-foregroundThese changes ensure consistent theming across light and dark modes.
Based on learnings and coding guidelines for using semantic tokens from the design system.
Also applies to: 19-19, 26-26
src/components/load3d/controls/PopupSlider.vue (1)
11-11: Popup slider theming updates are correct.The changes properly implement theme-aware styling:
- Icon color now uses
text-base-foregroundfor theme adaptation- Popup background now uses
bg-interface-menu-surfacesemantic token instead of hardcoded translucent blackThese align with the PR objective to use semantic surface tokens for dropdown/popup menus.
Also applies to: 15-15
src/components/load3d/controls/SceneControls.vue (1)
11-11: Scene control icon theming is consistently applied.All five scene control icons (grid, palette, image, globe, times) have been correctly updated from
text-whitetotext-base-foreground, ensuring consistent theme-aware styling across all scene control buttons.Also applies to: 26-26, 51-51, 79-79, 101-101
src/components/load3d/controls/ViewerControls.vue (1)
2-2: Viewer controls theming correctly implemented.The changes properly update the viewer controls to use theme-aware tokens:
- Container background now uses
bg-backdrop/30semantic token (replacingbg-smoke-700/30)- Expand icon uses
text-base-foregroundfor theme adaptationBoth changes align with the PR's control panel theming objectives.
Also applies to: 15-15
src/components/load3d/controls/RecordingControls.vue (1)
2-2: Recording controls comprehensively themed.All recording control UI elements have been correctly updated to use theme-aware tokens:
- Container background:
bg-backdrop/30(replacingbg-smoke-700/30)- Recording toggle, export, and clear icons:
text-base-foreground- Duration display text:
text-base-foregroundThis ensures all elements are visible and properly themed in both light and dark modes.
Also applies to: 28-28, 45-45, 60-60, 65-65
src/components/load3d/controls/CameraControls.vue (1)
14-14: Theme-aware icon color update is correct.The replacement of
text-whitewithtext-base-foregroundcorrectly implements theme support for the camera control icon. The semantic token is properly defined in the design system with theme variants (light mode: charcoal-800, dark mode: white).src/components/load3d/Load3DControls.vue (1)
3-3: LGTM! Theme token updates are correctly applied.The replacement of hardcoded colors with semantic tokens (
bg-backdrop/30,text-base-foreground,bg-interface-menu-surface,bg-button-active-surface) follows the design system guidelines and improves theme consistency.Based on learnings, using tokens from style.css is the correct approach.
Also applies to: 17-17, 22-22, 32-32, 38-38, 172-172
src/components/load3d/LoadingOverlay.vue (1)
5-5: LGTM! Theme token updates are correctly applied.The overlay now uses semantic tokens (
bg-backdrop/50,text-base-foreground) that adapt to the active theme.Also applies to: 9-9
src/components/load3d/controls/ModelControls.vue (1)
15-15: LGTM! Theme token migration is correctly implemented.All color token replacements (
text-base-foreground,bg-interface-menu-surface) follow the design system guidelines. The use ofcn()utility for composing classes is correct, and the semantic tokens will properly adapt to theme changes.Based on learnings, using semantic values from style.css without dark: variants is the correct approach.
Also applies to: 19-19, 27-31, 52-52, 56-56, 65-65, 89-89
Myestery
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/renderer/extensions/vueNodes/VideoPreview.vue (1)
106-106: Consider using a semantic token for error state.The dimensions section uses
text-red-400to indicate video error, while the main error state (lines 23-34) now uses semantic tokens. For consistency and theme compatibility, consider replacing this with a semantic error token.♻️ Suggested improvement
- <span v-if="videoError" class="text-red-400"> + <span v-if="videoError" class="text-destructive-foreground"> {{ $t('g.errorLoadingVideo') }} </span>Note: Verify the correct semantic token for error text in your design system (e.g.,
text-destructive-foreground,text-error-foreground, or similar).
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
browser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.ts-snapshots/vue-nodes-upload-widgets-chromium-linux.pngis excluded by!**/*.png
📒 Files selected for processing (1)
src/renderer/extensions/vueNodes/VideoPreview.vue
🧰 Additional context used
📓 Path-based instructions (7)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/renderer/extensions/vueNodes/VideoPreview.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/renderer/extensions/vueNodes/VideoPreview.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/renderer/extensions/vueNodes/VideoPreview.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/renderer/extensions/vueNodes/VideoPreview.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3.5+ with TypeScript in.vuefiles, exclusively using Composition API with<script setup lang="ts">syntax
Use Tailwind 4 for styling in Vue components; avoid<style>blocks
Name Vue components using PascalCase (e.g.,MenuHamburger.vue)
Use Vue 3.5 TypeScript-style default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
Prefercomputed()overrefwithwatchwhen deriving values
PreferuseModelover separately defining prop and emit for two-way binding
Usevue-i18nin composition API for string literals; place new translation entries insrc/locales/en/main.json
Usecn()utility function from@/utils/tailwindUtilfor merging Tailwind class names; do not use:class="[]"syntax
Do not use thedark:Tailwind variant; use semantic values from thestyle.csstheme instead (e.g.,bg-node-component-surface)
Do not use!importantor the!important prefix for Tailwind classes; find and correct interfering!importantclasses instead
Avoid new usage of PrimeVue components; use VueUse, shadcn/vue, or Reka UI instead
Leverage VueUse functions for performance-enhancing styles in Vue components
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/renderer/extensions/vueNodes/VideoPreview.vue
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not useanytype oras anytype assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code
Files:
src/renderer/extensions/vueNodes/VideoPreview.vue
**/*.{ts,tsx,vue,js,jsx,json,css}
📄 CodeRabbit inference engine (AGENTS.md)
Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width
Files:
src/renderer/extensions/vueNodes/VideoPreview.vue
🧠 Learnings (12)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Do not use the `dark:` Tailwind variant; use semantic values from the `style.css` theme instead (e.g., `bg-node-component-surface`)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Do not use `!important` or the `!` important prefix for Tailwind classes; find and correct interfering `!important` classes instead
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use Tailwind 4 for styling in Vue components; avoid `<style>` blocks
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.562Z
Learning: Applies to **/*.vue : Use `cn()` utility function from `@/utils/tailwindUtil` for merging Tailwind class names; do not use `:class="[]"` syntax
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use Tailwind CSS for styling
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use Tailwind CSS only for styling (no custom CSS)
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In Comfy-Org/ComfyUI_frontend, the `cn` utility function from `@/utils/tailwindUtil` uses `tailwind-merge`, which intelligently resolves conflicting Tailwind classes by keeping the last one. When a component uses `cn('base-classes bg-default', propClass)`, if `propClass` contains a conflicting background class, `tailwind-merge` will correctly override `bg-default` with the value from `propClass`. This additive pattern is correct and intentional, following the shadcn-ui convention.
</learning]
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:16.031Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, avoid creating single-use variants for the Button component (and other UI components). Variants should be reusable across multiple use cases. It's acceptable to use a mix of variant props and manual Tailwind classes temporarily when a specific styling need exists in only one place, with consolidation deferred to a later phase when patterns emerge.
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-11T03:55:51.755Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: deploy-and-comment
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: test
- GitHub Check: collect
🔇 Additional comments (1)
src/renderer/extensions/vueNodes/VideoPreview.vue (1)
23-34: Correct alignment with ImagePreview error state.The error state implementation (lines 23-34) is properly aligned with ImagePreview using semantic tokens (
bg-muted-background,text-base-foreground) and therole="alert"accessibility attribute. This ensures consistent behavior and appearance across light and dark themes.
Myestery
added
the
New Browser Test Expectations
github-actions
bot
removed
the
New Browser Test Expectations
Replace hardcoded `text-white` class with theme-aware alternatives to fix invisible text on light themes. Changes: - UI components: use `text-base-foreground` for text on primary backgrounds - Load3D controls: use `text-base-foreground` for icons and labels - VideoPreview: use `text-base-foreground` and `text-muted-foreground` - Dropdown menus: use `bg-interface-menu-surface` for backgrounds - Control panels: use `bg-backdrop/30` for semi-transparent backgrounds - Selected states: use `bg-button-active-surface` for active items - Loading overlays: use `bg-backdrop/50` for overlay backgrounds
- Add role="alert" for accessibility - Use text-base-foreground consistently for error text
Myestery
force-pushed
the
fix/replace-text-white-with-theme-aware-colors
branch
from
1203286 to
86cff5b
Compare
Myestery
added
the
New Browser Test Expectations
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/components/load3d/controls/LightControls.vue (1)
19-19: Inconsistent: Panel background should use theme-aware token.Line 19 still uses
bg-black/50, which is inconsistent with the PR's goal. According to the PR summary and the pattern in ExportControls.vue, popup panels should usebg-interface-menu-surfacefor proper theming.🎨 Proposed fix
<div v-show="showLightIntensity" - class="absolute top-0 left-12 rounded-lg bg-black/50 p-4 shadow-lg" + class="absolute top-0 left-12 rounded-lg bg-interface-menu-surface p-4 shadow-lg" style="width: 150px" >src/components/load3d/controls/SceneControls.vue (1)
7-7: Replace hardcoded ring colors with semantic design system tokens.Lines 7 and 73 use
ring-white/50for active state indicators. Replace with a theme-aware semantic token from the design system (e.g.,ring-node-component-ringor a similar button-specific active state token if available) to ensure the ring color adapts correctly to both light and dark themes.src/components/load3d/Load3DControls.vue (1)
46-46: Inconsistent background token usage.Line 46 still uses
bg-smoke-700/30while line 3 was updated tobg-backdrop/30. Both appear to be backdrop containers for control panels and should use the same semantic token for visual consistency.🎨 Proposed fix for consistency
- <div v-show="activeCategory" class="rounded-lg bg-smoke-700/30"> + <div v-show="activeCategory" class="rounded-lg bg-backdrop/30">
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (14)
src/components/TopMenuSection.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/LightControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vue
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Use Vue 3 Single File Components (SFCs) with Composition API only; never use Options API
Use<script setup lang="ts">syntax for component logic
Use Tailwind 4 utility classes for styling; avoid<style>blocks in Vue components
Do not use thedark:Tailwind variant; use semantic values fromstyle.csstheme instead (e.g.,bg-node-component-surface)
Usecn()utility from@/utils/tailwindUtilfor merging class names; never use:class="[]"syntax
Never use!importantor the!prefix for Tailwind classes; find and fix interfering classes instead
Use Tailwind fraction utilities instead of arbitrary percentages (e.g.,w-4/5instead ofw-[80%],w-1/2instead ofw-[50%])
Use Vue 3.5 TypeScript style default prop declaration with destructuring; avoidwithDefaultsand runtime props
UsedefineModelfor v-model bindings instead of separately defining props and emits
Prefer reactive props destructuring overconst props = defineProps<...>
Define slots via template usage, notdefineSlots
Use same-name shorthand for slot prop bindings (e.g.,:isExpandedinstead of:is-expanded="isExpanded")
Usereffor reactive state,computed()for computed properties, andwatch/watchEffectfor side effects
Avoid usingrefandwatcht...
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.jsonLeverage VueUse functions for performance-enhancing utilities
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: Use separateimport typestatements; do not mix inlinetypeimports in the same statement
Sort and group imports by plugin; runpnpm formatbefore committing
Derive component types usingvue-component-type-helpers(ComponentProps,ComponentSlots) instead of separate type files
Code should be well-designed with clear names for everything; write code that is expressive and self-documenting
Avoid redundant comments and clean up code as you go; comments should explain why, not what
Ask if there is a simpler way to implement functionality; refactor complex code to simplify it
Minimize nesting depth (e.g.,if () { ... }orfor () { ... }); watch for arrow anti-pattern
Watch out for code smells and refactor to avoid them
Never useanytype; use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Indent with 2 spaces; use single quotes; no trailing semicolons; max line width 80 (per .prettierrc)
Complex type definitions used in multiple related places should be extracted and named for reuse
Implement proper error handling
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/components/load3d/controls/LightControls.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/components/load3d/controls/LightControls.vue
src/components/**/*.vue
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue componentsName Vue components in PascalCase (e.g., MenuHamburger.vue)
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/components/load3d/controls/LightControls.vue
src/components/**/*.{vue,css}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/components/load3d/controls/LightControls.vue
src/components/**/*.{vue,ts,js}
📄 CodeRabbit inference engine (src/components/CLAUDE.md)
src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings
Files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/components/load3d/controls/LightControls.vue
🧠 Learnings (28)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Do not use the `dark:` Tailwind variant; use semantic values from `style.css` theme instead (e.g., `bg-node-component-surface`)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Use Tailwind 4 utility classes for styling; avoid `<style>` blocks in Vue components
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Use Tailwind fraction utilities instead of arbitrary percentages (e.g., `w-4/5` instead of `w-[80%]`, `w-1/2` instead of `w-[50%]`)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Never use `!important` or the `!` prefix for Tailwind classes; find and fix interfering classes instead
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use Tailwind CSS for styling
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use Tailwind CSS only for styling (no custom CSS)
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Use `cn()` utility from `@/utils/tailwindUtil` for merging class names; never use `:class="[]"` syntax
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In Comfy-Org/ComfyUI_frontend, the `cn` utility function from `@/utils/tailwindUtil` uses `tailwind-merge`, which intelligently resolves conflicting Tailwind classes by keeping the last one. When a component uses `cn('base-classes bg-default', propClass)`, if `propClass` contains a conflicting background class, `tailwind-merge` will correctly override `bg-default` with the value from `propClass`. This additive pattern is correct and intentional, following the shadcn-ui convention.
</learning]
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/Load3DControls.vue
📚 Learning: 2025-12-18T16:03:02.066Z
Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-22T21:36:08.369Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2026-01-08T02:26:18.357Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-18T21:15:46.862Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-12-21T01:06:02.786Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.
Applied to files:
src/components/TopMenuSection.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vuesrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/components/load3d/controls/PopupSlider.vuesrc/components/load3d/LoadingOverlay.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InputSwitch component with ToggleSwitch
Applied to files:
src/components/load3d/controls/PopupSlider.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels
Applied to files:
src/components/load3d/controls/PopupSlider.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer
Applied to files:
src/components/load3d/controls/PopupSlider.vue
📚 Learning: 2025-12-18T20:39:30.137Z
Learnt from: jtydhr88
Repo: Comfy-Org/ComfyUI_frontend PR: 7621
File: src/components/load3d/Load3DScene.vue:4-4
Timestamp: 2025-12-18T20:39:30.137Z
Learning: In src/components/load3d/Load3DScene.vue, the scoped `<style>` block with `!important` declarations for the canvas element is necessary because Three.js dynamically creates the canvas with inline styles, preventing direct application of Tailwind classes. This is a valid exception to the Tailwind-only styling guideline.
Applied to files:
src/components/load3d/LoadingOverlay.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/CameraControls.vuesrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/ViewerControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue InlineMessage component with Message
Applied to files:
src/components/load3d/LoadingOverlay.vue
📚 Learning: 2026-01-09T00:50:57.103Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Do not use the `dark:` Tailwind variant; use semantic values from `style.css` theme instead (e.g., `bg-node-component-surface`)
Applied to files:
src/components/load3d/LoadingOverlay.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/LightControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/components/input/MultiSelect.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{vue,ts,tsx} : Follow Vue 3 composition API style guide
Applied to files:
src/components/load3d/controls/RecordingControls.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/controls/ExportControls.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/load3d/Load3DControls.vuesrc/components/load3d/controls/ExportControls.vue
📚 Learning: 2026-01-09T00:50:57.103Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Follow Vue 3 style guide and naming conventions
Applied to files:
src/components/load3d/Load3DControls.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,css} : Use the correct tokens from style.css in the design system package
Applied to files:
src/components/load3d/controls/ExportControls.vue
📚 Learning: 2025-11-24T19:47:34.324Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`
Applied to files:
src/components/load3d/controls/ExportControls.vue
📚 Learning: 2026-01-09T00:50:57.103Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-09T00:50:57.103Z
Learning: Applies to src/**/*.vue : Use `cn()` utility from `@/utils/tailwindUtil` for merging class names; never use `:class="[]"` syntax
Applied to files:
src/components/load3d/controls/ModelControls.vue
📚 Learning: 2025-12-11T03:55:51.755Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.
Applied to files:
src/renderer/extensions/vueNodes/VideoPreview.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: collect
- GitHub Check: test
🔇 Additional comments (14)
src/components/input/MultiSelect.vue (1)
163-163: LGTM: Theme-aware token correctly applied.The check icon color update from
text-whitetotext-base-foregroundproperly enables theme compatibility, ensuring visibility in both light and dark themes as intended by this PR.src/components/load3d/controls/AnimationControls.vue (1)
18-18: LGTM: Animation controls styling updated for theme compatibility.Both the play/pause icon and time display now use
text-base-foreground, ensuring proper visibility across themes without affecting control functionality.Also applies to: 49-49
src/components/load3d/controls/CameraControls.vue (1)
14-14: LGTM: Camera icon theming updated.The icon color update to
text-base-foregroundcorrectly aligns with the theme-aware token migration.src/components/TopMenuSection.vue (1)
57-57: LGTM: Queue badge styling updated.The badge text color change to
text-base-foregroundensures proper contrast and visibility in both light and dark themes.src/components/load3d/controls/PopupSlider.vue (1)
11-11: LGTM: Slider popup styling updated with semantic tokens.Both the icon color (
text-base-foreground) and panel background (bg-interface-menu-surface) now use appropriate semantic tokens, ensuring consistent theming across the Load3D controls.Also applies to: 15-15
src/components/load3d/controls/LightControls.vue (1)
15-15: LGTM: Icon color updated to theme-aware token.The sun icon color correctly uses
text-base-foregroundfor theme compatibility.src/components/load3d/controls/SceneControls.vue (1)
11-11: LGTM: Icon colors updated to theme-aware tokens.All icon colors correctly use
text-base-foregroundfor theme compatibility across the scene control buttons.Also applies to: 26-26, 51-51, 79-79, 101-101
src/components/load3d/controls/ViewerControls.vue (1)
2-2: LGTM: Container and icon colors updated to theme-aware tokens.Both the container background (
bg-backdrop/30) and expand icon color (text-base-foreground) correctly use semantic tokens for proper theming.Also applies to: 15-15
src/components/load3d/controls/ExportControls.vue (1)
15-15: LGTM: All color tokens updated correctly.The download icon, export panel background, and button text all use appropriate semantic tokens (
text-base-foregroundandbg-interface-menu-surface) for proper theme support.Also applies to: 19-19, 26-26
src/components/load3d/controls/RecordingControls.vue (1)
2-2: LGTM: All color tokens updated correctly.The container background, all icon colors, and duration text correctly use semantic tokens (
bg-backdrop/30andtext-base-foreground) for proper theme support across recording controls.Also applies to: 28-28, 45-45, 60-60, 65-65
src/components/load3d/LoadingOverlay.vue (1)
5-5: LGTM! Theme-aware tokens correctly applied.The changes properly replace hardcoded color values with semantic theme tokens using correct Tailwind v4 slash syntax for opacity.
Also applies to: 9-9
src/renderer/extensions/vueNodes/VideoPreview.vue (1)
23-34: LGTM! Error state styling correctly updated with theme tokens and accessibility improvement.The addition of
role="alert"improves accessibility, and the color token replacements ensure proper theme support across light and dark modes.src/components/load3d/Load3DControls.vue (1)
3-3: LGTM! Theme tokens correctly applied.All changed lines properly use semantic theme tokens following Tailwind v4 conventions.
Also applies to: 17-17, 22-22, 32-32, 38-38, 172-172
src/components/load3d/controls/ModelControls.vue (1)
15-15: LGTM! Theme tokens properly applied throughout.All color token replacements are correct, and the use of the
cn()utility for class merging follows project conventions.Also applies to: 19-19, 27-30, 52-52, 56-56, 65-65, 89-89
github-actions
bot
removed
the
New Browser Test Expectations
3 participants
Summary
text-whiteclass with theme-aware alternatives to fix invisible text on light themesbg-interface-menu-surfacebg-backdropwith opacityChanges
text-whitetext-base-foregroundbg-black/50bg-interface-menu-surfacebg-smoke-700/30bg-backdrop/30bg-black bg-opacity-50bg-backdrop/50bg-smoke-600bg-button-active-surfaceFiles Modified (14)
src/components/TopMenuSection.vuesrc/components/input/MultiSelect.vuesrc/components/load3d/*.vue(12 files)src/renderer/extensions/vueNodes/VideoPreview.vueTest plan
┆Issue is synchronized with this Notion page by Unito