fix: text-white usage causes video dimensions to be invisible on light theme#7408
fix: text-white usage causes video dimensions to be invisible on light theme#7408
Conversation
dosubot
bot
added
the
size:XS
📝 WalkthroughWalkthroughStyling update in the VideoPreview component replacing a hardcoded white color class with a semantic muted-foreground color token for the video dimensions display. Changes
Possibly related PRs
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (7)src/**/*.vue📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{vue,ts}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/*.{vue,ts,tsx}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
**/*.vue📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx,vue,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (6)📓 Common learnings📚 Learning: 2025-12-09T20:22:23.620ZApplied to files:
📚 Learning: 2025-12-09T03:49:52.828ZApplied to files:
📚 Learning: 2025-12-09T21:40:12.361ZApplied to files:
📚 Learning: 2025-12-11T03:55:51.755ZApplied to files:
📚 Learning: 2025-12-11T12:25:15.470ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Comment |
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 12/12/2025, 08:17:23 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/12/2025, 08:08:52 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.24 MB (baseline 3.24 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 983 kB (baseline 983 kB) • 🔴 +11 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 178 kB (baseline 178 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.81 MB (baseline 3.81 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
christian-byrne
added
needs-backport
…t theme (#7408) ## Summary All other usages of `text-white` in the codebase require also changing the bg color to be a semantic token. This is the only case where the bg is theme-aware and the text is hardcoded. | Before | After | | --------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------- | | <img width="1515" height="1155" alt="Screenshot from 2025-12-12 00-03-15" src="https://github.com/user-attachments/assets/f15bfc48-ded6-4a20-b693-f8d2a2f4cc5b" /> | <img width="1515" height="1155" alt="Screenshot from 2025-12-12 00-03-22" src="https://github.com/user-attachments/assets/5dfd7345-0052-48ea-ad77-ecd7f3aa4b89" /> | ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7408-fix-text-white-usage-causes-video-dimensions-to-be-invisible-on-light-theme-2c76d73d365081668eafef95639a42f9) by [Unito](https://www.unito.io)
|
@christian-byrne Successfully backported to #7524 |
github-actions
bot
removed
the
needs-backport
… be invisible on light theme (#7524) Backport of #7408 to `core/1.34` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7524-backport-core-1-34-fix-text-white-usage-causes-video-dimensions-to-be-invisible-on-lig-2ca6d73d365081bf9622e5beba5e68f0) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…t theme (Comfy-Org#7408) ## Summary All other usages of `text-white` in the codebase require also changing the bg color to be a semantic token. This is the only case where the bg is theme-aware and the text is hardcoded. | Before | After | | --------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------- | | <img width="1515" height="1155" alt="Screenshot from 2025-12-12 00-03-15" src="https://github.com/user-attachments/assets/f15bfc48-ded6-4a20-b693-f8d2a2f4cc5b" /> | <img width="1515" height="1155" alt="Screenshot from 2025-12-12 00-03-22" src="https://github.com/user-attachments/assets/5dfd7345-0052-48ea-ad77-ecd7f3aa4b89" /> | ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7408-fix-text-white-usage-causes-video-dimensions-to-be-invisible-on-light-theme-2c76d73d365081668eafef95639a42f9) by [Unito](https://www.unito.io)
…t theme (#7408) ## Summary All other usages of `text-white` in the codebase require also changing the bg color to be a semantic token. This is the only case where the bg is theme-aware and the text is hardcoded. | Before | After | | --------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------- | | <img width="1515" height="1155" alt="Screenshot from 2025-12-12 00-03-15" src="https://github.com/user-attachments/assets/f15bfc48-ded6-4a20-b693-f8d2a2f4cc5b" /> | <img width="1515" height="1155" alt="Screenshot from 2025-12-12 00-03-22" src="https://github.com/user-attachments/assets/5dfd7345-0052-48ea-ad77-ecd7f3aa4b89" /> | ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7408-fix-text-white-usage-causes-video-dimensions-to-be-invisible-on-light-theme-2c76d73d365081668eafef95639a42f9) by [Unito](https://www.unito.io)
3 participants
Summary
All other usages of
text-whitein the codebase require also changing the bg color to be a semantic token. This is the only case where the bg is theme-aware and the text is hardcoded.┆Issue is synchronized with this Notion page by Unito