Skip to content

fix: 3d resize vertically #7621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtydhr88 merged 5 commits into from
Dec 20, 2025
Merged

fix: 3d resize vertically #7621

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5cbd54
fix: 3d resize vertically
kaili-yang Dec 18, 2025
54579a9
fix 3d resize
kaili-yang Dec 19, 2025
75e854e
fix load3d resize bug
kaili-yang Dec 19, 2025
67f84fa
style(css): use inset-0 instead of top/left
kaili-yang Dec 19, 2025
0c0b51b
Merge branch 'main' into fix-3d-resize
kaili-yang Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/load3d/Load3DScene.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div
ref="container"
class="relative h-full w-full"
class="relative h-full w-full min-h-0 overflow-hidden"
Comment thread
jtydhr88 marked this conversation as resolved.
Outdated
data-capture-wheel="true"
@pointerdown.stop
@pointermove.stop
Expand Down Expand Up @@ -65,3 +65,15 @@ onUnmounted(() => {
props.cleanup()
})
</script>

<style scoped>

@DrJKL DrJKL Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to avoid new <style> or <style scoped> tags.
Is there a way you can target these to the canvas directly?

Also, same question about any !importants. There's always ™️ a better way.

@DrJKL DrJKL Dec 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/load3d/Load3d.ts#L75
Looks like here maybe?

@kaili-yang kaili-yang Dec 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the guidance and the good example. 👍 I’ll revise the code and align with the approach going forward.

:deep(canvas) {
position: absolute !important;
top: 0;
left: 0;
width: 100% !important;
height: 100% !important;
display: block !important;
outline: none;
}
</style>
Loading