fix: 3d resize vertically by kaili-yang · Pull Request #7621 · Comfy-Org/ComfyUI_frontend

kaili-yang · 2025-12-18T20:30:46Z

Summary

Fix an issue #7620 where 3D nodes could be resized vertically only in the expanding direction but could not be shrunk.

Changes

What:
- Allow the 3D node content container to shrink by removing h-full and adding min-h-0 flex-1.
- Prevent the internal canvas from reasserting its previous height during parent resize by avoiding h-full and constraining it with max-h-full.
Dependencies:
- None

Review Focus

Verify that vertical resize works in both directions for 3D nodes.
Ensure the canvas still resizes correctly with the node and that three.js rendering is unaffected.
Confirm no regression in pointer events, overlays, or resize handles.

Screenshots

before

before.3d.resize.mp4

after

after.3d.resize.mp4

┆Issue is synchronized with this Notion page by Unito

coderabbitai · 2025-12-18T20:30:59Z

📝 Walkthrough

Walkthrough

Changed the Load3d renderer DOM element classes to absolute, full-size positioning and updated handleResize to compute container dimensions from the renderer's parent element rather than the canvas element itself.

Changes

Cohort / File(s)	Change Summary
Load3d Component Styling & Sizing `src/extensions/core/load3d/Load3d.ts`	Replaced renderer canvas class list with absolute full-size layout (`absolute`, `inset-0`, `h-full`, `w-full`, `outline-none`) and modified `handleResize` to derive container dimensions from `this.renderer.domElement?.parentElement`.

Possibly related PRs

improve logic of 3d scene size #7619: Also modifies Load3d sizing/layout logic and viewer-dimension behavior.
Fix: Widget sizing with multiple expanding items #7118: Adjusts Load3D container/class names and sizing, related to this change in canvas CSS and parent-based sizing.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67f84fa and 0c0b51b.

📒 Files selected for processing (1)

src/extensions/core/load3d/Load3d.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (7)

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

src/extensions/core/load3d/Load3d.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

src/**/*.ts: Extract complex type definitions that are inlined in multiple related places - name them for reuse
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones

Files:

src/extensions/core/load3d/Load3d.ts

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

src/extensions/core/load3d/Load3d.ts

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/extensions/core/load3d/Load3d.ts

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

src/extensions/core/load3d/Load3d.ts

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

src/extensions/core/load3d/Load3d.ts

src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Do not use function expressions - use function declarations instead when possible

Files:

src/extensions/core/load3d/Load3d.ts

🧠 Learnings (5)

📚 Learning: 2025-12-18T20:39:25.533Z

Learnt from: jtydhr88
Repo: Comfy-Org/ComfyUI_frontend PR: 7621
File: src/components/load3d/Load3DScene.vue:4-4
Timestamp: 2025-12-18T20:39:25.533Z
Learning: In src/components/load3d/Load3DScene.vue, the scoped `<style>` block with `!important` declarations for the canvas element is necessary because Three.js dynamically creates the canvas with inline styles, preventing direct application of Tailwind classes. This is a valid exception to the Tailwind-only styling guideline.

Applied to files:

src/extensions/core/load3d/Load3d.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

src/extensions/core/load3d/Load3d.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

src/extensions/core/load3d/Load3d.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

src/extensions/core/load3d/Load3d.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/extensions/core/load3d/Load3d.ts

🔇 Additional comments (2)

src/extensions/core/load3d/Load3d.ts (2)

75-81: LGTM! Canvas positioning updated to fix resize behavior.

The change to absolute positioning with inset-0 correctly allows the canvas to respond to parent container resizing. The addition of outline-none prevents unwanted focus outlines on the canvas.

Note: This absolute positioning requires the parent container to have position: relative, absolute, or fixed. Based on the PR description indicating the fix works as intended, I'm assuming the parent container in Load3DScene.vue has appropriate positioning.

617-626: Excellent fix! Using parent dimensions resolves the resize issue.

This is the key change that fixes vertical shrinking. By measuring the parent container's dimensions instead of the canvas element itself, the resize logic now correctly determines the target size. The canvas was previously unable to shrink because it was measuring its own (stale) dimensions.

The optional chaining and null check provide appropriate defensive programming.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-18T20:31:11Z

🎭 Playwright Test Results

Tests are starting...

⏰ Started at: 12/19/2025, 08:32:43 PM UTC

🚀 Running Tests

🧪 chromium: Running tests...
🧪 chromium-0.5x: Running tests...
🧪 chromium-2x: Running tests...
🧪 mobile-chrome: Running tests...

⏱️ Please wait while tests are running...

github-actions · 2025-12-18T20:31:16Z

🎨 Storybook Build Status

Build is starting...

⏰ Started at: 12/19/2025, 08:32:43 PM UTC

🚀 Building Storybook

📦 Installing dependencies...
🔧 Building Storybook components...
🌐 Preparing deployment to Cloudflare Pages...

⏱️ Please wait while the Storybook build is in progress...

jtydhr88

Great! super thanks for this!

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa1719f and f5cbd54.

📒 Files selected for processing (1)

src/components/load3d/Load3DScene.vue (2 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use <script setup lang="ts"> for component logic
Use Tailwind 4 utility classes for styling - avoid <style> blocks
Use cn() utility from @/utils/tailwindUtil to merge Tailwind class names - never use :class="[]" syntax
Never use the dark: Tailwind variant - use semantic values from style.css theme instead (e.g., bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - prefer useModel to prop/emit pairs, do not use withDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries in src/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components

Files:

src/components/load3d/Load3DScene.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

src/components/load3d/Load3DScene.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

src/components/load3d/Load3DScene.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

src/components/load3d/Load3DScene.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/components/load3d/Load3DScene.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

src/components/load3d/Load3DScene.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue components must be named in PascalCase (e.g., MenuHamburger.vue)

Files:

src/components/load3d/Load3DScene.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

src/components/load3d/Load3DScene.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

src/components/load3d/Load3DScene.vue

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

src/components/load3d/Load3DScene.vue

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

src/components/load3d/Load3DScene.vue

🧠 Learnings (7)

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Follow Vue 3 style guide and naming conventions

Applied to files:

src/components/load3d/Load3DScene.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

src/components/load3d/Load3DScene.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

src/components/load3d/Load3DScene.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

src/components/load3d/Load3DScene.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/components/load3d/Load3DScene.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

src/components/load3d/Load3DScene.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

src/components/load3d/Load3DScene.vue

🔇 Additional comments (1)

src/components/load3d/Load3DScene.vue (1)

69-79: Add comment explaining why style block is necessary; current implementation is justified.

The <style scoped> block violates the "no custom CSS" guideline in normal circumstances, but this is a justified exception: the canvas element is dynamically created by initializeLoad3d (three.js), so Tailwind utilities cannot be applied via the template. The :deep(canvas) selector and custom CSS are the only viable approach.

Improvements:

Add a code comment explaining: /* Three.js generates canvas dynamically; :deep() selector required */

The !important declarations are necessary to override three.js inline styles—this is appropriate here.

The outline: none is correct for this use case: the canvas is non-interactive (no tabindex, all pointer events stopped on the container), so it's not a keyboard focus/accessibility violation.

src/components/load3d/Load3DScene.vue

github-actions · 2025-12-18T20:34:36Z

Bundle Size Report

Summary

Raw size: 16.6 MB baseline 16.6 MB — 🔴 +109 B
Gzip: 3.37 MB baseline 3.37 MB — 🟢 -23 B
Brotli: 2.6 MB baseline 2.6 MB — 🟢 -63 B
Bundles: 99 current • 99 baseline • 42 added / 42 removed

Category Glance
App Entry Points 🔴 +109 B (3.21 MB) · Vendor & Third-Party ⚪ 0 B (8.46 MB) · Other ⚪ 0 B (3.44 MB) · Graph Workspace ⚪ 0 B (996 kB) · Panels & Settings ⚪ 0 B (297 kB) · UI Components ⚪ 0 B (184 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.21 MB (baseline 3.21 MB) • 🔴 +109 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-fJxQfIRP.js (new)	—	2.98 MB	🔴 +2.98 MB	🔴 +629 kB	🔴 +478 kB
~~assets/index-CWk2GfY8.js~~ (removed)	2.98 MB	—	🟢 -2.98 MB	🟢 -629 kB	🟢 -478 kB
~~assets/index-9LEs_vo4.js~~ (removed)	227 kB	—	🟢 -227 kB	🟢 -48.5 kB	🟢 -39.9 kB
assets/index-N8vpcY_b.js (new)	—	227 kB	🔴 +227 kB	🔴 +48.5 kB	🔴 +39.8 kB
~~assets/index-qy5JWqqQ.js~~ (removed)	345 B	—	🟢 -345 B	🟢 -247 B	🟢 -234 B
assets/index-tG1mmvGP.js (new)	—	345 B	🔴 +345 B	🔴 +243 B	🔴 +226 B

Status: 3 added / 3 removed

Graph Workspace — 996 kB (baseline 996 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/GraphView-GUrFVxsS.js (new)	—	996 kB	🔴 +996 kB	🔴 +195 kB	🔴 +148 kB
~~assets/GraphView-nnWt72XX.js~~ (removed)	996 kB	—	🟢 -996 kB	🟢 -195 kB	🟢 -148 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/UserSelectView-DTtyLI-Q.js~~ (removed)	6.54 kB	—	🟢 -6.54 kB	🟢 -2.14 kB	🟢 -1.89 kB
assets/UserSelectView-DyJ2S2Fe.js (new)	—	6.54 kB	🔴 +6.54 kB	🔴 +2.14 kB	🔴 +1.89 kB

Status: 1 added / 1 removed

Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/LegacyCreditsPanel-Be44tEog.js (new)	—	21.4 kB	🔴 +21.4 kB	🔴 +5.16 kB	🔴 +4.5 kB
~~assets/LegacyCreditsPanel-Cw1juBS1.js~~ (removed)	21.4 kB	—	🟢 -21.4 kB	🟢 -5.16 kB	🟢 -4.51 kB
~~assets/KeybindingPanel-9yO5mEWS.js~~ (removed)	13.6 kB	—	🟢 -13.6 kB	🟢 -3.42 kB	🟢 -3.01 kB
assets/KeybindingPanel-BbjMDNK9.js (new)	—	13.6 kB	🔴 +13.6 kB	🔴 +3.42 kB	🔴 +3.03 kB
~~assets/ExtensionPanel-B8kGVNLv.js~~ (removed)	10.8 kB	—	🟢 -10.8 kB	🟢 -2.57 kB	🟢 -2.24 kB
assets/ExtensionPanel-B9J2qRzD.js (new)	—	10.8 kB	🔴 +10.8 kB	🔴 +2.57 kB	🔴 +2.24 kB
assets/AboutPanel-BlFipOsP.js (new)	—	9.16 kB	🔴 +9.16 kB	🔴 +2.46 kB	🔴 +2.2 kB
~~assets/AboutPanel-CJuEx-kg.js~~ (removed)	9.16 kB	—	🟢 -9.16 kB	🟢 -2.46 kB	🟢 -2.2 kB
assets/ServerConfigPanel-CUOUwrUU.js (new)	—	7.07 kB	🔴 +7.07 kB	🔴 +1.98 kB	🔴 +1.76 kB
~~assets/ServerConfigPanel-DUX108oe.js~~ (removed)	7.07 kB	—	🟢 -7.07 kB	🟢 -1.98 kB	🟢 -1.76 kB
~~assets/UserPanel-BbMtWesb.js~~ (removed)	6.23 kB	—	🟢 -6.23 kB	🟢 -1.71 kB	🟢 -1.5 kB
assets/UserPanel-BiPKawTa.js (new)	—	6.23 kB	🔴 +6.23 kB	🔴 +1.71 kB	🔴 +1.5 kB
assets/settings-BhbWhsRg.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BvFz-TmQ.js	33.1 kB	33.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BxYnTA2y.js	21.5 kB	21.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C6bMjAne.js	27.1 kB	27.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C7Yhp7H7.js	24 kB	24 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CsnOn8G0.js	25.7 kB	25.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D5BGNZ7M.js	24.8 kB	24.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D7k3huHm.js	25 kB	25 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DamkILzl.js	26.4 kB	26.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-s1k0gw1Y.js	20.9 kB	20.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 184 kB (baseline 184 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/Load3D.vue_vue_type_script_setup_true_lang-BT5k0Wzi.js~~ (removed)	53.5 kB	—	🟢 -53.5 kB	🟢 -8.45 kB	🟢 -7.25 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-ZA8D1t6W.js (new)	—	53.5 kB	🔴 +53.5 kB	🔴 +8.45 kB	🔴 +7.26 kB
~~assets/WidgetSelect.vue_vue_type_script_setup_true_lang-CyKZ8KO5.js~~ (removed)	48.8 kB	—	🟢 -48.8 kB	🟢 -10.5 kB	🟢 -9.14 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DkWmZjEy.js (new)	—	48.8 kB	🔴 +48.8 kB	🔴 +10.5 kB	🔴 +9.13 kB
~~assets/LazyImage.vue_vue_type_script_setup_true_lang-4mF29wyf.js~~ (removed)	48.4 kB	—	🟢 -48.4 kB	🟢 -10.6 kB	🟢 -9.3 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-CvT3kZ6p.js (new)	—	48.4 kB	🔴 +48.4 kB	🔴 +10.6 kB	🔴 +9.3 kB
~~assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-ak13J5a1.js~~ (removed)	14.3 kB	—	🟢 -14.3 kB	🟢 -3.74 kB	🟢 -3.3 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-pTbq0mEY.js (new)	—	14.3 kB	🔴 +14.3 kB	🔴 +3.74 kB	🔴 +3.29 kB
~~assets/ComfyQueueButton-BJTcExXG.js~~ (removed)	8.49 kB	—	🟢 -8.49 kB	🟢 -2.49 kB	🟢 -2.21 kB
assets/ComfyQueueButton-DiLUUTPe.js (new)	—	8.49 kB	🔴 +8.49 kB	🔴 +2.48 kB	🔴 +2.22 kB
~~assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-7mM6T8BM.js~~ (removed)	3.68 kB	—	🟢 -3.68 kB	🟢 -1.45 kB	🟢 -1.3 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-BcCJM-iM.js (new)	—	3.68 kB	🔴 +3.68 kB	🔴 +1.45 kB	🔴 +1.3 kB
~~assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-atbEL4tC.js~~ (removed)	2.14 kB	—	🟢 -2.14 kB	🟢 -889 B	🟢 -771 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-CUMK4c-r.js (new)	—	2.14 kB	🔴 +2.14 kB	🔴 +890 B	🔴 +770 B
~~assets/MediaTitle.vue_vue_type_script_setup_true_lang-BfQOh_tv.js~~ (removed)	897 B	—	🟢 -897 B	🟢 -503 B	🟢 -464 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-rD_y4iGu.js (new)	—	897 B	🔴 +897 B	🔴 +502 B	🔴 +466 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-Bumg4_L2.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetButton-z3dAsplW.js	2.04 kB	2.04 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/keybindingService-Cy4F_Zse.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.83 kB	🔴 +1.58 kB
~~assets/keybindingService-DrIp9BYo.js~~ (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.83 kB	🟢 -1.57 kB
~~assets/audioService-B30cAJbm.js~~ (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -963 B	🟢 -823 B
assets/audioService-DtOOYlLo.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +961 B	🔴 +824 B
assets/serverConfigStore-7JI8VFS2.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.86 kB (baseline 1.86 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/audioUtils-CETxfcqC.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +650 B	🔴 +549 B
~~assets/audioUtils-DKqDtspx.js~~ (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -652 B	🟢 -541 B
assets/nodeFilterUtil-CXKCRJ-m.js	460 B	460 B	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 1 added / 1 removed

Vendor & Third-Party — 8.46 MB (baseline 8.46 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-DaR9dw3X.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-Cf7iqkoX.js	3.86 MB	3.86 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-DZ--Ysu_.js	1.96 MB	1.96 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-C1LfRdh4.js	1.37 MB	1.37 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-C1NB2Q_L.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-DSfeuQOV.js	160 kB	160 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js	420 kB	420 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 3.44 MB (baseline 3.44 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/SubscriptionRequiredDialogContent-C9v5JJyY.js~~ (removed)	28.1 kB	—	🟢 -28.1 kB	🟢 -6.36 kB	🟢 -5.51 kB
assets/SubscriptionRequiredDialogContent-CdAs88nn.js (new)	—	28.1 kB	🔴 +28.1 kB	🔴 +6.35 kB	🔴 +5.51 kB
~~assets/WidgetRecordAudio-BdKM7wf5.js~~ (removed)	20.4 kB	—	🟢 -20.4 kB	🟢 -5.23 kB	🟢 -4.63 kB
assets/WidgetRecordAudio-BMHcMZ-z.js (new)	—	20.4 kB	🔴 +20.4 kB	🔴 +5.23 kB	🔴 +4.64 kB
~~assets/AudioPreviewPlayer-29_DM4xT.js~~ (removed)	13.4 kB	—	🟢 -13.4 kB	🟢 -3.37 kB	🟢 -3.01 kB
assets/AudioPreviewPlayer-DDfWfmK_.js (new)	—	13.4 kB	🔴 +13.4 kB	🔴 +3.37 kB	🔴 +3.01 kB
~~assets/ValueControlPopover-31t-uH1K.js~~ (removed)	5.49 kB	—	🟢 -5.49 kB	🟢 -1.7 kB	🟢 -1.51 kB
assets/ValueControlPopover-BOnn1NWL.js (new)	—	5.49 kB	🔴 +5.49 kB	🔴 +1.7 kB	🔴 +1.51 kB
~~assets/WidgetGalleria-B3d2xvSs.js~~ (removed)	4.1 kB	—	🟢 -4.1 kB	🟢 -1.44 kB	🟢 -1.3 kB
assets/WidgetGalleria-DleD7UAJ.js (new)	—	4.1 kB	🔴 +4.1 kB	🔴 +1.44 kB	🔴 +1.31 kB
assets/WidgetColorPicker-5X2tZLrG.js (new)	—	3.41 kB	🔴 +3.41 kB	🔴 +1.38 kB	🔴 +1.23 kB
~~assets/WidgetColorPicker-BSkN2htz.js~~ (removed)	3.41 kB	—	🟢 -3.41 kB	🟢 -1.38 kB	🟢 -1.23 kB
~~assets/WidgetTextarea-D34UTk6k.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.21 kB	🟢 -1.08 kB
assets/WidgetTextarea-FH1bXkFH.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.21 kB	🔴 +1.08 kB
~~assets/WidgetMarkdown-But8K8fT.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.28 kB	🟢 -1.13 kB
assets/WidgetMarkdown-D_RxEyyB.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.28 kB	🔴 +1.13 kB
~~assets/WidgetAudioUI-Ixf8A738.js~~ (removed)	2.94 kB	—	🟢 -2.94 kB	🟢 -1.19 kB	🟢 -1.07 kB
assets/WidgetAudioUI-QUBtuEV_.js (new)	—	2.94 kB	🔴 +2.94 kB	🔴 +1.18 kB	🔴 +1.07 kB
assets/WidgetInputText-D4a_jLnz.js (new)	—	1.99 kB	🔴 +1.99 kB	🔴 +917 B	🔴 +843 B
~~assets/WidgetInputText-XacYbUI8.js~~ (removed)	1.99 kB	—	🟢 -1.99 kB	🟢 -918 B	🟢 -841 B
assets/WidgetToggleSwitch-BlwNLIrY.js (new)	—	1.76 kB	🔴 +1.76 kB	🔴 +832 B	🔴 +733 B
~~assets/WidgetToggleSwitch-BVl1ahWM.js~~ (removed)	1.76 kB	—	🟢 -1.76 kB	🟢 -831 B	🟢 -732 B
assets/MediaImageBottom-D8H5nKQu.js (new)	—	1.55 kB	🔴 +1.55 kB	🔴 +730 B	🔴 +640 B
~~assets/MediaImageBottom-Z0_Jc0Gk.js~~ (removed)	1.55 kB	—	🟢 -1.55 kB	🟢 -733 B	🟢 -640 B
assets/MediaAudioBottom-Bhb3F30L.js (new)	—	1.51 kB	🔴 +1.51 kB	🔴 +729 B	🔴 +646 B
~~assets/MediaAudioBottom-DR9mEint.js~~ (removed)	1.51 kB	—	🟢 -1.51 kB	🟢 -729 B	🟢 -645 B
assets/Media3DBottom-D0-6BZ5I.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +729 B	🔴 +647 B
~~assets/Media3DBottom-YzdibPkq.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -729 B	🟢 -648 B
assets/MediaVideoBottom-CJCKcpx4.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +727 B	🔴 +645 B
~~assets/MediaVideoBottom-CzflZ6WQ.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -731 B	🟢 -650 B
~~assets/Media3DTop-Bp4YAjNb.js~~ (removed)	1.49 kB	—	🟢 -1.49 kB	🟢 -761 B	🟢 -654 B
assets/Media3DTop-hhbCxi4Z.js (new)	—	1.49 kB	🔴 +1.49 kB	🔴 +763 B	🔴 +655 B
~~assets/WidgetSelect-Ck6sO-c_.js~~ (removed)	733 B	—	🟢 -733 B	🟢 -361 B	🟢 -308 B
assets/WidgetSelect-krhv8Zvm.js (new)	—	733 B	🔴 +733 B	🔴 +359 B	🔴 +327 B
~~assets/WidgetInputNumber-CAjzrQ7U.js~~ (removed)	673 B	—	🟢 -673 B	🟢 -348 B	🟢 -294 B
assets/WidgetInputNumber-DjWIq06Q.js (new)	—	673 B	🔴 +673 B	🔴 +347 B	🔴 +291 B
~~assets/Load3D-Cs_ofzTj.js~~ (removed)	424 B	—	🟢 -424 B	🟢 -269 B	🟢 -229 B
assets/Load3D-CywUq3Ep.js (new)	—	424 B	🔴 +424 B	🔴 +271 B	🔴 +230 B
~~assets/WidgetLegacy-C-XwSKU2.js~~ (removed)	364 B	—	🟢 -364 B	🟢 -237 B	🟢 -194 B
assets/WidgetLegacy-DEL2jBml.js (new)	—	364 B	🔴 +364 B	🔴 +235 B	🔴 +194 B
assets/commands-BWp4HdfU.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CcfGaui5.js	14.4 kB	14.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CisfgZf5.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CkU12Foh.js	13 kB	13 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CoH2DJa6.js	14.2 kB	14.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-COSt-Bjx.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DalfIW5f.js	15.9 kB	15.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DfTl0eCm.js	13.5 kB	13.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwSJL865.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-Zxyx15Vd.js	12.8 kB	12.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BDhxs-bB.js	79.9 kB	79.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BtXVDFw6.js	84.7 kB	84.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Buv6RhU4.js	82.4 kB	82.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CgJ6zvJL.js	97.2 kB	97.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CI9qb0E5.js	112 kB	112 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cu4LqtW0.js	81.6 kB	81.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cw9RZWRY.js	89 B	89 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dm19QY4N.js	92.2 kB	92.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Tihe0h_r.js	71.3 kB	71.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-wPWMutMw.js	70.4 kB	70.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-Dr0afgCA.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-BXa-oKEc.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-BVdg2b8C.js	2.65 kB	2.65 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-1Vh3MCrN.js	240 kB	240 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-aW9En70v.js	260 kB	260 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BIckSVgU.js	273 kB	273 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BiYpVi7D.js	263 kB	263 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CCEXtYfM.js	243 kB	243 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CvmVDWYd.js	323 kB	323 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-D_wreoPJ.js	267 kB	267 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Dz-0ZIBN.js	297 kB	297 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-VZsNmhG7.js	264 kB	264 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-DT6E_SOn.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-BB9nVmFq.js	2.21 kB	2.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 20 added / 20 removed

DrJKL · 2025-12-18T20:45:06Z

src/components/load3d/Load3DScene.vue

 })
 </script>
+
+<style scoped>


I'd like to avoid new <style> or <style scoped> tags.
Is there a way you can target these to the canvas directly?

Also, same question about any !importants. There's always ™️ a better way.

https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/extensions/core/load3d/Load3d.ts#L75
Looks like here maybe?

I appreciate the guidance and the good example. 👍 I’ll revise the code and align with the approach going forward.

DrJKL · 2025-12-19T20:07:56Z

src/extensions/core/load3d/Load3d.ts

+      'top-0',
+      'left-0',
+      'h-full',
+      'w-full',


Minor nit: You could replace these with inset-0
https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/inset

Good code review! Thanks!

DrJKL · 2025-12-19T20:08:18Z

src/extensions/core/load3d/Load3d.ts

+      'left-0',
+      'h-full',
+      'w-full',
+      'block',


Is it not a block level element to begin with?

Yes, it is. The code is updated.

## Summary Fix an issue #7620 where 3D nodes could be resized vertically only in the expanding direction but could not be shrunk. ## Changes - **What**: - Allow the 3D node content container to shrink by removing `h-full` and adding `min-h-0 flex-1`. - Prevent the internal canvas from reasserting its previous height during parent resize by avoiding `h-full` and constraining it with `max-h-full`. - **Dependencies**: - None ## Review Focus - Verify that vertical resize works in both directions for 3D nodes. - Ensure the canvas still resizes correctly with the node and that three.js rendering is unaffected. - Confirm no regression in pointer events, overlays, or resize handles. ## Screenshots before https://github.com/user-attachments/assets/6b9e3bb0-98eb-4b06-adb3-b3aab60a7f86 after https://github.com/user-attachments/assets/76d1a962-6cdc-4ca4-941e-7a3874629b29 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7621-fix-3d-resize-vertically-2cd6d73d365081efb281e8a40c87bf9e) by [Unito](https://www.unito.io)

fix: 3d resize vertically

f5cbd54

kaili-yang requested a review from jtydhr88 as a code owner December 18, 2025 20:30

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 18, 2025

jtydhr88 previously approved these changes Dec 18, 2025

View reviewed changes

coderabbitai bot reviewed Dec 18, 2025

View reviewed changes

src/components/load3d/Load3DScene.vue Outdated Show resolved Hide resolved

DrJKL reviewed Dec 18, 2025

View reviewed changes

kaili-yang added 2 commits December 18, 2025 17:56

fix 3d resize

54579a9

fix load3d resize bug

75e854e

kaili-yang dismissed jtydhr88’s stale review via 75e854e December 19, 2025 05:22

kaili-yang requested a review from a team as a code owner December 19, 2025 05:22

DrJKL reviewed Dec 19, 2025

View reviewed changes

DrJKL previously approved these changes Dec 19, 2025

View reviewed changes

style(css): use inset-0 instead of top/left

67f84fa

kaili-yang dismissed DrJKL’s stale review via 67f84fa December 19, 2025 20:26

Merge branch 'main' into fix-3d-resize

0c0b51b

jtydhr88 merged commit 08faa69 into Comfy-Org:main Dec 20, 2025
3 checks passed

coderabbitai bot mentioned this pull request Dec 31, 2025

fix 3d-min-resize #7815

Merged

christian-byrne mentioned this pull request Jan 5, 2026

Bump comfyui-frontend-package to 1.36.13 Comfy-Org/ComfyUI#11645

Merged

kaili-yang deleted the fix-3d-resize branch January 10, 2026 05:49

This was referenced Jan 28, 2026

fix: add ResizeObserver to fix Preview3D initial render stretch #8351

Merged

fix: remove redundant forceRender call and add ResizeObserver guard #8372

Merged

Conversation

kaili-yang commented Dec 18, 2025 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Review Focus

Screenshots

Uh oh!

coderabbitai bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

🚀 Running Tests

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🚀 Building Storybook

Uh oh!

jtydhr88 left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

DrJKL Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DrJKL Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaili-yang Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DrJKL Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

kaili-yang Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

DrJKL Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

kaili-yang Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kaili-yang commented Dec 18, 2025 •

edited by sync-by-unito bot

Loading

coderabbitai bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

DrJKL Dec 18, 2025 •

edited

Loading

DrJKL Dec 18, 2025 •

edited

Loading

kaili-yang Dec 19, 2025 •

edited

Loading