feat(manager): add Try Update button for nightly packs #7610
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,63 @@ | ||||||||||||||
| <template> | ||||||||||||||
| <IconTextButton | ||||||||||||||
| v-tooltip.top="$t('manager.tryUpdateTooltip')" | ||||||||||||||
| v-bind="$attrs" | ||||||||||||||
| type="transparent" | ||||||||||||||
| :label="computedLabel" | ||||||||||||||
| :border="true" | ||||||||||||||
| :size="size" | ||||||||||||||
| :disabled="isUpdating" | ||||||||||||||
| @click="tryUpdate" | ||||||||||||||
| > | ||||||||||||||
| <template v-if="isUpdating" #icon> | ||||||||||||||
| <DotSpinner duration="1s" :size="size === 'sm' ? 12 : 16" /> | ||||||||||||||
| </template> | ||||||||||||||
| </IconTextButton> | ||||||||||||||
| </template> | ||||||||||||||
|
|
||||||||||||||
| <script setup lang="ts"> | ||||||||||||||
| import { computed, ref } from 'vue' | ||||||||||||||
| import { useI18n } from 'vue-i18n' | ||||||||||||||
|
|
||||||||||||||
| import IconTextButton from '@/components/button/IconTextButton.vue' | ||||||||||||||
| import DotSpinner from '@/components/common/DotSpinner.vue' | ||||||||||||||
| import type { ButtonSize } from '@/types/buttonTypes' | ||||||||||||||
| import type { components } from '@/types/comfyRegistryTypes' | ||||||||||||||
| import { useComfyManagerStore } from '@/workbench/extensions/manager/stores/comfyManagerStore' | ||||||||||||||
|
|
||||||||||||||
| type NodePack = components['schemas']['Node'] | ||||||||||||||
|
|
||||||||||||||
| const { nodePack, size = 'sm' } = defineProps<{ | ||||||||||||||
| nodePack: NodePack | ||||||||||||||
| size?: ButtonSize | ||||||||||||||
| }>() | ||||||||||||||
|
|
||||||||||||||
| const { t } = useI18n() | ||||||||||||||
| const managerStore = useComfyManagerStore() | ||||||||||||||
|
|
||||||||||||||
| const isUpdating = ref(false) | ||||||||||||||
|
|
||||||||||||||
| async function tryUpdate() { | ||||||||||||||
| if (!nodePack.id) { | ||||||||||||||
| console.warn('Pack missing required id:', nodePack) | ||||||||||||||
| return | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| isUpdating.value = true | ||||||||||||||
| try { | ||||||||||||||
| await managerStore.updatePack.call({ | ||||||||||||||
| id: nodePack.id, | ||||||||||||||
| version: 'nightly' | ||||||||||||||
| }) | ||||||||||||||
| managerStore.updatePack.clear() | ||||||||||||||
| } catch (error) { | ||||||||||||||
| console.error('Nightly update failed:', error) | ||||||||||||||
| } finally { | ||||||||||||||
| isUpdating.value = false | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| const computedLabel = computed(() => | ||||||||||||||
| isUpdating.value ? t('g.updating') : t('manager.tryUpdate') | ||||||||||||||
| ) | ||||||||||||||
|
Comment on lines
+60
to
+62
Contributor
There was a problem hiding this comment. Localization key Looking at 🔎 Fix the interpolation: const computedLabel = computed(() =>
- isUpdating.value ? t('g.updating') : t('manager.tryUpdate')
+ isUpdating.value ? t('g.updating', { id: nodePack.name || nodePack.id }) : t('manager.tryUpdate')
)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| </script> | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,26 @@ | ||
| import { toValue } from '@vueuse/core' | ||
| import { compare, valid } from 'semver' | ||
| import type { MaybeRefOrGetter } from 'vue' | ||
| import { computed } from 'vue' | ||
|
|
||
| import type { components } from '@/types/comfyRegistryTypes' | ||
| import { useComfyManagerStore } from '@/workbench/extensions/manager/stores/comfyManagerStore' | ||
|
|
||
| export const usePackUpdateStatus = ( | ||
| nodePackSource: MaybeRefOrGetter<components['schemas']['Node']> | ||
| ) => { | ||
| const { isPackInstalled, isPackEnabled, getInstalledPackVersion } = | ||
| useComfyManagerStore() | ||
|
|
||
| // Use toValue to unwrap the source reactively inside computeds | ||
| const nodePack = computed(() => toValue(nodePackSource)) | ||
|
|
||
| const isInstalled = computed(() => isPackInstalled(nodePack.value?.id)) | ||
| const isEnabled = computed(() => isPackEnabled(nodePack.value?.id)) | ||
| const installedVersion = computed(() => | ||
| getInstalledPackVersion(nodePack.value?.id ?? '') | ||
| ) | ||
| const latestVersion = computed(() => nodePack.value?.latest_version?.version) | ||
|
|
||
| const isNightlyPack = computed( | ||
| () => !!installedVersion.value && !valid(installedVersion.value) | ||
|
|
@@ -31,9 +38,19 @@ export const usePackUpdateStatus = ( | |
| return compare(latestVersion.value, installedVersion.value) > 0 | ||
| }) | ||
|
|
||
| /** | ||
| * Nightly packs can always "try update" since we cannot compare git hashes | ||
| * to determine if an update is actually available. This allows users to | ||
| * pull the latest changes from the repository. | ||
| */ | ||
| const canTryNightlyUpdate = computed( | ||
| () => isInstalled.value && isEnabled.value && isNightlyPack.value | ||
| ) | ||
|
|
||
| return { | ||
| isUpdateAvailable, | ||
| isNightlyPack, | ||
| canTryNightlyUpdate, | ||
| installedVersion, | ||
| latestVersion | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { valid } from 'semver' | ||
| import { computed } from 'vue' | ||
| import type { Ref } from 'vue' | ||
|
|
||
|
|
@@ -41,12 +42,30 @@ export function usePacksSelection(nodePacks: Ref<NodePack[]>) { | |
| return 'mixed' | ||
| }) | ||
|
|
||
| /** | ||
| * Nightly packs are installed packs with a non-semver version (git hash) | ||
| * that are also enabled | ||
| */ | ||
| const nightlyPacks = computed(() => | ||
| installedPacks.value.filter((pack) => { | ||
| if (!pack.id) return false | ||
| const version = managerStore.getInstalledPackVersion(pack.id) | ||
| const isNightly = !!version && !valid(version) | ||
| const isEnabled = managerStore.isPackEnabled(pack.id) | ||
| return isNightly && isEnabled | ||
| }) | ||
| ) | ||
|
|
||
| const hasNightlyPacks = computed(() => nightlyPacks.value.length > 0) | ||
|
|
||
| return { | ||
| installedPacks, | ||
| notInstalledPacks, | ||
| isAllInstalled, | ||
| isNoneInstalled, | ||
| isMixed, | ||
| selectionState, | ||
| nightlyPacks, | ||
| hasNightlyPacks | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Error handling could provide user feedback.
The
tryUpdatefunction catches errors but only logs to console. Consider showing a toast notification to inform users when the update fails.🔎 Suggested improvement for user feedback:
🤖 Prompt for AI Agents