feat(manager): add Try Update button for nightly packs#7610
feat(manager): add Try Update button for nightly packs#7610christian-byrne merged 8 commits intomainfrom
Conversation
Add computed property to detect when a nightly pack can be updated. Nightly packs can always "try update" since we cannot compare git hashes to determine if an update is actually available.
New button component for triggering nightly pack updates. Shows "Try Update" with tooltip explaining the feature. Sends update request with version: 'nightly' to pull latest changes from the repository.
Show "Try Update" button in InfoPanel when viewing an installed, enabled nightly pack. Uses slot override on InfoPanelHeader.
Add tryUpdate and tryUpdateTooltip translation keys.
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds manual nightly update UI and logic: new PackTryUpdateButton component, batch/nightly update controls, refactors usePackUpdateStatus to accept reactive inputs and expose canTryNightlyUpdate, selection helpers for nightly packs, and two new English localization strings. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant UI as PackTryUpdateButton
participant Store as managerStore
participant Console as Logger
User->>UI: Click "Try Update"
activate UI
UI->>UI: Validate nodePack.id
alt id missing
UI->>Console: Log error
UI-->>User: No-op
else id present
UI->>UI: isUpdating = true (show spinner)
UI->>Store: updatePack(id, version: "nightly")
activate Store
alt success
Store-->>UI: success
UI->>Store: clear store
else failure
Store-->>UI: error
UI->>Console: Log error
end
deactivate Store
UI->>UI: isUpdating = false (hide spinner)
UI-->>User: Updated state
end
deactivate UI
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use MaybeRefOrGetter pattern to ensure the composable reacts when nodePack prop changes. Fixes reactivity issue where Try Update and Uninstall buttons wouldn't update correctly when switching between packs in InfoPanel.
Myestery
requested review from
a team,
KarryCharon,
Yorha4D,
christian-byrne,
ltdrdata,
shinshin86 and
viva-jinyi
as code owners
dosubot
bot
added
the
size:L
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
src/locales/en/main.json(1 hunks)src/workbench/extensions/manager/components/manager/PackVersionBadge.vue(1 hunks)src/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue(1 hunks)src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vue(3 hunks)src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (11)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use<script setup lang="ts">for component logic
Use Tailwind 4 utility classes for styling - avoid<style>blocks
Usecn()utility from@/utils/tailwindUtilto merge Tailwind class names - never use:class="[]"syntax
Never use thedark:Tailwind variant - use semantic values fromstyle.csstheme instead (e.g.,bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - preferuseModelto prop/emit pairs, do not usewithDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries insrc/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
src/**/*.{vue,ts}: Avoid usingrefandwatchtogether - usecomputedinstead if possible
Do not addrefif a prop would suffice; do not addcomputedif the ref/prop directly would work; usewatchonly whencomputedwon't accomplish the goal
Leverage VueUse functions for performance-enhancing styles
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/*.{js,ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript exclusively - no new JavaScript files
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/*.{ts,tsx,vue,js}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see.prettierrc
Sort and group imports by plugin, runpnpm formatbefore committing
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Extract complex type definitions that are inlined in multiple related places - name them for reuse
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones
Files:
src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Do not use function expressions - use function declarations instead when possible
Files:
src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts
🧠 Learnings (12)
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vue
📚 Learning: 2025-12-17T01:01:03.609Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Avoid new usage of PrimeVue components
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.tssrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vuesrc/workbench/extensions/manager/components/manager/PackVersionBadge.vuesrc/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
📚 Learning: 2025-12-09T04:35:43.971Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.
Applied to files:
src/locales/en/main.json
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts
🔇 Additional comments (7)
src/workbench/extensions/manager/composables/nodePack/usePackUpdateStatus.ts (2)
41-48: Well-documented computed property for nightly updates.The JSDoc comment clearly explains the rationale for
canTryNightlyUpdate- that git hashes cannot be compared for version checking, so manual updates are always allowed. The logic correctly requires the pack to be installed, enabled, and nightly.
18-19: No action needed. BothisPackEnabledandisPackInstalledare properly implemented to handle undefined input via explicit typing and defensive boolean coercion (!!packName), which safely returnsfalsewhen the ID is undefined.Likely an incorrect or invalid review comment.
src/workbench/extensions/manager/components/manager/PackVersionBadge.vue (1)
66-66: Correct reactivity pattern for composable input.Wrapping
nodePackin a getter() => nodePackensures the composable properly tracks prop changes. This aligns with the updatedusePackUpdateStatussignature that acceptsMaybeRefOrGetter<Node>.src/locales/en/main.json (1)
298-299: Localization entries added correctly.The new translation keys
tryUpdateandtryUpdateTooltipare properly placed under themanagernamespace with clear, user-friendly text. The tooltip effectively communicates why manual updates are needed for nightly versions.src/workbench/extensions/manager/components/manager/infoPanel/InfoPanel.vue (2)
112-113: Composable usage follows the updated pattern.Using
usePackUpdateStatus(() => nodePack)with a getter correctly maintains reactivity when thenodePackprop changes.
8-15: Conditional nightly update UI integrated correctly.The slot content properly renders both
PackTryUpdateButtonandPackUninstallButtonwhencanTryNightlyUpdateis true, providing nightly pack users with manual update and uninstall options. The#install-buttonslot is correctly defined inInfoPanelHeaderand the implementation follows all coding guidelines.src/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue (1)
1-16: Component follows repository conventions.Good use of
IconTextButtonfrom the common button components, proper tooltip positioning, and conditional spinner display. The component correctly usesv-bind="$attrs"for attribute passthrough.
| async function tryUpdate() { | ||
| if (!nodePack.id) { | ||
| console.warn('Pack missing required id:', nodePack) | ||
| return | ||
| } | ||
|
|
||
| isUpdating.value = true | ||
| try { | ||
| await managerStore.updatePack.call({ | ||
| id: nodePack.id, | ||
| version: 'nightly' | ||
| }) | ||
| managerStore.updatePack.clear() | ||
| } catch (error) { | ||
| console.error('Nightly update failed:', error) | ||
| } finally { | ||
| isUpdating.value = false | ||
| } | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Error handling could provide user feedback.
The tryUpdate function catches errors but only logs to console. Consider showing a toast notification to inform users when the update fails.
🔎 Suggested improvement for user feedback:
+import { useToast } from 'primevue/usetoast'
+
const { t } = useI18n()
const managerStore = useComfyManagerStore()
+const toast = useToast()
async function tryUpdate() {
if (!nodePack.id) {
console.warn('Pack missing required id:', nodePack)
return
}
isUpdating.value = true
try {
await managerStore.updatePack.call({
id: nodePack.id,
version: 'nightly'
})
managerStore.updatePack.clear()
} catch (error) {
console.error('Nightly update failed:', error)
+ toast.add({
+ severity: 'error',
+ summary: t('g.error'),
+ detail: String(error),
+ life: 5000
+ })
} finally {
isUpdating.value = false
}
}Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In
src/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
around lines 40 to 58, the tryUpdate function currently only logs errors to the
console when the nightly update fails; update the error handling to present user
feedback by invoking the app's toast/notification mechanism (e.g., existing
useToast/$toast or Notifications service) with a clear failure message and
optional error details, keep the isUpdating flag toggled as-is, and ensure
managerStore.updatePack.clear() still runs on success; include a success toast
on completion if desired.
| const computedLabel = computed(() => | ||
| isUpdating.value ? t('g.updating') : t('manager.tryUpdate') | ||
| ) |
There was a problem hiding this comment.
Localization key g.updating expects an {id} parameter.
Looking at main.json line 192, "updating": "Updating {id}" requires an id parameter. The current usage t('g.updating') will show "Updating {id}" literally instead of the pack name.
🔎 Fix the interpolation:
const computedLabel = computed(() =>
- isUpdating.value ? t('g.updating') : t('manager.tryUpdate')
+ isUpdating.value ? t('g.updating', { id: nodePack.name || nodePack.id }) : t('manager.tryUpdate')
)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const computedLabel = computed(() => | |
| isUpdating.value ? t('g.updating') : t('manager.tryUpdate') | |
| ) | |
| const computedLabel = computed(() => | |
| isUpdating.value ? t('g.updating', { id: nodePack.name || nodePack.id }) : t('manager.tryUpdate') | |
| ) |
🤖 Prompt for AI Agents
In
src/workbench/extensions/manager/components/manager/button/PackTryUpdateButton.vue
around lines 60 to 62, the localization key 'g.updating' requires an {id}
parameter but the code calls t('g.updating') with no params; update the
computedLabel to pass the pack identifier (e.g. pack.name or pack.id) when
isUpdating is true — e.g. call t('g.updating', { id: pack.name || pack.id || ''
}) — so the translation interpolates the pack name and provide a safe fallback
for the id value.
- Add nightlyPacks and hasNightlyPacks computed properties to usePacksSelection - Show "Update Selected" button in multi-selection panel when nightly packs selected - Batch update loops through all selected nightly packs sequentially
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue(4 hunks)src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (11)
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use<script setup lang="ts">for component logic
Use Tailwind 4 utility classes for styling - avoid<style>blocks
Usecn()utility from@/utils/tailwindUtilto merge Tailwind class names - never use:class="[]"syntax
Never use thedark:Tailwind variant - use semantic values fromstyle.csstheme instead (e.g.,bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - preferuseModelto prop/emit pairs, do not usewithDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries insrc/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
src/**/*.{vue,ts}: Avoid usingrefandwatchtogether - usecomputedinstead if possible
Do not addrefif a prop would suffice; do not addcomputedif the ref/prop directly would work; usewatchonly whencomputedwon't accomplish the goal
Leverage VueUse functions for performance-enhancing styles
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never useanytype - use proper TypeScript types
Never useas anytype assertions - fix the underlying type issue
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/*.{js,ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
Use TypeScript exclusively - no new JavaScript files
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/*.{ts,tsx,vue,js}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see.prettierrc
Sort and group imports by plugin, runpnpm formatbefore committing
Files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety
src/**/*.ts: Extract complex type definitions that are inlined in multiple related places - name them for reuse
Minimize the surface area (exported values) of each module and composable
Favor pure functions, especially testable ones
Files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
src/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Do not use function expressions - use function declarations instead when possible
Files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
🧠 Learnings (20)
📚 Learning: 2025-12-17T01:01:03.609Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use `<script setup lang="ts">` for component logic
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use ref/reactive for state management in Vue 3 Composition API
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use setup() function in Vue 3 Composition API
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-12-17T01:01:03.609Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use Suspense for async components
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-12-16T22:26:49.463Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vuesrc/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-12-18T02:07:38.870Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.
Applied to files:
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Implement computed() for derived state in Vue 3 Composition API
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-12-17T01:01:03.609Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Do not add `ref` if a prop would suffice; do not add `computed` if the ref/prop directly would work; use `watch` only when `computed` won't accomplish the goal
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-12-17T01:01:03.609Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Avoid using `ref` and `watch` together - use `computed` instead if possible
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement computed properties with computed()
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).
Applied to files:
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts
🔇 Additional comments (5)
src/workbench/extensions/manager/composables/nodePack/usePacksSelection.ts (3)
1-1: LGTM on the semver import.Using
validfrom semver is the correct approach to distinguish nightly (git hash) versions from semantic versions.
45-57: Well-structured nightly pack detection logic.The computed property correctly identifies nightly packs by:
- Filtering for valid pack IDs
- Checking the installed version is non-semver (nightly/git hash)
- Ensuring the pack is enabled
The JSDoc comment clearly explains the criteria. Good use of
computedper guidelines.
59-59: Clean derived state.
hasNightlyPacksis appropriately derived fromnightlyPacksusingcomputed, following the guideline to use computed for derived state rather than ref+watch.src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue (2)
21-41: Good UI composition for batch nightly updates.The template correctly:
- Conditionally shows the update button only when nightly packs exist
- Uses the common
IconTextButtoncomponent with proper tooltip- Shows a loading spinner during updates
- Disables the button while updating to prevent double-clicks
- Uses i18n for all user-facing strings
137-139: Good use of computed for dynamic label.The
updateSelectedLabelcomputed property appropriately derives the button label from the updating state, following the guideline to usecomputedfor derived state.
| async function updateSelectedNightlyPacks() { | ||
| if (nightlyPacks.value.length === 0) return | ||
|
|
||
| isUpdatingSelected.value = true | ||
| try { | ||
| for (const pack of nightlyPacks.value) { | ||
| if (!pack.id) continue | ||
| await managerStore.updatePack.call({ | ||
| id: pack.id, | ||
| version: 'nightly' | ||
| }) | ||
| } | ||
| managerStore.updatePack.clear() | ||
| } catch (error) { | ||
| console.error('Batch nightly update failed:', error) | ||
| } finally { | ||
| isUpdatingSelected.value = false | ||
| } | ||
| } |
There was a problem hiding this comment.
Move updatePack.clear() to the finally block for consistent cleanup.
If an error occurs during the batch update loop, clear() is never called, which could leave stale state in the manager store. Moving it to finally ensures cleanup happens regardless of success or failure.
🔎 Apply this diff to ensure consistent cleanup:
async function updateSelectedNightlyPacks() {
if (nightlyPacks.value.length === 0) return
isUpdatingSelected.value = true
try {
for (const pack of nightlyPacks.value) {
if (!pack.id) continue
await managerStore.updatePack.call({
id: pack.id,
version: 'nightly'
})
}
- managerStore.updatePack.clear()
} catch (error) {
console.error('Batch nightly update failed:', error)
} finally {
+ managerStore.updatePack.clear()
isUpdatingSelected.value = false
}
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| async function updateSelectedNightlyPacks() { | |
| if (nightlyPacks.value.length === 0) return | |
| isUpdatingSelected.value = true | |
| try { | |
| for (const pack of nightlyPacks.value) { | |
| if (!pack.id) continue | |
| await managerStore.updatePack.call({ | |
| id: pack.id, | |
| version: 'nightly' | |
| }) | |
| } | |
| managerStore.updatePack.clear() | |
| } catch (error) { | |
| console.error('Batch nightly update failed:', error) | |
| } finally { | |
| isUpdatingSelected.value = false | |
| } | |
| } | |
| async function updateSelectedNightlyPacks() { | |
| if (nightlyPacks.value.length === 0) return | |
| isUpdatingSelected.value = true | |
| try { | |
| for (const pack of nightlyPacks.value) { | |
| if (!pack.id) continue | |
| await managerStore.updatePack.call({ | |
| id: pack.id, | |
| version: 'nightly' | |
| }) | |
| } | |
| } catch (error) { | |
| console.error('Batch nightly update failed:', error) | |
| } finally { | |
| managerStore.updatePack.clear() | |
| isUpdatingSelected.value = false | |
| } | |
| } |
🤖 Prompt for AI Agents
In
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
around lines 117 to 135, the managerStore.updatePack.clear() call is inside the
try block so it won't run if an error occurs; move the clear() call into the
finally block (after isUpdatingSelected.value is reset) so it always runs
regardless of success or failure, and remove the original clear() from the try
block to avoid duplicate calls.
| } catch (error) { | ||
| console.error('Batch nightly update failed:', error) | ||
| } finally { |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider surfacing batch update errors to the user.
Currently, errors are only logged to the console. Users may not realize an update failed. Consider using a toast notification or similar feedback mechanism to inform users when a batch update fails.
🤖 Prompt for AI Agents
In
src/workbench/extensions/manager/components/manager/infoPanel/InfoPanelMultiItem.vue
around lines 130 to 132, the catch block only logs batch update failures to the
console so users aren't notified; update the catch to also surface the error to
the UI by invoking the app's notification mechanism (for example emit an event,
call the global/toast service like this.$toast.error(...) or dispatch a
notification action to the store) with a concise user-facing message and the
error details, while retaining the console.error for debugging.
🎭 Playwright Test Results🕵🏻 No test results found ⏰ Completed at: 12/18/2025, 09:54:59 PM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/18/2025, 09:41:59 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.21 MB (baseline 3.21 MB) • 🔴 +5.82 kBMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 996 kB (baseline 996 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks
Status: 10 added / 10 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 3 added / 3 removed Utilities & Hooks — 1.86 kB (baseline 1.86 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.46 MB (baseline 8.46 MB) • 🔴 +19 BExternal libraries and shared vendor chunks
Status: 5 added / 5 removed Other — 3.44 MB (baseline 3.44 MB) • ⚪ 0 BBundles that do not match a named category
Status: 25 added / 25 removed |
christian-byrne
added
needs-backport
## Summary - Add "Try Update" button in InfoPanel for installed nightly packs - Allows users to pull latest changes from repository for nightly versions - Nightly updates cannot be auto-detected (git hashes vs semver), so users trigger manually ## Test plan - [x] Install a nightly version of any pack - [x] Select the pack in Manager - [x] Verify "Try Update" button appears in InfoPanel - [x] Click "Try Update" and verify update request is sent https://github.com/user-attachments/assets/87443eb2-adc6-4d1c-afc9-171d301cca92 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7610-feat-manager-add-Try-Update-button-for-nightly-packs-2cd6d73d36508167adcbc07c6a07938c) by [Unito](https://www.unito.io)
github-actions
bot
removed
the
needs-backport
… packs (#7635) Backport of #7610 to `core/1.35` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7635-backport-core-1-35-feat-manager-add-Try-Update-button-for-nightly-packs-2ce6d73d36508135a070e17689cee5e7) by [Unito](https://www.unito.io) Co-authored-by: Johnpaul Chiwetelu <49923152+Myestery@users.noreply.github.com>
## Summary - Add "Try Update" button in InfoPanel for installed nightly packs - Allows users to pull latest changes from repository for nightly versions - Nightly updates cannot be auto-detected (git hashes vs semver), so users trigger manually ## Test plan - [x] Install a nightly version of any pack - [x] Select the pack in Manager - [x] Verify "Try Update" button appears in InfoPanel - [x] Click "Try Update" and verify update request is sent https://github.com/user-attachments/assets/87443eb2-adc6-4d1c-afc9-171d301cca92 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7610-feat-manager-add-Try-Update-button-for-nightly-packs-2cd6d73d36508167adcbc07c6a07938c) by [Unito](https://www.unito.io)
3 participants
Summary
Test plan
Screen.Recording.2025-12-18.at.06.44.51.mov
┆Issue is synchronized with this Notion page by Unito