feat(server-config): restart required toast #7479

benceruleanlu · 2025-12-15T02:12:59Z

Summary

Show a warning toast when leaving Server Config with pending changes, reminding users they must restart to apply changes.

Changes

What: Add a onBeforeUnmount toast in ServerConfigPanel when modifiedConfigs is non-empty and the user didn’t click Restart; add i18n strings.

Review Focus

Confirm the toast timing/conditions are correct (only fires on leaving the panel; suppressed when Restart is clicked).

Note

This is a stacked PR. (main <= #7478 <= #7479)

┆Issue is synchronized with this Notion page by Unito

coderabbitai · 2025-12-15T02:13:04Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/server-config-restart-required-toast

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-15T02:13:18Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/15/2025, 02:21:13 AM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

github-actions · 2025-12-15T02:13:23Z

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 12/15/2025, 02:31:07 AM UTC

📈 Summary

Total Tests: 504
Passed: 492 ✅
Failed: 1 ❌
Flaky: 2 ⚠️
Skipped: 9 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 480 / ❌ 1 / ⚠️ 2 / ⏭️ 9
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

benceruleanlu · 2025-12-15T02:15:37Z

This one is more optional. There is already a component telling users that they need to restart.

benceruleanlu · 2025-12-15T02:26:18Z

This PR is open because it's pretty small and simple, but I'm working on e2e desktop testing for this.

Copilot

Pull request overview

This PR adds a warning toast notification that reminds users to restart the application when they leave the Server Config panel with unsaved changes.

Key Changes:

Added onBeforeUnmount lifecycle hook to show a toast when leaving the panel with pending config changes
Implemented restartTriggered flag to suppress the toast when the user clicks the Restart button
Added i18n strings for the toast summary and detail messages

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`src/platform/settings/components/ServerConfigPanel.vue`	Adds toast notification logic with conditional display based on modified configs and restart state
`src/locales/en/main.json`	Adds toast message strings for restart requirement notification

Adds a Desktop (Electron) Server-Config setting for `--enable-manager-legacy-ui` so users can opt into ComfyUI-Manager’s legacy UI. - Adds `enable-manager-legacy-ui` to `SERVER_CONFIG_ITEMS` - Adds EN i18n label + tooltip Note: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7478-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081a79bb2c376506f5346) by [Unito](https://www.unito.io) > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479)

christian-byrne · 2025-12-15T02:42:12Z

src/platform/settings/components/ServerConfigPanel.vue

 }

 const restartApp = async () => {
+  restartTriggered = true


Does the toast say that a restart is required while the app is already restarting?

No, restartTriggered should be guarding that

Adds a Desktop (Electron) Server-Config setting for `--enable-manager-legacy-ui` so users can opt into ComfyUI-Manager’s legacy UI. - Adds `enable-manager-legacy-ui` to `SERVER_CONFIG_ITEMS` - Adds EN i18n label + tooltip Note: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7478-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081a79bb2c376506f5346) by [Unito](https://www.unito.io) > [!NOTE] > This is a stacked PR. (main <= Comfy-Org#7478 <= Comfy-Org#7479)

## Summary Show a warning toast when leaving Server Config with pending changes, reminding users they must restart to apply changes. ## Changes - **What**: Add a `onBeforeUnmount` toast in `ServerConfigPanel` when `modifiedConfigs` is non-empty and the user didn’t click Restart; add i18n strings. ## Review Focus - Confirm the toast timing/conditions are correct (only fires on leaving the panel; suppressed when Restart is clicked). > [!NOTE] > This is a stacked PR. (main <= Comfy-Org#7478 <= Comfy-Org#7479) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7479-feat-server-config-restart-required-toast-2ca6d73d3650811f85f7f0c52c4cf8f0) by [Unito](https://www.unito.io)

Adds a Desktop (Electron) Server-Config setting for `--enable-manager-legacy-ui` so users can opt into ComfyUI-Manager’s legacy UI. - Adds `enable-manager-legacy-ui` to `SERVER_CONFIG_ITEMS` - Adds EN i18n label + tooltip Note: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7478-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081a79bb2c376506f5346) by [Unito](https://www.unito.io) > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479)

## Summary Show a warning toast when leaving Server Config with pending changes, reminding users they must restart to apply changes. ## Changes - **What**: Add a `onBeforeUnmount` toast in `ServerConfigPanel` when `modifiedConfigs` is non-empty and the user didn’t click Restart; add i18n strings. ## Review Focus - Confirm the toast timing/conditions are correct (only fires on leaving the panel; suppressed when Restart is clicked). > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7479-feat-server-config-restart-required-toast-2ca6d73d3650811f85f7f0c52c4cf8f0) by [Unito](https://www.unito.io)

feat(server-config): add legacy manager UI toggle

81e530d

benceruleanlu mentioned this pull request Dec 15, 2025

feat(server-config): add legacy manager UI toggle #7478

Merged

benceruleanlu added 2 commits December 14, 2025 18:18

chore(server-config): remove redundant restart tooltip

6e28a54

feat(server-config): toast restart required

7b133c2

benceruleanlu force-pushed the feat/server-config-restart-required-toast branch from 907a3a2 to 7b133c2 Compare December 15, 2025 02:19

benceruleanlu marked this pull request as ready for review December 15, 2025 02:26

benceruleanlu requested a review from Yorha4D as a code owner December 15, 2025 02:26

Copilot AI review requested due to automatic review settings December 15, 2025 02:26

benceruleanlu requested review from a team, KarryCharon and shinshin86 as code owners December 15, 2025 02:26

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 15, 2025

Copilot started reviewing on behalf of benceruleanlu December 15, 2025 02:26 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

Base automatically changed from feat/server-config-legacy-manager-ui to main December 15, 2025 02:40

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 15, 2025

christian-byrne reviewed Dec 15, 2025

View reviewed changes

christian-byrne approved these changes Dec 16, 2025

View reviewed changes

christian-byrne merged commit 93195d3 into main Dec 16, 2025
40 of 41 checks passed

christian-byrne deleted the feat/server-config-restart-required-toast branch December 16, 2025 13:57

christian-byrne mentioned this pull request Jan 5, 2026

Bump comfyui-frontend-package to 1.36.13 Comfy-Org/ComfyUI#11645

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(server-config): restart required toast #7479

feat(server-config): restart required toast #7479

Uh oh!

benceruleanlu commented Dec 15, 2025 •

edited by sync-by-unito bot

Loading

Uh oh!

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

Review skipped

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

benceruleanlu commented Dec 15, 2025

Uh oh!

benceruleanlu commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

christian-byrne Dec 15, 2025

Uh oh!

benceruleanlu Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(server-config): restart required toast #7479

feat(server-config): restart required toast #7479

Uh oh!

Conversation

benceruleanlu commented Dec 15, 2025 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Review Focus

Uh oh!

coderabbitai bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

benceruleanlu commented Dec 15, 2025

Uh oh!

benceruleanlu commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

christian-byrne Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

benceruleanlu Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benceruleanlu commented Dec 15, 2025 •

edited by sync-by-unito bot

Loading

coderabbitai bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading