feat(server-config): add legacy manager UI toggle #7478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📝 WalkthroughWalkthroughA new server configuration flag Changes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (6)**/*.{ts,tsx,js,jsx,vue,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
src/**/*.{vue,ts}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.ts📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
src/**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
src/**/*.{vue,ts,tsx}📄 CodeRabbit inference engine (src/CLAUDE.md)
Files:
**/*.{ts,tsx,vue}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧠 Learnings (4)📚 Learning: 2025-12-09T04:35:43.971ZApplied to files:
📚 Learning: 2025-12-09T03:39:54.501ZApplied to files:
📚 Learning: 2025-12-13T11:03:11.264ZApplied to files:
📚 Learning: 2025-12-11T12:25:15.470ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/15/2025, 02:20:51 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 12/15/2025, 02:29:42 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.25 MB (baseline 3.25 MB) • 🔴 +145 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 986 kB (baseline 986 kB) • 🔴 +199 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.82 MB (baseline 3.82 MB) • ⚪ 0 BBundles that do not match a named category
Status: 19 added / 19 removed |
Member
Author
|
Failing test is most likely unrelated (french workflow) |
benceruleanlu
added
needs-backport
Member
Author
|
This PR is open because it's pretty small and simple, but I'm working on e2e desktop testing for this. |
dosubot
bot
added
the
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new server configuration setting to enable the legacy ComfyUI-Manager UI. The implementation adds the necessary configuration wiring without modifying restart behavior in Desktop.
Key changes:
- Added
enable-manager-legacy-uiboolean configuration option to server config items - Added English i18n translations (label and tooltip) for the new setting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/constants/serverConfig.ts |
Adds the enable-manager-legacy-ui server config item with name, tooltip, type, and default value |
src/locales/en/main.json |
Adds i18n translations for the setting's name and tooltip in the serverConfigItems section |
The implementation follows the established pattern in the codebase where server config items have hardcoded fallback strings in serverConfig.ts and corresponding i18n translations in main.json. The strings are consistent between both files, and the structure aligns with other similar boolean configuration options. No issues were identified in this review.
christian-byrne
approved these changes
Dec 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Adds a Desktop (Electron) Server-Config setting for `--enable-manager-legacy-ui` so users can opt into ComfyUI-Manager’s legacy UI. - Adds `enable-manager-legacy-ui` to `SERVER_CONFIG_ITEMS` - Adds EN i18n label + tooltip Note: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7478-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081a79bb2c376506f5346) by [Unito](https://www.unito.io) > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
Adds a Desktop (Electron) Server-Config setting for `--enable-manager-legacy-ui` so users can opt into ComfyUI-Manager’s legacy UI. - Adds `enable-manager-legacy-ui` to `SERVER_CONFIG_ITEMS` - Adds EN i18n label + tooltip Note: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7478-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081a79bb2c376506f5346) by [Unito](https://www.unito.io) > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479)
Member
|
@benceruleanlu Successfully backported to #7481 |
Member
|
@benceruleanlu Successfully backported to #7482 |
github-actions
bot
removed
the
needs-backport
christian-byrne
pushed a commit
that referenced
this pull request
Dec 15, 2025
#7481) Backport of #7478 to `core/1.34` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7481-backport-core-1-34-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081718d41e9cbd9f28bf9) by [Unito](https://www.unito.io) Co-authored-by: Benjamin Lu <[email protected]>
christian-byrne
pushed a commit
that referenced
this pull request
Dec 15, 2025
#7482) Backport of #7478 to `core/1.35` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7482-backport-core-1-35-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081c8b614dee970faf9ee) by [Unito](https://www.unito.io) Co-authored-by: Benjamin Lu <[email protected]>
christian-byrne
pushed a commit
that referenced
this pull request
Dec 16, 2025
## Summary Show a warning toast when leaving Server Config with pending changes, reminding users they must restart to apply changes. ## Changes - **What**: Add a `onBeforeUnmount` toast in `ServerConfigPanel` when `modifiedConfigs` is non-empty and the user didn’t click Restart; add i18n strings. ## Review Focus - Confirm the toast timing/conditions are correct (only fires on leaving the panel; suppressed when Restart is clicked). > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7479-feat-server-config-restart-required-toast-2ca6d73d3650811f85f7f0c52c4cf8f0) by [Unito](https://www.unito.io)
Enferlain
pushed a commit
to Enferlain/ComfyUI_frontend
that referenced
this pull request
Dec 18, 2025
Adds a Desktop (Electron) Server-Config setting for `--enable-manager-legacy-ui` so users can opt into ComfyUI-Manager’s legacy UI. - Adds `enable-manager-legacy-ui` to `SERVER_CONFIG_ITEMS` - Adds EN i18n label + tooltip Note: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7478-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081a79bb2c376506f5346) by [Unito](https://www.unito.io) > [!NOTE] > This is a stacked PR. (main <= Comfy-Org#7478 <= Comfy-Org#7479)
Enferlain
pushed a commit
to Enferlain/ComfyUI_frontend
that referenced
this pull request
Dec 18, 2025
## Summary Show a warning toast when leaving Server Config with pending changes, reminding users they must restart to apply changes. ## Changes - **What**: Add a `onBeforeUnmount` toast in `ServerConfigPanel` when `modifiedConfigs` is non-empty and the user didn’t click Restart; add i18n strings. ## Review Focus - Confirm the toast timing/conditions are correct (only fires on leaving the panel; suppressed when Restart is clicked). > [!NOTE] > This is a stacked PR. (main <= Comfy-Org#7478 <= Comfy-Org#7479) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7479-feat-server-config-restart-required-toast-2ca6d73d3650811f85f7f0c52c4cf8f0) by [Unito](https://www.unito.io)
Yourz
pushed a commit
that referenced
this pull request
Dec 24, 2025
Adds a Desktop (Electron) Server-Config setting for `--enable-manager-legacy-ui` so users can opt into ComfyUI-Manager’s legacy UI. - Adds `enable-manager-legacy-ui` to `SERVER_CONFIG_ITEMS` - Adds EN i18n label + tooltip Note: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7478-feat-server-config-add-legacy-manager-UI-toggle-2ca6d73d365081a79bb2c376506f5346) by [Unito](https://www.unito.io) > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479)
Yourz
pushed a commit
that referenced
this pull request
Dec 24, 2025
## Summary Show a warning toast when leaving Server Config with pending changes, reminding users they must restart to apply changes. ## Changes - **What**: Add a `onBeforeUnmount` toast in `ServerConfigPanel` when `modifiedConfigs` is non-empty and the user didn’t click Restart; add i18n strings. ## Review Focus - Confirm the toast timing/conditions are correct (only fires on leaving the panel; suppressed when Restart is clicked). > [!NOTE] > This is a stacked PR. (main <= #7478 <= #7479) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7479-feat-server-config-restart-required-toast-2ca6d73d3650811f85f7f0c52c4cf8f0) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Desktop (Electron) Server-Config setting for
--enable-manager-legacy-uiso users can opt into ComfyUI-Manager’s legacy UI.enable-manager-legacy-uitoSERVER_CONFIG_ITEMSNote: this PR only adds the setting/flag wiring; it does not change restart behavior in Desktop.
┆Issue is synchronized with this Notion page by Unito
Note
This is a stacked PR. (main <= #7478 <= #7479)