Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Nov 4, 2025

Backports the combined changes from the following PRs into rh-test:

Key points

  • Settings telemetry added via SettingItem.vue after successful setting updates and wired to TelemetryEvents.SETTING_CHANGED.
  • UI telemetry wired for run/queue actions and breadcrumbs to match upstream behavior.

Divergences from the source PRs

  • Removed input_type, category, and sub_category from SettingChangedMetadata to keep the event shape focused and consistent with downstream consumers.
  • Replaced lazy telemetry import in dialogService error dialog onClose handlers with a top‑level useTelemetry() import for clarity and to avoid unnecessary dynamic imports.
  • Kept a few additional telemetry events already present in this branch (error dialog actions, graph/sidebar/template interactions). Happy to trim these for a strict backport if desired.

Validation

  • Ran pnpm lint:fix && pnpm typecheck successfully locally.

References

┆Issue is synchronized with this Notion page by Unito

…factor dialogService telemetry import\n\n- Backport of #6504 and https://github.com/Comfy-Org/ComfyUI_frontend/pull/6511\n- Remove input_type, category, sub_category from SettingChangedMetadata\n- Replace lazy import in dialogService error dialog onClose with top-level useTelemetry()\n- Lint and typecheck pass (pnpm lint:fix && pnpm typecheck)
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 11/04/2025, 03:54:48 AM UTC

📈 Summary

  • Total Tests: 211
  • Passed: -108 ✅
  • Failed: 14 ❌
  • Flaky: 1 ⚠️
  • Skipped: 304 ⏭️

📊 Test Reports by Browser


🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit a83b376 into rh-test Nov 4, 2025
15 of 21 checks passed
@christian-byrne christian-byrne deleted the backport-6511-6504-to-rh-test branch November 4, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants