feat(telemetry): add tracking for sidebar, run menu, dialogs, subgraphs, settings and credits #6511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceruleanlu
requested review from
Myestery and
pythongosssss
as code owners
dosubot
bot
added
the
size:L
🎭 Playwright Test Results⏰ Completed at: 11/01/2025, 10:27:34 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/01/2025, 10:14:01 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.27 MB (baseline 3.27 MB) • 🔴 +218 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 724 kB (baseline 723 kB) • 🔴 +715 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 8.18 kB (baseline 8.18 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 295 kB (baseline 295 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 12.3 kB (baseline 12.3 kB) • 🔴 +46 BReusable component library chunks
Status: 1 added / 1 removed Data & Services — 11.4 kB (baseline 11.4 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
Contributor
|
I can help with conflicts |
Merged latest changes from main into round-pigeon branch, resolving conflicts in telemetry tracking code: - ErrorDialogContent.vue: Keep specialized trackHelpResourceClicked for help/support actions instead of generic trackUiButtonClicked - CreditsPanel.vue: Add missing useSubscription import from main - MixpanelTelemetryProvider.ts: Include both UiButtonClickMetadata and WorkflowCreatedMetadata imports - types.ts: Merge all interface definitions and union types from both branches (UiButtonClickMetadata + help center + workflow metadata) Approach: Maintain separate tracking systems - use generic UI button tracking for simple interactions and specialized help/workflow tracking for domain-specific events with rich metadata. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
benceruleanlu
commented
Nov 1, 2025
Member
Author
benceruleanlu
left a comment
benceruleanlu
left a comment
There was a problem hiding this comment.
I want to rename the telemetry events to clarify that they are buttons, I think assets and others are kind of broad
christian-byrne
added
needs-backport
christian-byrne
approved these changes
Nov 2, 2025
|
@benceruleanlu Backport to Please manually cherry-pick commit Conflicting files
|
christian-byrne
added a commit
that referenced
this pull request
Nov 2, 2025
Restores the queue_run_multiple_batches_submitted tracking that was accidentally removed during conflict resolution. This tracking was added in PR #6511 to track when users submit multiple batches. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
benceruleanlu
added a commit
that referenced
this pull request
Nov 4, 2025
…factor dialogService telemetry import\n\n- Backport of #6504 and https://github.com/Comfy-Org/ComfyUI_frontend/pull/6511\n- Remove input_type, category, sub_category from SettingChangedMetadata\n- Replace lazy import in dialogService error dialog onClose with top-level useTelemetry()\n- Lint and typecheck pass (pnpm lint:fix && pnpm typecheck)
christian-byrne
pushed a commit
that referenced
this pull request
Nov 4, 2025
…import refactor (#6567) Backports the combined changes from the following PRs into `rh-test`: - #6504 — Settings telemetry (track `SETTING_CHANGED` on successful update) - #6511 — UI telemetry (actionbar drag handle, run button choices/multi‑batch submit, breadcrumb item/root selection) Key points - Settings telemetry added via `SettingItem.vue` after successful setting updates and wired to `TelemetryEvents.SETTING_CHANGED`. - UI telemetry wired for run/queue actions and breadcrumbs to match upstream behavior. Divergences from the source PRs - Removed `input_type`, `category`, and `sub_category` from `SettingChangedMetadata` to keep the event shape focused and consistent with downstream consumers. - Replaced lazy telemetry import in `dialogService` error dialog `onClose` handlers with a top‑level `useTelemetry()` import for clarity and to avoid unnecessary dynamic imports. - Kept a few additional telemetry events already present in this branch (error dialog actions, graph/sidebar/template interactions). Happy to trim these for a strict backport if desired. Validation - Ran `pnpm lint:fix && pnpm typecheck` successfully locally. References - Upstream PRs: #6504, #6511 - Branch: `backport-6511-6504-to-rh-test` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6567-Backport-telemetry-settings-UI-tracking-6504-6511-and-dialog-import-refactor-2a16d73d365081ce80a0f973c4483653) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sidebar and top-level
node_librarymodel_libraryworkflowsassetstemplateskeyboard_shortcutsconsolehelp_centersettings_menuFloating canvas menu
minimap_togglehide_linksRun button and queue
run_button_handlerun_instant,run_on_changequeue_multiplefires on each run when batch count > 1 (moved from batch-count-change to run-time, per guidance)Error dialogs
error_dialog_closevia dialog onCloseerror_show_reporterror_help_fix_thiserror_find_issuesNodes / Subgraphs
node_infoopen_subgraphsubgraph_breadcrumb_itemandsubgraph_breadcrumb_rootSettings / Credits / Search
settings_menutrackAddApiCreditButtonClickedtrackAddApiCreditButtonClickedNotes and answers
useTelemetry()?.…). OSS builds send nothing.Open questions / follow-ups
trackRunButtonexists; we can also emit a UI-levelrunclick (UI_BUTTON_CLICKEDstyle) alongside it if desired. Confirm preference and I can add it.Quality
pnpm lint:fixandpnpm typecheck; both pass locally.Implementation details
voidfor intentionally unawaited async calls per lint rules.button_idstrings; happy to align to a different naming scheme if you prefer.┆Issue is synchronized with this Notion page by Unito