Skip to content

Conversation

AustinMroz
Copy link
Collaborator

@AustinMroz AustinMroz commented Oct 10, 2025

vue-dom-widget

Did testing on about a dozen custom nodes. Most just work.

  • Some custom nodes have copy/pasted the addDOMWidget call with types like customtext and get converted to textareas -> Not feasible to fix here. Can open PRs into custom nodes if complaints arise.
  • Only the KJNodes spline editor had mouse issues -> Can investigate/open PR into KJNodes later.
  • Many nodes don't resize gracefully. Probably best handled in a future PR.
    • Some expect to be handled like textareas. These currently have minsize and don't scale.
    • Others, like VHS previews, scale self properly, but don't update height inside a drag operation -> node height can be set to less than fit.

┆Issue is synchronized with this Notion page by Unito

Copy link

github-actions bot commented Oct 10, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 10/10/2025, 05:32:46 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

Copy link

github-actions bot commented Oct 10, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/10/2025, 05:48:17 PM UTC

📈 Summary

  • Total Tests: 493
  • Passed: 460 ✅
  • Failed: 0
  • Flaky: 3 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 451 / ❌ 0 / ⚠️ 3 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@AustinMroz AustinMroz force-pushed the austin/vue-dom-widget branch from 9fd0287 to ac22588 Compare October 10, 2025 17:31
@AustinMroz AustinMroz marked this pull request as ready for review October 10, 2025 17:51
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 10, 2025
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great start, clean implementation.

@christian-byrne christian-byrne merged commit 2599136 into main Oct 10, 2025
30 checks passed
@christian-byrne christian-byrne deleted the austin/vue-dom-widget branch October 10, 2025 21:11
@arjansingh arjansingh mentioned this pull request Oct 11, 2025
arjansingh added a commit that referenced this pull request Oct 11, 2025
## What's Changed

### 🚀 Features
- Implement DOMWidget for vue (#6006)
- Implement drop-on-canvas + linkconnectoradapter consolidation (#5898)
- Vuenodes/audio widgets (#5627)
- Allow reordering of linked subgraph widgets (#5981)
- Contextmenu Monkeypatch Standardization (#5977)
- Fix/vue nodes snap to grid (#5973)
- Select Vue Nodes After Drag (#5863)
- fix Vue node widgets should be in disabled state if their slots are
connected with a link (#5834)

### 🐛 Bug Fixes
- [bugfix] Fix update-playwright-expectations workflow missing frontend
build (#6005)
- Fix: Reset size when collapsing (#6004)
- fix: misc LOD polish (#6001)
- Fix: Allow uncoloring Vue Nodes (#5991)
- [ci] Fix detached HEAD state in Playwright update workflow (#5985)
- Close zoom menu when toggling minimap visibility (#5974)

### 🔧 Maintenance
- Devex: Improve dev server (#6002)
- CI: Add concurrency checks to PR workflows (#6000)
- [feat] Auto-remove New Browser Test Expectations label after workflow
completes (#5998)
- CI: Simplify update playwright expectations (maybe) (#5994)
- Lint: Add tailwind linter (#5984)
- [feat] Auto-remove claude-review label after CI review completes
(#5983)
- Fix CI: Remove explicit repository parameter causing non-reproducible
test results (#5950)
- refactor: Reorganize GitHub Actions for better reusability (#5949)
- devex: Update CODEOWNERS (#5999)
- Docs: Update agent instructions about style classes (#5990)
- Style: Fix move cursors that should be grabs (#5989)
- Workflow templates review (#5975)

**Full Changelog**:
v1.29.0...v1.29.1

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6012-1-29-1-2896d73d365081b08418f46934651c41)
by [Unito](https://www.unito.io)

Co-authored-by: arjansingh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:vue-migration size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants