[bugfix] Fix update-playwright-expectations workflow missing frontend build #6005
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results⏰ Completed at: 10/09/2025, 10:59:50 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/09/2025, 10:43:45 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
christian-byrne
commented
Oct 9, 2025
… build The workflow was trying to launch the ComfyUI server with `--front-end-root ../dist` before building the frontend, causing: error: argument --front-end-root: The path '../dist' does not exist. Solution: Build frontend before setting up server, so dist/ exists when the server launches. Fixes errors seen on PR #5863 and any PR using /update-playwright comment.
christian-byrne
force-pushed
the
fix-update-playwright-expectations-missing-frontend-build
branch
from
fc57a0e to
034c3f9
Compare
DrJKL
approved these changes
Oct 9, 2025
DrJKL
deleted the
fix-update-playwright-expectations-missing-frontend-build
branch
Merged
arjansingh
added a commit
that referenced
this pull request
Oct 11, 2025
## What's Changed ### 🚀 Features - Implement DOMWidget for vue (#6006) - Implement drop-on-canvas + linkconnectoradapter consolidation (#5898) - Vuenodes/audio widgets (#5627) - Allow reordering of linked subgraph widgets (#5981) - Contextmenu Monkeypatch Standardization (#5977) - Fix/vue nodes snap to grid (#5973) - Select Vue Nodes After Drag (#5863) - fix Vue node widgets should be in disabled state if their slots are connected with a link (#5834) ### 🐛 Bug Fixes - [bugfix] Fix update-playwright-expectations workflow missing frontend build (#6005) - Fix: Reset size when collapsing (#6004) - fix: misc LOD polish (#6001) - Fix: Allow uncoloring Vue Nodes (#5991) - [ci] Fix detached HEAD state in Playwright update workflow (#5985) - Close zoom menu when toggling minimap visibility (#5974) ### 🔧 Maintenance - Devex: Improve dev server (#6002) - CI: Add concurrency checks to PR workflows (#6000) - [feat] Auto-remove New Browser Test Expectations label after workflow completes (#5998) - CI: Simplify update playwright expectations (maybe) (#5994) - Lint: Add tailwind linter (#5984) - [feat] Auto-remove claude-review label after CI review completes (#5983) - Fix CI: Remove explicit repository parameter causing non-reproducible test results (#5950) - refactor: Reorganize GitHub Actions for better reusability (#5949) - devex: Update CODEOWNERS (#5999) - Docs: Update agent instructions about style classes (#5990) - Style: Fix move cursors that should be grabs (#5989) - Workflow templates review (#5975) **Full Changelog**: v1.29.0...v1.29.1 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6012-1-29-1-2896d73d365081b08418f46934651c41) by [Unito](https://www.unito.io) Co-authored-by: arjansingh <[email protected]>
christian-byrne
added a commit
that referenced
this pull request
Oct 11, 2025
Similar to #6005, fixing the update-locales workflow by setting up the frontend before launching ComfyUI server. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6017-ci-fix-update-locales-workflow-2896d73d36508173aaf9e0eefe4f7660) by [Unito](https://www.unito.io)
arjansingh
pushed a commit
that referenced
this pull request
Oct 12, 2025
… build (#6005) ## Problem The `update-playwright-expectations.yaml` workflow was failing with: ``` error: argument --front-end-root: The path '../dist' does not exist. ``` This was happening because the workflow was trying to launch the ComfyUI server with `--front-end-root ../dist` before building the frontend. ## Root Cause The workflow was missing the frontend build step entirely. It went directly from checkout → setup server with `launch_server: true` → run tests, skipping the crucial frontend build. ## Solution 1. Remove `launch_server: true` from `setup-comfyui-server` action call 2. Add `setup-frontend` action with `include_build_step: true` to build the frontend 3. Add separate "Launch ComfyUI Server" step that runs AFTER frontend is built This ensures the `dist/` directory exists before the server tries to use it. ## Testing This fixes errors seen on PR #5863 and any PR using the `/update-playwright` comment trigger. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6005-bugfix-Fix-update-playwright-expectations-workflow-missing-frontend-build-2876d73d36508182bb1af1123f3b2a87) by [Unito](https://www.unito.io)
arjansingh
added a commit
that referenced
this pull request
Oct 12, 2025
## What's Changed ### 🚀 Features - Implement DOMWidget for vue (#6006) - Implement drop-on-canvas + linkconnectoradapter consolidation (#5898) - Vuenodes/audio widgets (#5627) - Allow reordering of linked subgraph widgets (#5981) - Contextmenu Monkeypatch Standardization (#5977) - Fix/vue nodes snap to grid (#5973) - Select Vue Nodes After Drag (#5863) - fix Vue node widgets should be in disabled state if their slots are connected with a link (#5834) ### 🐛 Bug Fixes - [bugfix] Fix update-playwright-expectations workflow missing frontend build (#6005) - Fix: Reset size when collapsing (#6004) - fix: misc LOD polish (#6001) - Fix: Allow uncoloring Vue Nodes (#5991) - [ci] Fix detached HEAD state in Playwright update workflow (#5985) - Close zoom menu when toggling minimap visibility (#5974) ### 🔧 Maintenance - Devex: Improve dev server (#6002) - CI: Add concurrency checks to PR workflows (#6000) - [feat] Auto-remove New Browser Test Expectations label after workflow completes (#5998) - CI: Simplify update playwright expectations (maybe) (#5994) - Lint: Add tailwind linter (#5984) - [feat] Auto-remove claude-review label after CI review completes (#5983) - Fix CI: Remove explicit repository parameter causing non-reproducible test results (#5950) - refactor: Reorganize GitHub Actions for better reusability (#5949) - devex: Update CODEOWNERS (#5999) - Docs: Update agent instructions about style classes (#5990) - Style: Fix move cursors that should be grabs (#5989) - Workflow templates review (#5975) **Full Changelog**: v1.29.0...v1.29.1 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6012-1-29-1-2896d73d365081b08418f46934651c41) by [Unito](https://www.unito.io) Co-authored-by: arjansingh <[email protected]>
arjansingh
pushed a commit
that referenced
this pull request
Oct 12, 2025
Similar to #6005, fixing the update-locales workflow by setting up the frontend before launching ComfyUI server. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6017-ci-fix-update-locales-workflow-2896d73d36508173aaf9e0eefe4f7660) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
update-playwright-expectations.yamlworkflow was failing with:This was happening because the workflow was trying to launch the ComfyUI server with
--front-end-root ../distbefore building the frontend.Root Cause
The workflow was missing the frontend build step entirely. It went directly from checkout → setup server with
launch_server: true→ run tests, skipping the crucial frontend build.Solution
launch_server: truefromsetup-comfyui-serveraction callsetup-frontendaction withinclude_build_step: trueto build the frontendThis ensures the
dist/directory exists before the server tries to use it.Testing
This fixes errors seen on PR #5863 and any PR using the
/update-playwrightcomment trigger.┆Issue is synchronized with this Notion page by Unito