Merged
Conversation
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/07/2025, 10:24:19 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 10/07/2025, 10:54:24 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
approved these changes
Oct 7, 2025
christian-byrne
added
the
claude-review
Comprehensive PR ReviewThis review is generated by Claude. No issues were found in this PR. Review SummaryPR: Fix: Missing Node Title Editor bug (#5963) Issue Distribution
Category Breakdown
Key FindingsThe change from newValue.trim() !== '' to newValue?.trim() is an excellent defensive programming improvement that prevents potential runtime errors when newValue is null/undefined. Positive Observations
Next StepsReady for merge - this is a high-quality bug fix with no issues identified. |
christian-byrne
pushed a commit
that referenced
this pull request
Oct 8, 2025
Found by @marawan206 ## Summary Fixes the title editor glitching when the node doesn't have an initial value ## Screenshots (if applicable) ### Before https://github.com/user-attachments/assets/4c4efbfd-73b9-4733-8227-fe2de59648d4 ### After https://github.com/user-attachments/assets/30f3279e-aa2b-451b-9bee-c134d3f8374c ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5963-Fix-Missing-Node-Title-Editor-bug-2856d73d365081389edbda546eca3bbb) by [Unito](https://www.unito.io)
AustinMroz
added
needs-backport
AustinMroz
pushed a commit
that referenced
this pull request
Oct 8, 2025
Found by @marawan206 ## Summary Fixes the title editor glitching when the node doesn't have an initial value ## Screenshots (if applicable) ### Before https://github.com/user-attachments/assets/4c4efbfd-73b9-4733-8227-fe2de59648d4 ### After https://github.com/user-attachments/assets/30f3279e-aa2b-451b-9bee-c134d3f8374c ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5963-Fix-Missing-Node-Title-Editor-bug-2856d73d365081389edbda546eca3bbb) by [Unito](https://www.unito.io)
Merged
AustinMroz
added a commit
that referenced
this pull request
Oct 8, 2025
Includes - Subgraph widget promotion fixes (#5911) - fix "what's changed" release toast attention level logic (#5959) - Fix: Missing Node Title Editor bug (#5963) - OpenAIVideoSora2 Frontend pricing (#5958) - hotfix: quick test updates for sora2 pricing badge. (#5966) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5986-Initial-1-28-backports-2866d73d365081448ff2c4827bdbb9e5) by [Unito](https://www.unito.io) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Marwan Ahmed <155799754+marawan206@users.noreply.github.com>
arjansingh
pushed a commit
that referenced
this pull request
Oct 12, 2025
Found by @marawan206 ## Summary Fixes the title editor glitching when the node doesn't have an initial value ## Screenshots (if applicable) ### Before https://github.com/user-attachments/assets/4c4efbfd-73b9-4733-8227-fe2de59648d4 ### After https://github.com/user-attachments/assets/30f3279e-aa2b-451b-9bee-c134d3f8374c ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5963-Fix-Missing-Node-Title-Editor-bug-2856d73d365081389edbda546eca3bbb) by [Unito](https://www.unito.io)
arjansingh
pushed a commit
that referenced
this pull request
Oct 13, 2025
Found by @marawan206 ## Summary Fixes the title editor glitching when the node doesn't have an initial value ## Screenshots (if applicable) ### Before https://github.com/user-attachments/assets/4c4efbfd-73b9-4733-8227-fe2de59648d4 ### After https://github.com/user-attachments/assets/30f3279e-aa2b-451b-9bee-c134d3f8374c ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5963-Fix-Missing-Node-Title-Editor-bug-2856d73d365081389edbda546eca3bbb) by [Unito](https://www.unito.io)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by @marawan206
Summary
Fixes the title editor glitching when the node doesn't have an initial value
Screenshots (if applicable)
Before
Screen.Recording.2025-10-07.151949.mp4
After
Screen.Recording.2025-10-07.152039.mp4
┆Issue is synchronized with this Notion page by Unito