OpenAIVideoSora2 Frontend pricing by marawan206 · Pull Request #5958 · Comfy-Org/ComfyUI_frontend

marawan206 · 2025-10-07T17:35:40Z

test: update OpenAIVideoSora2 tests to use size instead of resolution

Refactored all OpenAIVideoSora2 test cases in useNodePricing.test.ts to align with
the updated node logic that replaces the resolution widget with size.
Adjusted validation, pricing, and error message expectations accordingly.

┆Issue is synchronized with this Notion page by Unito

…0ac0ee004

… and 1080p for Sora-2 and Sora-2-pro

…esolution

src/composables/node/useNodePricing.ts

…substring matching (size.includes('720')) with explicit

github-actions · 2025-10-07T18:43:42Z

🎨 Storybook Build Status

Build is starting...

⏰ Started at: 10/07/2025, 11:29:06 PM UTC

🚀 Building Storybook

📦 Installing dependencies...
🔧 Building Storybook components...
🌐 Preparing deployment to Cloudflare Pages...

⏱️ Please wait while the Storybook build is in progress...

github-actions · 2025-10-07T18:43:45Z

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/07/2025, 11:46:16 PM UTC

📈 Summary

Total Tests: 490
Passed: 459 ✅
Failed: 0
Flaky: 1 ⚠️
Skipped: 30 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 450 / ❌ 0 / ⚠️ 1 / ⏭️ 30
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

…substring matching (size.includes('720')) with explicit

bigcat88

prices are displayed correctly

… message

src/composables/node/useNodePricing.ts

…n and pricingCalculator which are now pure functions

.github/workflows/i18n-custom-nodes.yaml

DrJKL · 2025-10-07T23:48:17Z

I'll fix the vitest tests next.

## Summary Update expectations post-merge. See #5958

DrJKL · 2025-10-08T00:15:30Z

I'll fix the vitest tests next.

#5966

test: update OpenAIVideoSora2 tests to use `size` instead of `resolution` Refactored all OpenAIVideoSora2 test cases in useNodePricing.test.ts to align with the updated node logic that replaces the `resolution` widget with `size`. Adjusted validation, pricing, and error message expectations accordingly. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5958-Update-OpenAIVideoSora2-tests-for-new-size-based-pricing-logic-2856d73d365081c9919dd256cce40492) by [Unito](https://www.unito.io)

comfy-pr-bot · 2025-10-08T00:20:16Z

@marawan206 Successfully backported to #5967

## Summary Update expectations post-merge. See #5958

Backport of #5958 to `core/1.27` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5967-backport-1-27-OpenAIVideoSora2-Frontend-pricing-2866d73d365081b8a146d579824a005d) by [Unito](https://www.unito.io) --------- Co-authored-by: Marwan Ahmed <155799754+marawan206@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>

test: update OpenAIVideoSora2 tests to use `size` instead of `resolution` Refactored all OpenAIVideoSora2 test cases in useNodePricing.test.ts to align with the updated node logic that replaces the `resolution` widget with `size`. Adjusted validation, pricing, and error message expectations accordingly. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5958-Update-OpenAIVideoSora2-tests-for-new-size-based-pricing-logic-2856d73d365081c9919dd256cce40492) by [Unito](https://www.unito.io)

## Summary Update expectations post-merge. See #5958

Includes - Subgraph widget promotion fixes (#5911) - fix "what's changed" release toast attention level logic (#5959) - Fix: Missing Node Title Editor bug (#5963) - OpenAIVideoSora2 Frontend pricing (#5958) - hotfix: quick test updates for sora2 pricing badge. (#5966) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5986-Initial-1-28-backports-2866d73d365081448ff2c4827bdbb9e5) by [Unito](https://www.unito.io) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Marwan Ahmed <155799754+marawan206@users.noreply.github.com>

test: update OpenAIVideoSora2 tests to use `size` instead of `resolution` Refactored all OpenAIVideoSora2 test cases in useNodePricing.test.ts to align with the updated node logic that replaces the `resolution` widget with `size`. Adjusted validation, pricing, and error message expectations accordingly. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5958-Update-OpenAIVideoSora2-tests-for-new-size-based-pricing-logic-2856d73d365081c9919dd256cce40492) by [Unito](https://www.unito.io)

## Summary Update expectations post-merge. See #5958

test: update OpenAIVideoSora2 tests to use `size` instead of `resolution` Refactored all OpenAIVideoSora2 test cases in useNodePricing.test.ts to align with the updated node logic that replaces the `resolution` widget with `size`. Adjusted validation, pricing, and error message expectations accordingly. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5958-Update-OpenAIVideoSora2-tests-for-new-size-based-pricing-logic-2856d73d365081c9919dd256cce40492) by [Unito](https://www.unito.io)

## Summary Update expectations post-merge. See #5958

marawan206 and others added 5 commits September 13, 2025 13:17

ci(tests-ui): pin ComfyUI_devtools to 60a61dcf8c961d5eea669e9ab7bb8dc…

d6db75f

…0ac0ee004

ci(tests-ui): update devtools SHA in test-ui.yaml

6c140dc

Merge branch 'Comfy-Org:main' into main

e77aab5

feat(pricing): deterministic OpenAIVideoSora2 pricing added (for 720p…

7c33349

… and 1080p for Sora-2 and Sora-2-pro

Update OpenAIVideoSora2 tests and pricing logic for size instead of r…

fac7ac3

…esolution

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 7, 2025

marawan206 marked this pull request as draft October 7, 2025 17:36

marawan206 marked this pull request as ready for review October 7, 2025 17:36

bigcat88 reviewed Oct 7, 2025

View reviewed changes

src/composables/node/useNodePricing.ts Outdated Show resolved Hide resolved

refactor: improve clarity in OpenAIVideoSora2 size checks , Replaced …

075c06d

…substring matching (size.includes('720')) with explicit

refactor: improve clarity in OpenAIVideoSora2 size checks , Replaced …

acacf70

…substring matching (size.includes('720')) with explicit

bigcat88 previously approved these changes Oct 7, 2025

View reviewed changes

bigcat88 added the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Oct 7, 2025

bigcat88 mentioned this pull request Oct 7, 2025

feat(api-nodes): add Sora2 API node Comfy-Org/ComfyUI#10249

Merged

Fix Sora2 pricing: explicit size validation and accurate missing-size…

2ddcc0a

… message

marawan206 dismissed bigcat88’s stale review via 2ddcc0a October 7, 2025 20:12

DrJKL reviewed Oct 7, 2025

View reviewed changes

src/composables/node/useNodePricing.ts Outdated Show resolved Hide resolved

src/composables/node/useNodePricing.ts Outdated Show resolved Hide resolved

src/composables/node/useNodePricing.ts Outdated Show resolved Hide resolved

marawan206 added 2 commits October 8, 2025 00:11

Revert unintended changes to CI workflow, changes to Sora-2 Validatio…

8b84e47

…n and pricingCalculator which are now pure functions

Revert unintended changes to CI workflow, changes to Sora-2 Validatio…

0c891da

…n and pricingCalculator which are now pure functions

marawan206 changed the title ~~Update OpenAIVideoSora2 tests for new size-based pricing logic~~ test pr Oct 7, 2025

marawan206 changed the title ~~test pr~~ OpenAIVideoSora2 Frontend pricing Oct 7, 2025

marawan206 requested a review from DrJKL October 7, 2025 21:43

christian-byrne added the claude-review Add to trigger a PR code review from Claude Code label Oct 7, 2025

Code clean-up, removed unneccessary commits from branching

7fdf3db

DrJKL previously approved these changes Oct 7, 2025

View reviewed changes

.github/workflows/i18n-custom-nodes.yaml Show resolved Hide resolved

marawan206 dismissed DrJKL’s stale review via 75f365f October 7, 2025 23:01

Removed extra spacing/typo

e20a5f0

marawan206 force-pushed the sora2-pricing branch from 75f365f to e20a5f0 Compare October 7, 2025 23:06

Update i18n-custom-nodes.yaml

d70c93f

DrJKL approved these changes Oct 7, 2025

View reviewed changes

DrJKL merged commit 34d5a45 into Comfy-Org:main Oct 7, 2025
25 of 26 checks passed

DrJKL mentioned this pull request Oct 8, 2025

hotfix: quick test updates for sora2 pricing badge. #5966

Merged

DrJKL added a commit that referenced this pull request Oct 8, 2025

hotfix: quick test updates for sora2 pricing badge. (#5966)

0616c04

## Summary Update expectations post-merge. See #5958

DrJKL added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch 1.27 and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch labels Oct 8, 2025

comfy-pr-bot mentioned this pull request Oct 8, 2025

[backport 1.27] OpenAIVideoSora2 Frontend pricing #5967

Merged

DrJKL added a commit that referenced this pull request Oct 8, 2025

hotfix: quick test updates for sora2 pricing badge. (#5966)

ced897d

## Summary Update expectations post-merge. See #5958

AustinMroz added the 1.28 label Oct 8, 2025

AustinMroz pushed a commit that referenced this pull request Oct 8, 2025

hotfix: quick test updates for sora2 pricing badge. (#5966)

d97e79d

## Summary Update expectations post-merge. See #5958

AustinMroz mentioned this pull request Oct 8, 2025

Initial 1.28 backports #5986

Merged

arjansingh pushed a commit that referenced this pull request Oct 12, 2025

hotfix: quick test updates for sora2 pricing badge. (#5966)

61d8ccb

## Summary Update expectations post-merge. See #5958

arjansingh pushed a commit that referenced this pull request Oct 13, 2025

hotfix: quick test updates for sora2 pricing badge. (#5966)

cb24b73

## Summary Update expectations post-merge. See #5958

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenAIVideoSora2 Frontend pricing#5958

OpenAIVideoSora2 Frontend pricing#5958
DrJKL merged 13 commits intoComfy-Org:mainfrom
marawan206:sora2-pricing

marawan206 commented Oct 7, 2025 •

edited by sync-by-unito bot

Loading

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

bigcat88 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrJKL commented Oct 7, 2025

Uh oh!

DrJKL commented Oct 8, 2025

Uh oh!

comfy-pr-bot commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

marawan206 commented Oct 7, 2025 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🚀 Building Storybook

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

bigcat88 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DrJKL commented Oct 7, 2025

Uh oh!

DrJKL commented Oct 8, 2025

Uh oh!

comfy-pr-bot commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marawan206 commented Oct 7, 2025 •

edited by sync-by-unito bot

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading