Skip to content

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 28, 2025

Summary

Merge markers were inadvertantly merged in #5801, which I thought was good to merge but missed this due to difficulty reviewing the thousands of lines of translations that were in the backlog due to month+ long downtime on translation CI.

┆Issue is synchronized with this Notion page by Unito

Copy link

github-actions bot commented Sep 28, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 09/28/2025, 10:51:12 PM UTC

📈 Summary

  • Total Tests: 449
  • Passed: 419 ✅
  • Failed: 1 ❌
  • Flaky: 0
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 412 / ❌ 1 / ⚠️ 0 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 28, 2025
@christian-byrne
Copy link
Contributor Author

Test failure due to the upstream change adding a display name to LoadAudio node: https://57f79556.comfyui-playwright-chromium.pages.dev/#?testId=b0dfd63f5ac6a12fbe6e-8a6ba0bf35a23c6cbcf2

@christian-byrne christian-byrne merged commit 0ee3138 into core/1.27 Sep 28, 2025
21 of 22 checks passed
@christian-byrne christian-byrne deleted the fix/core-1.27-locale-json branch September 28, 2025 23:06
AustinMroz added a commit that referenced this pull request Sep 30, 2025
## What's Changed
### 🚀 Features
- add pricing for new api nodes (#5725)
- Rework desktop install / startup UX (#5292)

### 🐛 Bug Fixes
- Make experiment asset api setting hidden (#5861)
- Only add the listeners for DomWidget components once (#5849)
- fix invalid JSON (contains merge conflict markers) in 1.27 RC branch's
locale json (#5839)
- fix: Status indicator and close button appearing together  (#5741)
- Fix cyclic prototype errors with subgraphNodes (#5650)
- fix: don't immediately close missing nodes dialog if manager is
disabled (#5649)
- Fix SaveAs (#5644)

### 🔧 Maintenance  
- Add JSON validation CI workflow (#5838)
- Cherry-pick manager flag refactor to core/1.27 (#5646)
- Cherry-pick desktop dialogs framework to core/1.27 (#5634)

**Full Changelog**:
v1.27.5...v1.27.7

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5862-1-27-7-27e6d73d3650819aa712e682f6b88077)
by [Unito](https://www.unito.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants