[backport] Fix cyclic prototype errors with subgraphNodes #5650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To accomplish this, it pulls WidgetLocator information from the node owning the widget. This `node` property does not exist on all IBaseWidget. `toConcrete` was used to instead have a BaseWidget which is guaranteed to have a node property. The issue that was missed, is that a widget which lacks this information (such as most implemented by custom nodes) sets the node value to the argument which was passed. Here that is the reference to the subgraph node. Sometimes, this `#setWidget` call is made multiple times, and when this occurs, the `input.widget` has itself set as the protoyep, throwing an error. This is resolved by instead taking an additional input which is unambiguous. For reference, this is a near minimal workflow using comfy_mtb that replicates the issue [cyclic.json](https://github.com/user-attachments/files/22412187/cyclic.json) Special thanks to @melMass for assistance discovering this issue. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5637-Fix-cyclic-prototype-errors-with-subgraphNodes-2726d73d365081fea356f5197e4c2b42) by [Unito](https://www.unito.io)
dosubot
bot
added
the
size:M
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/19/2025, 01:51:16 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
changed the title
Merged
AustinMroz
added a commit
that referenced
this pull request
Sep 30, 2025
## What's Changed ### 🚀 Features - add pricing for new api nodes (#5725) - Rework desktop install / startup UX (#5292) ### 🐛 Bug Fixes - Make experiment asset api setting hidden (#5861) - Only add the listeners for DomWidget components once (#5849) - fix invalid JSON (contains merge conflict markers) in 1.27 RC branch's locale json (#5839) - fix: Status indicator and close button appearing together (#5741) - Fix cyclic prototype errors with subgraphNodes (#5650) - fix: don't immediately close missing nodes dialog if manager is disabled (#5649) - Fix SaveAs (#5644) ### 🔧 Maintenance - Add JSON validation CI workflow (#5838) - Cherry-pick manager flag refactor to core/1.27 (#5646) - Cherry-pick desktop dialogs framework to core/1.27 (#5634) **Full Changelog**: v1.27.5...v1.27.7 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5862-1-27-7-27e6d73d3650819aa712e682f6b88077) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #5637: Fix cyclic prototype errors with subgraphNodes
┆Issue is synchronized with this Notion page by Unito