[refactor] Replace manual semantic version utilities/functions with semver package #5653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace custom compareVersions() with semver.compare() - Replace custom isSemVer() with semver.valid() - Remove deprecated version comparison functions from formatUtil.ts - Update all version comparison logic across components and stores - Fix tests to use semver mocking instead of formatUtil mocking Improves reliability and consistency by using industry-standard semantic version handling. The semver package provides better edge case handling and is well-maintained. Fixes #4787
dosubot
bot
added
the
size:L
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/19/2025, 06:49:24 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
changed the title
DrJKL
previously approved these changes
Sep 19, 2025
src/components/dialog/content/manager/PackVersionSelectorPopover.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: DrJKL <[email protected]>
…s review feedback Co-authored-by: DrJKL <[email protected]>
…sses review feedback Co-authored-by: DrJKL <[email protected]>
- Updated import paths for moved components and stores - Kept semver imports instead of formatUtil - Updated store path: @/stores/comfyManagerStore -> @/workbench/extensions/manager/stores/comfyManagerStore - Updated component paths to workbench structure
…edback Co-authored-by: DrJKL <[email protected]>
… addresses review feedback
Converts all instances of 'import * as semver from "semver"' to use specific named imports like 'import { valid, compare } from "semver"' for consistency and improved tree-shaking.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
compareVersions()withsemver.compare()isSemVer()withsemver.valid()formatUtil.tsBenefits
semverpackageFixes #4787
┆Issue is synchronized with this Notion page by Unito