Skip to content

Conversation

comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Sep 18, 2025

Backport of #5635 to core/1.26

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…ger (#5635)

## Summary
- Updated frontend to align with backend changes in ComfyUI core PR
#7555
- Changed manager startup argument from `--disable-manager` (opt-out) to
`--enable-manager` (opt-in)
- Manager is now disabled by default unless explicitly enabled

## Changes
- Modified `useManagerState.ts` to check for `--enable-manager` flag
presence
- Inverted logic: manager is disabled when the flag is NOT present
- Updated all related tests to reflect the new opt-in behavior
- Fixed edge case where `systemStats` is null

## Related
- Backend PR: comfyanonymous/ComfyUI#7555

## Test Plan
- [x] All unit tests pass
- [x] Verified manager state logic with different flag combinations
- [x] TypeScript type checking passes
- [x] Linting passes

🤖 Generated with [Claude Code](https://claude.ai/code)

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5635-refactor-Change-manager-flag-from-disable-manager-to-enable-manager-2726d73d36508153a88bd9f152132b2a)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot requested review from a team as code owners September 18, 2025 18:45
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 18, 2025
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 18, 2025
@christian-byrne
Copy link
Contributor

Test failure expected due to #5544

@christian-byrne christian-byrne merged commit 766b3b8 into core/1.26 Sep 18, 2025
22 of 23 checks passed
@christian-byrne christian-byrne deleted the backport-5635-to-1.26 branch September 18, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants