Update test expectations to match core node change #5544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 09/14/2025, 02:37:33 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
changed the title
christian-byrne
added
the
New Browser Test Expectations
DrJKL
previously approved these changes
Sep 13, 2025
There was a problem hiding this comment.
This one keeps flip-flopping, is there something we're not waiting for in the test?
There was a problem hiding this comment.
For this, there was a bug where animated webp were being treated as normal webp. So the test asset is an animated webp with 2 frames. The left (image being deleted) shows the second frame -- indicating the node is properly displaying animated webp images. But since it relies on animation of webp, it is just really flaky I guess.
I should just change the test to fixme
arjansingh
previously approved these changes
Sep 13, 2025
Removes animated-image-preview-saved-webp-chromium-linux.png to leave only one image in the PR as requested. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
christian-byrne
dismissed stale reviews from arjansingh and DrJKL
via
c467360
This was referenced Sep 18, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit comfyanonymous/ComfyUI@80b7c94 changed LoadVAE default appearance by adding
pixel_spacevalue. Update test snapshot baseline to reflect new state.┆Issue is synchronized with this Notion page by Unito