Add desktop dialogs framework #5605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
🎭 Playwright Test Results⏰ Completed at: 09/17/2025, 11:22:26 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
reviewed
Sep 16, 2025
Comment on lines
46
to
69
| <style scoped> | ||
| @reference '../assets/css/style.css'; | ||
| .p-button-secondary { | ||
| @apply text-white rounded-lg border-none bg-neutral-600; | ||
| } | ||
| .p-button-secondary:hover { | ||
| @apply bg-neutral-550; | ||
| } | ||
| .p-button-secondary:active { | ||
| @apply bg-neutral-500; | ||
| } | ||
| .p-button-danger { | ||
| @apply bg-coral-red-600 border-0; | ||
| } | ||
| .p-button-danger:hover { | ||
| @apply bg-coral-red-500; | ||
| } | ||
| .p-button-danger:active { | ||
| @apply bg-coral-red-400; | ||
| } |
There was a problem hiding this comment.
The border-0 needs to go, but how would you like this done? I do not want to blast over the entire frontend, which is how I would normally go about setting severity colours (globally).
There was a problem hiding this comment.
Discussed offline:
- This is not the frontend pattern
- It is attempting to emulate a second
style.css, as we cannot easily use one - A temporary exception is being made until we either: unify all designs on the same buttons, or this just gets split out into a smaller, desktop-only section.
webfiltered
force-pushed
the
desktop-dialogs
branch
from
48a837c to
04738d4
Compare
DrJKL
previously approved these changes
Sep 17, 2025
DrJKL
reviewed
Sep 17, 2025
- Added --color-danger-button base color (#f14352) - Defined three state variants using rgb(from var()) syntax: - default: 50% opacity - hover: 75% opacity - active: 88% opacity - Updated DesktopDialogView to use theme variables
The alpha colours do not work in light mode. There should be no visible change in dark mode from this commit.
This reverts commit 851f57cd8718b6595488301f90c2dd1c94e66de0.
webfiltered
force-pushed
the
desktop-dialogs
branch
from
46f4126 to
7149143
Compare
webfiltered
added
needs-backport
webfiltered
added a commit
that referenced
this pull request
Sep 18, 2025
### Summary Adds desktop dialog framework with data-driven dialog definitions. ### Changes - Data-driven dialog structure in `desktopDialogs.ts` - Dynamic dialog view component with i18n support - Button action types: openUrl, close, cancel - Button severity levels for styling (primary, secondary, danger, warn) - Fallback invalid dialog for error handling - i18n collection script updated for dialog strings
webfiltered
added a commit
that referenced
this pull request
Sep 18, 2025
## Summary Cherry-picked PR #5605 (Add desktop dialogs framework) to core/1.27 branch for hotfix release. ## Cherry-picked commits - 09e7d10: Add desktop dialogs framework (#5605) ## Changes - Data-driven dialog structure in `desktopDialogs.ts` - Dynamic dialog view component with i18n support - Button action types: openUrl, close, cancel - Button severity levels for styling (primary, secondary, danger, warn) - Fallback invalid dialog for error handling - i18n collection script updated for dialog strings ## Testing - Typecheck passed ✓ - Cherry-pick applied cleanly without conflicts ## Impact This adds the desktop dialog framework feature to the stable 1.27 branch, allowing desktop applications to display standardized dialogs. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5634-Hotfix-Cherry-pick-desktop-dialogs-framework-to-core-1-27-2726d73d3650811188e7f7e58766d52f) by [Unito](https://www.unito.io)
Myestery
pushed a commit
that referenced
this pull request
Sep 19, 2025
### Summary Adds desktop dialog framework with data-driven dialog definitions. ### Changes - Data-driven dialog structure in `desktopDialogs.ts` - Dynamic dialog view component with i18n support - Button action types: openUrl, close, cancel - Button severity levels for styling (primary, secondary, danger, warn) - Fallback invalid dialog for error handling - i18n collection script updated for dialog strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds desktop dialog framework with data-driven dialog definitions.
Changes
desktopDialogs.tsReview focus
Screenshots
When a corrupt environment is detected during server start:
If we make mistakes during dev (should NEVER be seen in prod):
