Add custom dialog handling for Desktop #5543
Conversation
dosubot
bot
added
the
size:L
🎭 Playwright Test Results🕵🏻 No test results found ⏰ Completed at: 09/15/2025, 10:02:56 AM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
| @reference '../assets/css/style.css'; | ||
|
|
||
| .dialog-title { | ||
| font-family: 'ABC ROM'; |
There was a problem hiding this comment.
Could you register the font in style.css and use the tailwind utility?
There was a problem hiding this comment.
This should probably be draft, sorry~
The font isn't in the repo yet; and this PR shouldn't add it. But yes, it annoyed me to have to create a class just for this. 😃
| } | ||
|
|
||
| .p-button { | ||
| @apply rounded-lg; |
There was a problem hiding this comment.
Please just add the class to the button, I'm trying to get rid of all of the @applys and prohibit them with a linter soon.
There was a problem hiding this comment.
Sorry you had to read that. The scoped styles are ~80% generated slop - which I pray does not come as a surprise.
| .p-button-secondary { | ||
| @apply text-white rounded-lg border-none; | ||
|
|
||
| background: var(--color-button-background, rgba(255, 255, 255, 0.15)); |
| } | ||
|
|
||
| .p-button-secondary:hover { | ||
| background: rgba(255, 255, 255, 0.25); |
| } | ||
|
|
||
| .p-button-danger { | ||
| background: rgba(241, 67, 82, 0.5); |
There was a problem hiding this comment.
Could you name the base color and put it into the color palette?
| color: #f0ff41; | ||
| border: 0; |
There was a problem hiding this comment.
These should inherit from the original declaration, no need to add them for each modifier state if you're not changing the value.
webfiltered
force-pushed
the
custom-dialog
branch
from
1d705fd to
f320b76
Compare
|
Replaced by #5605. |
3 participants
Summary
Adds a basic dialog endpoint for the desktop app.
Changes
Caveats
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito