[fix] Update Litegraph test snapshots after PR #5310 #5314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 09/03/2025, 06:31:02 AM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
DrJKL
previously approved these changes
Sep 3, 2025
| }) | ||
|
|
||
| input.widget = { name: subgraphInput.name } | ||
| const hasNode = (w: any): w is { node: LGraphNode } => |
Contributor
There was a problem hiding this comment.
Might have to add an additional shape check, but I think we can avoid an explicit any here.
Suggested change
| const hasNode = (w: any): w is { node: LGraphNode } => | |
| const hasNode = (w: unknown): w is { node: LGraphNode } => |
Collaborator
There was a problem hiding this comment.
This is likely a missed checkout after reviewing #5024. Here, unknown is insufficient because an unknown w doesn't have a .node attribute.
Contributor
Author
There was a problem hiding this comment.
Oops, was testing Austin's PR forgot to checkout back to main before making this PR.
Contributor
There was a problem hiding this comment.
Updates outdated snapshots to match current LiteGraph behavior.
christian-byrne
force-pushed
the
fix/litegraph-test-snapshots
branch
from
6c7a884 to
95cac2e
Compare
dosubot
bot
added
size:XS
DrJKL
approved these changes
Sep 3, 2025
snomiao
pushed a commit
that referenced
this pull request
Sep 12, 2025
Updates outdated snapshots to match current LiteGraph behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context
After PR #5310 added the Litegraph test configuration, the test suite revealed that 3 snapshot tests had outdated expectations. This PR updates those snapshots to match the current behavior.
Test Results
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito