Skip to content

Conversation

@jtydhr88
Copy link
Collaborator

@jtydhr88 jtydhr88 commented Sep 3, 2025

run all litegraph tests
pnpm vitest run --config vitest.litegraph.config.ts

run single test file
pnpm vitest run --config vitest.litegraph.config.ts src/lib/litegraph/test/CanvasPointer.deviceDetection.test.ts

┆Issue is synchronized with this Notion page by Unito

@jtydhr88 jtydhr88 requested a review from a team as a code owner September 3, 2025 01:00
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/03/2025, 02:05:20 AM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

@socket-security
Copy link

socket-security bot commented Sep 3, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​types/​jsdom@​21.1.71001007277100
Addedjsdom@​26.1.0981001009270

View full report

webfiltered
webfiltered previously approved these changes Sep 3, 2025
Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add *your vitest run line to the unit test npm script:

    "test:unit": "nx run test tests-ui/tests",

Depending on how advanced the unused file lint rule is, you may need to add an exception for the config file.

@DrJKL
Copy link
Contributor

DrJKL commented Sep 3, 2025

Should add *your vitest run line to the unit test npm script:

    "test:unit": "nx run test tests-ui/tests",

Depending on how advanced the unused file lint rule is, you may need to add an exception for the config file.

I'm working on the knip stuff now. I think the vitest plugin is pretty good about discovering configs.

@christian-byrne
Copy link
Contributor

I think this is okay to merge. It seems we need to re-generate the snapshots though.

@christian-byrne christian-byrne merged commit 65b6b27 into main Sep 3, 2025
11 checks passed
@christian-byrne christian-byrne deleted the add_litegraph_test_config_file branch September 3, 2025 03:57
christian-byrne added a commit that referenced this pull request Sep 3, 2025
- Updates 3 failing snapshot tests that were broken after recent Litegraph updates
- Snapshots were outdated due to changes in LiteGraph behavior
- All other tests (608/615) pass successfully
- Fixes test failures introduced in PR #5310

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@benceruleanlu benceruleanlu mentioned this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants