Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix playwright test on settings API" #1310

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Oct 25, 2024

Reverts #1303

Reason: setting side-effect handled automatically in #1309

@huchenlei huchenlei merged commit 25457d3 into main Oct 25, 2024
9 checks passed
@huchenlei huchenlei deleted the revert-1303-fix_test branch October 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant