Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup clean setting state before every playwright test #1309

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Oct 25, 2024

Resolves #1302

Setup clean setting state before every playwright test. Cleanup logic like following code should no longer be necessary.

  test.afterEach(async ({ comfyPage }) => {
    await comfyPage.setSetting('Comfy.CustomColorPalettes', {})
    await comfyPage.setSetting('Comfy.ColorPalette', 'dark')
    await comfyPage.setSetting('Comfy.Node.Opacity', 1.0)
  })

@huchenlei huchenlei changed the title Setting setup Setup clean setting state before every playwright test Oct 25, 2024
@huchenlei huchenlei merged commit 4f9dc83 into main Oct 25, 2024
9 checks passed
@huchenlei huchenlei deleted the setting_setup branch October 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playwright Test] Avoid settings side-effect by starting test with the same setting state
1 participant