Bot pause resume #264

MahdMalik · 2025-09-30T00:41:48Z

This code basically pauses the game when a bot is disconnected, and doesn't unpause until all bots are reconnected.

For this file, to fix dependency cycles, I had to make a separate "pauseHandler" file that both api.ts and tcp-interface.ts would call to pause/unpause the game. I couldn't put it in api.ts because otherwise dependency cycles exist (api.ts imports from tcp-interface.ts, and vice versa), and I couldn't put it in managers.ts because there are some dependency cycles related to Simulator, Robot, and Managers I believe. As far as I know, this is the only way that works.

I also had to move a function "setAllRobotsToDefaultPositions" into pauseHandler even though it doesn't exactly belong because again, dependency issues, as api.ts would call unpause game but then unpause game would call this function.

I hate dependency cycles.

added pause dialogs and messages to handle the client-side pause notification

Added a notification dialog to give the user information eg. game has been unpaused, puzzle info, line changes, etc.

added various gates to robot movement based on if the game is paused. Allowed pausing/unpausing through an api call

…chessbots-server

added a stop for promises in progress also added some hotfixes for pause

…rver

…it, going to do the safe for unpause game, then have to actually clal the methods

…f it does somehow work, need to do two things. First, make it so pausing and resuming requests sent by client/server are separate, so client can't unpause if server does. Second, make code more elegeant, ts solution is ugly as hell 🥀

saved game state as well as robot positions in save files

…d now? Gonna add comments and see if there's anything I can make better

…s kinda crapy though, ima see how I can make my code cleaner and better

…in pauseGame and unpauseGame

allowed pause to rollback the robot positions. Also allowed saveGame to load from a saved positions, so hopefully less errors

Forced clients to be paused even on join or reload.

* advanced stop procedure added a stop for promises in progress also added some hotfixes for pause * added robot saves saved game state as well as robot positions in save files * Added pause rollback allowed pause to rollback the robot positions. Also allowed saveGame to load from a saved positions, so hopefully less errors * pause on reload Forced clients to be paused even on join or reload. --------- Co-authored-by: ymmot239 <[email protected]> ^ I'm pulling this play feature code into bot-pause-resume to integrate with my side of the feature

…o integrate my unpauseGame function with what's currently being done, I have to just check that out and besides that this task is done

…r than it is right now as it's calling a function in a file it shouldn't really be calling

Added back some functions that were removed during a merge from main. Also removed some unused functions in executor.

Fixed the bug with executors not running all the commands Also cleaned up the paused api being sent to the clients.

…chessbots-server

… when the method is called in managers.ts

…vil method. Dunno if I can get it to look any better though

…probably the best it's gonna be to avoid looping dependencies

…be done I think?

Copilot

Pull Request Overview

This PR implements a bot pause/resume feature that automatically pauses the game when bots disconnect and resumes when all bots reconnect. The implementation includes a pause handler to manage dependency cycles, game state persistence through save files, and UI dialogs for pause notifications.

Adds automatic game pause on bot disconnect and resume when all bots reconnect
Creates a separate pauseHandler module to resolve dependency cycles
Extends save functionality to include board positions and robot locations
Updates UI with pause/unpause dialogs and prevents moves during pause

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/server/robot/robot.ts	Adds sendStopPacket method and improves packet formatting
src/server/robot/robot-manager.ts	Adds removeRobot and stopAllRobots methods for disconnect handling
src/server/command/executor.ts	Modifies command execution to respect pause state
src/server/command/command.ts	Updates command groups to check pause state before execution
src/server/api/tcp-interface.ts	Implements bot disconnect detection and pause/unpause triggers
src/server/api/save-manager.ts	Extends save format to include FEN and robot positions
src/server/api/pauseHandler.ts	New module handling pause logic and robot positioning
src/server/api/managers.ts	Adds disconnectedBots set for tracking
src/server/api/game-manager.ts	Updates game managers to respect pause state
src/server/api/api.ts	Adds pause/unpause endpoints and refactors positioning logic
src/common/game-end-reasons.ts	Adds GAME_PAUSED and GAME_UNPAUSED enum values
src/client/game/game.tsx	Implements pause UI state and prevents moves when paused
src/client/game/admin-dialogs.tsx	New pause and notification dialog components

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-30T00:45:23Z

src/server/robot/robot.ts

    }
+
+    public async sendStopPacket(): Promise<void> {
+        console.log("Stopoping the robot: " + this.id);


Typo in console log: 'Stopoping' should be 'Stopping'.

Suggested change

console.log("Stopoping the robot: " + this.id);

console.log("Stopping the robot: " + this.id);

Copilot · 2025-09-30T00:45:24Z

src/server/api/save-manager.ts

 */

 import { Side } from "../../common/game-types";
+2;


This line appears to be a stray '2;' that doesn't serve any purpose and should be removed.

Suggested change

2;

Copilot · 2025-09-30T00:45:24Z

src/server/api/pauseHandler.ts

+export let gamePaused = false;
+export let pauser: string = "none";
+
+export function setPaused(theFlag) {


Parameter 'theFlag' should have explicit type annotation. Should be 'theFlag: boolean'.

Suggested change

export function setPaused(theFlag) {

export function setPaused(theFlag: boolean) {

Copilot · 2025-09-30T00:45:24Z

src/server/api/pauseHandler.ts

+}
+
+// created a pause and unpause game function separately from the endpoint call so that another backend function can call it as well.
+export function pauseGame(clientSide) {


Parameter 'clientSide' should have explicit type annotation. Should be 'clientSide: boolean'.

Copilot · 2025-09-30T00:45:24Z

src/server/api/pauseHandler.ts

+    return { message: "success" };
+}
+
+export function unpauseGame(clientSide) {


Parameter 'clientSide' should have explicit type annotation. Should be 'clientSide: boolean'.

Copilot · 2025-09-30T00:45:25Z

src/server/command/command.ts

-        const promises = this.commands.map((move) => move.execute());
+        const promises = this.commands.map((move) => {
+            if (!gamePaused) return move.execute();
+        });


The map function may return undefined for paused commands, creating an array with undefined values. This should either filter out undefined values or handle the paused case differently.

Suggested change

});

}).filter(Boolean);

Copilot · 2025-09-30T00:45:25Z

src/server/command/command.ts

        for (const command of this.commands) {
-            promise = promise.then(() => command.execute());
+            promise = promise.then(() => {
+                if (!gamePaused) return command.execute();


Similar to ParallelCommandGroup, this may return undefined when the game is paused, potentially breaking the promise chain.

Suggested change

if (!gamePaused) return command.execute();

if (!gamePaused) {

return command.execute();

} else {

return Promise.resolve();

}

Copilot · 2025-09-30T00:45:25Z

src/client/game/admin-dialogs.tsx

+}
+
+/**
+ * SHows a closable notification dialog


Typo in comment: 'SHows' should be 'Shows'.

Suggested change

* SHows a closable notification dialog

* Shows a closable notification dialog

Copilot · 2025-09-30T00:45:26Z

src/client/game/game.tsx

+                move;
+            }; //send a do-nothing function if game is paused


The paused move handler just references 'move' without doing anything. This should either be an empty function or have a comment explaining why the move parameter is referenced.

Suggested change

move;

}; //send a do-nothing function if game is paused

// Do nothing when the game is paused

};

xXDMOGXx

Looks Good To Me

ymmot239 and others added 30 commits September 9, 2025 10:42

Added pause dialogs

f7836a3

added pause dialogs and messages to handle the client-side pause notification

Notification dialog

cafcf45

Added a notification dialog to give the user information eg. game has been unpaused, puzzle info, line changes, etc.

Server pause structure

e384175

added various gates to robot movement based on if the game is paused. Allowed pausing/unpausing through an api call

CHESSBOTS BEGINS NOW!!!! 🗣️🗣️🗣️🔥🔥🔥

f4b9f52

CHESSBOTS BEGINS NOW!!!! 🗣️🗣️🗣️🔥🔥🔥

32a4936

issue should be done less go

5991b28

fixed es lint and various errors

1a64c4b

ok now it should actually be fixed

281f28c

Merge branch 'main' into admin-pause-play

d87139b

Merge branch 'admin-pause-play' of https://github.com/Comet-Robotics/…

b3819e3

…chessbots-server

advanced stop procedure

a872c3f

added a stop for promises in progress also added some hotfixes for pause

Merge branch 'main' of https://github.com/Comet-Robotics/chessbots-se…

2439114

…rver

changed the pauseGame endpoint to also work if the server side calls …

7e9a4fa

…it, going to do the safe for unpause game, then have to actually clal the methods

added robot saves

9fccb54

saved game state as well as robot positions in save files

Merge branch 'main' into admin-pause-play

072b3a4

integrating pause/unpause with bot disconnects/connects should be goo…

fbc9ec7

…d now? Gonna add comments and see if there's anything I can make better

task should be done now, accounting for differnet people pausing. It'…

96361c4

…s kinda crapy though, ima see how I can make my code cleaner and better

moved some variables to managers.ts, just need to fix some ugly code …

84f702d

…in pauseGame and unpauseGame

task finished maybe

ee0153c

task is pretty mucch done, just gotta pass hte eslint check things.

93b09d7

Added pause rollback

c2d7b5e

allowed pause to rollback the robot positions. Also allowed saveGame to load from a saved positions, so hopefully less errors

pause on reload

e166cf9

Forced clients to be paused even on join or reload.

alright, fixed eslint and format errors. Task should be done?

7e626b1

just finished merging, there is kind of an issue with how I'm going t…

d128db4

…o integrate my unpauseGame function with what's currently being done, I have to just check that out and besides that this task is done

got a workingg solution for now, I want to see if I can make it bette…

c42eca4

…r than it is right now as it's calling a function in a file it shouldn't really be calling

Fixed merge conflicts

c2dfc02

Added back some functions that were removed during a merge from main. Also removed some unused functions in executor.

Execution bugfix

95d192c

Fixed the bug with executors not running all the commands Also cleaned up the paused api being sent to the clients.

Merge branch 'admin-pause-play' of https://github.com/Comet-Robotics/…

d0d7456

…chessbots-server

MahdMalik added 7 commits September 29, 2025 17:21

nearly done, final thing is figuring out how I should do the follback…

faa5547

… when the method is called in managers.ts

paushing/resuming on bot disconnect/connect works now but I used an e…

2d8d60d

…vil method. Dunno if I can get it to look any better though

changed it to have two exported functions as api.ts instead, this is …

ab1bb1c

…probably the best it's gonna be to avoid looping dependencies

I HATE DEPENDENCY CYCLES

4d4def1

TASK FINALLY FINISHED, CHESSBOTS BEGINS NOW!!!!!

8ae2199

fixed issue with it keeping robot data even after disconnect, should …

d14416d

…be done I think?

task is done I think?

0a8b8f4

MahdMalik linked an issue Sep 30, 2025 that may be closed by this pull request

Handle pausing and resuming the game upon bot disconnect/reconnect #256

Closed

Kandles11 requested a review from Copilot September 30, 2025 00:44

Copilot AI reviewed Sep 30, 2025

View reviewed changes

MahdMalik added 5 commits September 29, 2025 19:48

1984. They don't like the parameter name theFlag.

89309d6

rmeove weird 2

72f27d8

fixed some type non-declarations too

b8c0c7f

fixed formatting

faaa991

ok actually fixed copilot's PR comments fully

12b905b

xXDMOGXx approved these changes Oct 14, 2025

View reviewed changes

xXDMOGXx merged commit d73727d into main Oct 14, 2025
5 checks passed

xXDMOGXx deleted the bot-pause-resume branch October 14, 2025 00:39

democat3457 mentioned this pull request Oct 14, 2025

Admin pause play #261

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bot pause resume #264

Bot pause resume #264

Uh oh!

MahdMalik commented Sep 30, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

Copilot AI Sep 30, 2025

Uh oh!

xXDMOGXx left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	console.log("Stopoping the robot: " + this.id);
	console.log("Stopping the robot: " + this.id);

	export function setPaused(theFlag) {
	export function setPaused(theFlag: boolean) {

-                if (!gamePaused) return command.execute();
+                if (!gamePaused) {
+                    return command.execute();
+                } else {
+                    return Promise.resolve();
+                }

	* SHows a closable notification dialog
	* Shows a closable notification dialog

Bot pause resume #264

Bot pause resume #264

Uh oh!

Conversation

MahdMalik commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

xXDMOGXx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MahdMalik commented Sep 30, 2025 •

edited

Loading