Merging play features into bot-pause-resume #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a stop for promises in progress also added some hotfixes for pause
saved game state as well as robot positions in save files
allowed pause to rollback the robot positions. Also allowed saveGame to load from a saved positions, so hopefully less errors
Forced clients to be paused even on join or reload.
xXDMOGXx
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Added pause dialogs added pause dialogs and messages to handle the client-side pause notification * Notification dialog Added a notification dialog to give the user information eg. game has been unpaused, puzzle info, line changes, etc. * Server pause structure added various gates to robot movement based on if the game is paused. Allowed pausing/unpausing through an api call * CHESSBOTS BEGINS NOW!!!! 🗣️🗣️🗣️🔥🔥🔥 * issue should be done less go * fixed es lint and various errors * ok now it should actually be fixed * advanced stop procedure added a stop for promises in progress also added some hotfixes for pause * changed the pauseGame endpoint to also work if the server side calls it, going to do the safe for unpause game, then have to actually clal the methods * theoretically may have pausing of the game working, gonna test now. If it does somehow work, need to do two things. First, make it so pausing and resuming requests sent by client/server are separate, so client can't unpause if server does. Second, make code more elegeant, ts solution is ugly as hell 🥀 * added robot saves saved game state as well as robot positions in save files * integrating pause/unpause with bot disconnects/connects should be good now? Gonna add comments and see if there's anything I can make better * task should be done now, accounting for differnet people pausing. It's kinda crapy though, ima see how I can make my code cleaner and better * moved some variables to managers.ts, just need to fix some ugly code in pauseGame and unpauseGame * task finished maybe * task is pretty mucch done, just gotta pass hte eslint check things. * Added pause rollback allowed pause to rollback the robot positions. Also allowed saveGame to load from a saved positions, so hopefully less errors * pause on reload Forced clients to be paused even on join or reload. * alright, fixed eslint and format errors. Task should be done? * Merging play features into bot-pause-resume (#262) * advanced stop procedure added a stop for promises in progress also added some hotfixes for pause * added robot saves saved game state as well as robot positions in save files * Added pause rollback allowed pause to rollback the robot positions. Also allowed saveGame to load from a saved positions, so hopefully less errors * pause on reload Forced clients to be paused even on join or reload. --------- Co-authored-by: ymmot239 <[email protected]> ^ I'm pulling this play feature code into bot-pause-resume to integrate with my side of the feature * just finished merging, there is kind of an issue with how I'm going to integrate my unpauseGame function with what's currently being done, I have to just check that out and besides that this task is done * got a workingg solution for now, I want to see if I can make it better than it is right now as it's calling a function in a file it shouldn't really be calling * Fixed merge conflicts Added back some functions that were removed during a merge from main. Also removed some unused functions in executor. * Execution bugfix Fixed the bug with executors not running all the commands Also cleaned up the paused api being sent to the clients. * nearly done, final thing is figuring out how I should do the follback when the method is called in managers.ts * paushing/resuming on bot disconnect/connect works now but I used an evil method. Dunno if I can get it to look any better though * changed it to have two exported functions as api.ts instead, this is probably the best it's gonna be to avoid looping dependencies * I HATE DEPENDENCY CYCLES * TASK FINALLY FINISHED, CHESSBOTS BEGINS NOW!!!!! * fixed issue with it keeping robot data even after disconnect, should be done I think? * task is done I think? * 1984. They don't like the parameter name theFlag. * rmeove weird 2 * fixed some type non-declarations too * fixed formatting * ok actually fixed copilot's PR comments fully --------- Co-authored-by: ymmot239 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just merging the changes Tommy made into the branch I'm working on so that I can make sure pausing on bot disconnect and such is fully implemented.