Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev build and development.php file #586

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Conversation

HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Jul 3, 2023

All Submissions:

Changes proposed in this Pull Request:

This adds a development.php file to the codebase which loads when you setup the env locally and by default loads the Optimole test constants. It has a constant than you can toggle to use those if you want.

The dev build also includes the development build of React code which should provide more descriptive errors in console.

It also adds the prod & dev build to the Github comments.

Closes #567.

How to test the changes in this Pull Request:

  1. When you install build zip from comments, it should work as normal.
  2. When you install the dev build zip from comments, it should work as normal too and by default connect to staging site.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@pirate-bot
Copy link
Collaborator

pirate-bot commented Jul 3, 2023

Plugin build for 2bb39dd is ready 🛎️!

@HardeepAsrani HardeepAsrani linked an issue Jul 3, 2023 that may be closed by this pull request
@irinelenache
Copy link

@HardeepAsrani Tested and both builds work as expected 🚀

@HardeepAsrani
Copy link
Member Author

Awesome @irinelenache, once this is merged QA team can directly use dev builds when needed to test against staging instead of using the optimole-test repository.

@abaicus abaicus merged commit acfaaa6 into development Jul 4, 2023
8 checks passed
@abaicus abaicus deleted the fix/issue-567 branch July 4, 2023 07:50
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dev build to build packages
4 participants