Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review distignore for the newly dev added files #570

Closed
selul opened this issue Jun 19, 2023 · 1 comment
Closed

review distignore for the newly dev added files #570

selul opened this issue Jun 19, 2023 · 1 comment
Assignees
@abaicus
Labels
bug This label could be used to identify issues that are caused by a defect in the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Milestone
3.9

Comments

@selul
Copy link
Contributor

selul commented Jun 19, 2023

Description

With the dashboard migration to react we might need to review the .distignore file for removing the files that are not necessary in the final artifact.

Step-by-step reproduction instructions

  1. Generate the zip file using the npm run dist
  2. Check for files that are development-related and not necessary in the final zip.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No
@selul selul added the bug This label could be used to identify issues that are caused by a defect in the product. label Jun 19, 2023
@abaicus abaicus self-assigned this Jun 30, 2023
@abaicus abaicus added this to the 3.9 milestone Jun 30, 2023
@abaicus abaicus added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Jun 30, 2023
@abaicus
Copy link
Contributor

abaicus commented Jul 5, 2023

I checked, and it seems @HardeepAsrani handled this in #586 as well.

@abaicus abaicus closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abaicus abaicus

Labels
bug This label could be used to identify issues that are caused by a defect in the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Milestone
3.9
Development

No branches or pull requests
2 participants
@selul @abaicus