typography + meta #2975
Merged
typography + meta #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamwasp
commented
Nov 21, 2024
Comment on lines
42
to
47
| <FlexBox center px={24}> | ||
| <img | ||
| src="./typography/anchor.png" | ||
| alt="The anatomy of the Anchor component, detailed below." | ||
| /> | ||
| </FlexBox> |
There was a problem hiding this comment.
i'm gonna swap this to @LinKCoding's component/make it smaller after his pr is merged into the base storybook-8 branch
dreamwasp
requested review from
timjenkins,
LinKCoding and
aresnik11
and removed request for
a team and
timjenkins
dreamwasp
commented
Nov 21, 2024
| 'Layouts', | ||
| 'Typography', | ||
| 'Atoms', | ||
| '*', |
There was a problem hiding this comment.
we can add Molecules + Organisms here after they're merged in!
LinKCoding
approved these changes
Nov 22, 2024
| status: 'current', | ||
| }; | ||
|
|
||
| <Meta title="Meta/Best Practices" /> |
There was a problem hiding this comment.
Nit/Q: curious about the space here, thought that for naming more often than not we'd stick to camelCasing or snake_casing b.c. spaces can be weird.
The page loads just fine but wanted to ask still :)
There was a problem hiding this comment.
yea but the MDX file name is what renders in the left side org panel, so i think this is the exception (and is the pattern regularly used in Stoybooks)
Comment on lines
79
to
83
| <Box bg="navy-400" border={1} color="white" mx={16} p={16}> | ||
| <Text smooth> | ||
| Share your css methods easily with `StyleProps` from `gamut-styles`! | ||
| </Text> | ||
| </Box> |
There was a problem hiding this comment.
Food for thought: we could have a callout type component for these things!
Or maybe the success/feature Alert?
There was a problem hiding this comment.
love it, will cut a ticket for a follow-up QoL improvement
Comment on lines
236
to
238
| * { | ||
| box-sizing: content-box; | ||
| } |
There was a problem hiding this comment.
Nit: the spacing here looks off, esp line 237
There was a problem hiding this comment.
good looking out, will fix!
|
|
||
| ## Prework | ||
|
|
||
| We track planned work for Gamut components in the [Gamut Board](https://codecademy.atlassian.net/jira/software/projects/WEB/boards/1386) on JIRA. |
There was a problem hiding this comment.
This should be updated to: https://skillsoftdev.atlassian.net/jira/software/projects/GM/boards/784
|
|
||
| Please fill out the pull request template, including links to the corresponding Abstract design and JIRA ticket. | ||
|
|
||
| > 😉 Protip: You can use a [Draft PR](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests#draft-pull-requests) to still run CI jobs. |
There was a problem hiding this comment.
Seeing as theses tips popup from time to time, it'd be nice to standardize them :)
| ```tsx | ||
| import { Text } from '@codecademy/gamut'; | ||
|
|
||
| <Text as="h4" variant="title-xxl" />; |
There was a problem hiding this comment.
nit: this example's not representative of the text above.
maybe?:
<Text as="h4" fontSize={16} />
| <Text as="h4" variant="title-xxl" />; | ||
| ``` | ||
|
|
||
| <Canvas of={TextStories.Variants} /> |
There was a problem hiding this comment.
The texts look identical in this table and TextStories.Elements (maybe some small diff in vertical margins?
But it doesn't seem helpful tbh
|
|
||
| ## Playground | ||
|
|
||
| If you are using a story named 'Default', you can forgo the `of` prop. |
📬Published Alpha Packages:[email protected] |
|
🚀 Styleguide deploy preview ready! |
dreamwasp
added a commit
that referenced
this pull request
Dec 9, 2024
* move old layout components for ref * update pkgs + try dark theme * basic light mode working * color modes working in components * configure toolbar + start adding params * dark mode theme config working, start on DocsPage configs * keep migrating * anchors working * aboutheader working, need to start working on other headers + types * fix type errors in .storybook layout components * test stories, need to fix prettier * fix formatting * fixed theming ! * better heading * fix other pkg weirdness * fix default homepage + docs ordering * add absolute paths * add absolute paths * create story template (#2964) * create story template * move template out of atoms * update import * withSource to sourceState --------- Co-authored-by: cassie spain <[email protected]> * add source to template * fix Canvas in template * allow static images in storybook 8 (#2973) * test image stuff * getting closer * test dist * remove asset tests * test in pr * tweak some more examples * create foundations + layout stories (#2966) * create foundations + layout stories * feat(Molecules Pages) (#2971) added existing Molecules pages * typography + meta (#2975) * create foundations + layout stories * start foundations * start retooling componentheader * component header tweak * start restructure of header components * TOC + Theme working, need DataTable + code background color * working on color mode - need to fix text color * revert test * Theme page sorted, need to fix ColorMode * colormode sorted * colormode sorted * start type fix + what to do about blocks * LayoutGrid + content Container * LayoutGrid done * start flexbox, need to look into sandbox stuff * gridbox + flexbox are good, just need to tweak * tweaks to headers * lots of style tweaks + deduplications * fix typograpth, need to fix color mode switches * start on system stories * unify shared elements * add variance + fix tables * more tweaks to status * design tweaks * add hub * more tweaks * rename DataTable * clean up of default * typography + meta stories * add anchor story * start text + hiddentext * text done * started snippet changes * fixed code snippets * meta and sorted done?" * renamed + sorting * more kenny edits * more kenny edits + other new tab for links * the last of it * fix molecule order * update production deploy (#2980) * [gm-916] update storybook production deploy * swap to relative pathing * again * feat(Organisms) (#2978) * added in Organisms stories * remove old styleguide files * Revert "remove old styleguide files" This reverts commit baba497. * feat(Atoms): migrate all Atom stories (#2972) * create story template * move template out of atoms * update import * skip to content * withSource to sourceState * update skip to content * tag story * add statuses * radial progress story * updates from figma * toggle story * update status * pattern story * update toggle interactive example * illustrations story * focus trap story * update playground examples * floating card story * update illustrations subtitle * drawer story * update drawer story * animation story * add figma links * card story * about page * progress bar story * popovercontainer story * loader stories * fix about pages * move examples below * icon stories * checkbox story * add checkbox example * most of input story * Badges started (#2979) * Badges started * badges done * add most GH links, need to test * add github links to most pages * remove comment * finish input stories * update more github links * textarea story * radio story * update examples * select story * fix card usage guidelines * feat(Atoms): adding in the remaining Atoms (#2982) * finished badges * added buttons * added formelements * updated about page * minor touchups * fixed minor ts error * updated usage for CTAButton and IconButton * selectdropdown story * remove optional text * update forminputs table of contents * fix forminput table of contents links * remove logo story * remove placeholder text * update main table of contents * fix icon table of contents * fix loaders table of contents links * PR feedback * uncomment link --------- Co-authored-by: cassie spain <[email protected]> Co-authored-by: Kenny Lin <[email protected]> * remove old styleguide files (#2985) --------- Co-authored-by: Amy Resnik <[email protected]> Co-authored-by: Kenny Lin <[email protected]>
dreamwasp
added a commit
that referenced
this pull request
Dec 9, 2024
* temporarily move offending stories * temp old storybook * radial * migrate layout components (#2961) * move old layout components for ref * update pkgs + try dark theme * basic light mode working * color modes working in components * configure toolbar + start adding params * dark mode theme config working, start on DocsPage configs * keep migrating * anchors working * aboutheader working, need to start working on other headers + types * fix type errors in .storybook layout components * test stories, need to fix prettier * fix formatting * fixed theming ! * better heading * fix other pkg weirdness * fix default homepage + docs ordering * add absolute paths * add absolute paths * create story template (#2964) * create story template * move template out of atoms * update import * withSource to sourceState --------- Co-authored-by: cassie spain <[email protected]> * add source to template * fix Canvas in template * allow static images in storybook 8 (#2973) * test image stuff * getting closer * test dist * remove asset tests * test in pr * tweak some more examples * create foundations + layout stories (#2966) * create foundations + layout stories * feat(Molecules Pages) (#2971) added existing Molecules pages * typography + meta (#2975) * create foundations + layout stories * start foundations * start retooling componentheader * component header tweak * start restructure of header components * TOC + Theme working, need DataTable + code background color * working on color mode - need to fix text color * revert test * Theme page sorted, need to fix ColorMode * colormode sorted * colormode sorted * start type fix + what to do about blocks * LayoutGrid + content Container * LayoutGrid done * start flexbox, need to look into sandbox stuff * gridbox + flexbox are good, just need to tweak * tweaks to headers * lots of style tweaks + deduplications * fix typograpth, need to fix color mode switches * start on system stories * unify shared elements * add variance + fix tables * more tweaks to status * design tweaks * add hub * more tweaks * rename DataTable * clean up of default * typography + meta stories * add anchor story * start text + hiddentext * text done * started snippet changes * fixed code snippets * meta and sorted done?" * renamed + sorting * more kenny edits * more kenny edits + other new tab for links * the last of it * fix molecule order * update production deploy (#2980) * [gm-916] update storybook production deploy * swap to relative pathing * again * feat(Organisms) (#2978) * added in Organisms stories * remove old styleguide files * Revert "remove old styleguide files" This reverts commit baba497. * feat(Atoms): migrate all Atom stories (#2972) * create story template * move template out of atoms * update import * skip to content * withSource to sourceState * update skip to content * tag story * add statuses * radial progress story * updates from figma * toggle story * update status * pattern story * update toggle interactive example * illustrations story * focus trap story * update playground examples * floating card story * update illustrations subtitle * drawer story * update drawer story * animation story * add figma links * card story * about page * progress bar story * popovercontainer story * loader stories * fix about pages * move examples below * icon stories * checkbox story * add checkbox example * most of input story * Badges started (#2979) * Badges started * badges done * add most GH links, need to test * add github links to most pages * remove comment * finish input stories * update more github links * textarea story * radio story * update examples * select story * fix card usage guidelines * feat(Atoms): adding in the remaining Atoms (#2982) * finished badges * added buttons * added formelements * updated about page * minor touchups * fixed minor ts error * updated usage for CTAButton and IconButton * selectdropdown story * remove optional text * update forminputs table of contents * fix forminput table of contents links * remove logo story * remove placeholder text * update main table of contents * fix icon table of contents * fix loaders table of contents links * PR feedback * uncomment link --------- Co-authored-by: cassie spain <[email protected]> Co-authored-by: Kenny Lin <[email protected]> * remove old styleguide files (#2985) --------- Co-authored-by: Amy Resnik <[email protected]> Co-authored-by: Kenny Lin <[email protected]> --------- Co-authored-by: Amy Resnik <[email protected]> Co-authored-by: Kenny Lin <[email protected]>
dreamwasp
added a commit
that referenced
this pull request
Dec 9, 2024
* start with empty lib * add babel config? * add old package.json back * add old babel config * leave to show jake * empty storybook, maybe not running * just try with base config * start adding maybe need packages * try one story * progress not perfection * ci: set correct node version everywhere * chore: separate dev dependencies from production dependencies * remove webpack here * remove comma * remove comma, yarn * mess but uhhhh starting * RUNNING * move logo back and keep testing * experiment, maybe getting closer * remove storybook/addon-styling-webpack * jaek changes + temp stories * jake changes + fixes * start tweaking GHA * fix remaining type errors * test CI * update netlify cli * try removing msg * test * test * try fr * test w/o lerna * remove msg * add alias path for variance * spellcheck * try slightly different syntax * test CI (#2960) * test CI * filter styleguide site --------- Co-authored-by: Jake Hiller <[email protected]> * remove unused pkgs; * test deploy message * fix msg syntax * remove comment * remove explicit webpack bump * tweak pkg .json + failing tests * fix provider test * test new variance pkgs * rm other stuff * linter error * fix baseUrl * resolve pathing error * Cass sb 8 fix connectformtypes (#2963) * build errors in forms * fixed build errors * resolve build error * keep getError message internal * more test tweaks * no gamut-test tests for now * skip selectdropdown tests for now * await video resolution * skip video for now * skip last problematic test * temporarily move offending stories (#2956) * temporarily move offending stories * temp old storybook * radial * migrate layout components (#2961) * move old layout components for ref * update pkgs + try dark theme * basic light mode working * color modes working in components * configure toolbar + start adding params * dark mode theme config working, start on DocsPage configs * keep migrating * anchors working * aboutheader working, need to start working on other headers + types * fix type errors in .storybook layout components * test stories, need to fix prettier * fix formatting * fixed theming ! * better heading * fix other pkg weirdness * fix default homepage + docs ordering * add absolute paths * add absolute paths * create story template (#2964) * create story template * move template out of atoms * update import * withSource to sourceState --------- Co-authored-by: cassie spain <[email protected]> * add source to template * fix Canvas in template * allow static images in storybook 8 (#2973) * test image stuff * getting closer * test dist * remove asset tests * test in pr * tweak some more examples * create foundations + layout stories (#2966) * create foundations + layout stories * feat(Molecules Pages) (#2971) added existing Molecules pages * typography + meta (#2975) * create foundations + layout stories * start foundations * start retooling componentheader * component header tweak * start restructure of header components * TOC + Theme working, need DataTable + code background color * working on color mode - need to fix text color * revert test * Theme page sorted, need to fix ColorMode * colormode sorted * colormode sorted * start type fix + what to do about blocks * LayoutGrid + content Container * LayoutGrid done * start flexbox, need to look into sandbox stuff * gridbox + flexbox are good, just need to tweak * tweaks to headers * lots of style tweaks + deduplications * fix typograpth, need to fix color mode switches * start on system stories * unify shared elements * add variance + fix tables * more tweaks to status * design tweaks * add hub * more tweaks * rename DataTable * clean up of default * typography + meta stories * add anchor story * start text + hiddentext * text done * started snippet changes * fixed code snippets * meta and sorted done?" * renamed + sorting * more kenny edits * more kenny edits + other new tab for links * the last of it * fix molecule order * update production deploy (#2980) * [gm-916] update storybook production deploy * swap to relative pathing * again * feat(Organisms) (#2978) * added in Organisms stories * remove old styleguide files * Revert "remove old styleguide files" This reverts commit baba497. * feat(Atoms): migrate all Atom stories (#2972) * create story template * move template out of atoms * update import * skip to content * withSource to sourceState * update skip to content * tag story * add statuses * radial progress story * updates from figma * toggle story * update status * pattern story * update toggle interactive example * illustrations story * focus trap story * update playground examples * floating card story * update illustrations subtitle * drawer story * update drawer story * animation story * add figma links * card story * about page * progress bar story * popovercontainer story * loader stories * fix about pages * move examples below * icon stories * checkbox story * add checkbox example * most of input story * Badges started (#2979) * Badges started * badges done * add most GH links, need to test * add github links to most pages * remove comment * finish input stories * update more github links * textarea story * radio story * update examples * select story * fix card usage guidelines * feat(Atoms): adding in the remaining Atoms (#2982) * finished badges * added buttons * added formelements * updated about page * minor touchups * fixed minor ts error * updated usage for CTAButton and IconButton * selectdropdown story * remove optional text * update forminputs table of contents * fix forminput table of contents links * remove logo story * remove placeholder text * update main table of contents * fix icon table of contents * fix loaders table of contents links * PR feedback * uncomment link --------- Co-authored-by: cassie spain <[email protected]> Co-authored-by: Kenny Lin <[email protected]> * remove old styleguide files (#2985) --------- Co-authored-by: Amy Resnik <[email protected]> Co-authored-by: Kenny Lin <[email protected]> --------- Co-authored-by: Amy Resnik <[email protected]> Co-authored-by: Kenny Lin <[email protected]> --------- Co-authored-by: Jake Hiller <[email protected]> Co-authored-by: Amy Resnik <[email protected]> Co-authored-by: Kenny Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds Meta + Typography stories, adds sorting for story categories, and update code snippets to the new templare
PR Checklist
Testing Instructions