Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cass sb 8 fix connectformtypes #2963

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Cass sb 8 fix connectformtypes #2963

merged 8 commits into from
Nov 4, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 30, 2024 •
edited
Loading

Overview

Makes a couple changes to ConnectedForm - I think some of the pakacge bumps require stricter type safety

Testing Instructions

All tests + builds are now passing locally, the remaining test failures are due to the other act errors. See all tests passing in the monorepo PR

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 30, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 94acefc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6723e04bd0918e29e36cba76--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@dreamwasp dreamwasp marked this pull request as ready for review November 1, 2024 13:46
@dreamwasp dreamwasp requested a review from a team as a code owner November 1, 2024 13:46
@dreamwasp dreamwasp requested review from timjenkins, BandanaKM, aresnik11 and jakemhiller and removed request for a team November 1, 2024 13:46
jakemhiller
jakemhiller approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dreamwasp dreamwasp merged commit dac579d into storybook-8-new-styleguide Nov 4, 2024
8 of 10 checks passed
@dreamwasp dreamwasp deleted the cass-sb-8-fix-connectformtypes branch November 4, 2024 15:00
dreamwasp added a commit that referenced this pull request Dec 9, 2024
@dreamwasp @jakemhiller
@aresnik11 @LinKCoding
start with empty lib (#2952)
3e3f48e 
* start with empty lib

* add babel config?

* add old package.json back

* add old babel config

* leave to show jake

* empty storybook, maybe not running

* just try with base config

* start adding maybe need packages

* try one story

* progress not perfection

* ci: set correct node version everywhere

* chore: separate dev dependencies from production dependencies

* remove webpack here

* remove comma

* remove comma, yarn

* mess but uhhhh starting

* RUNNING

* move logo back and keep testing

* experiment, maybe getting closer

* remove storybook/addon-styling-webpack

* jaek changes + temp stories

* jake changes + fixes

* start tweaking GHA

* fix remaining type errors

* test CI

* update netlify cli

* try removing msg

* test

* test

* try fr

* test w/o lerna

* remove msg

* add alias path for variance

* spellcheck

* try slightly different syntax

* test CI (#2960)

* test CI

* filter styleguide site

---------

Co-authored-by: Jake Hiller <[email protected]>

* remove unused pkgs;

* test deploy message

* fix msg syntax

* remove comment

* remove explicit webpack bump

* tweak pkg .json + failing tests

* fix provider test

* test new variance pkgs

* rm other stuff

* linter error

* fix baseUrl

* resolve pathing error

* Cass sb 8 fix connectformtypes (#2963)

* build errors in forms

* fixed build errors

* resolve build error

* keep getError message internal

* more test tweaks

* no gamut-test tests for now

* skip selectdropdown tests for now

* await video resolution

* skip video for now

* skip last problematic test

* temporarily move offending stories (#2956)

* temporarily move offending stories

* temp old storybook

* radial

* migrate layout components (#2961)

* move old layout components for ref

* update pkgs + try dark theme

* basic light mode working

* color modes working in components

* configure toolbar + start adding params

* dark mode theme config working, start on DocsPage configs

* keep migrating

* anchors working

* aboutheader working, need to start working on other headers + types

* fix type errors in .storybook layout components

* test stories, need to fix prettier

* fix formatting

* fixed theming !

* better heading

* fix other pkg weirdness

* fix default homepage + docs ordering

* add absolute paths

* add absolute paths

* create story template (#2964)

* create story template

* move template out of atoms

* update import

* withSource to sourceState

---------

Co-authored-by: cassie spain <[email protected]>

* add source to template

* fix Canvas in template

* allow static images in storybook 8 (#2973)

* test image stuff

* getting closer

* test dist

* remove asset tests

* test in pr

* tweak some more examples

* create foundations + layout stories (#2966)

* create foundations + layout stories

* feat(Molecules Pages) (#2971)

added existing Molecules pages

* typography + meta (#2975)

* create foundations + layout stories

* start foundations

* start retooling componentheader

* component header tweak

* start restructure of header components

* TOC + Theme working, need DataTable + code background color

* working on color mode - need to fix text color

* revert test

* Theme page sorted, need to fix ColorMode

* colormode sorted

* colormode sorted

* start type fix + what to do about blocks

* LayoutGrid + content Container

* LayoutGrid done

* start flexbox, need to look into sandbox stuff

* gridbox + flexbox are good, just need to tweak

* tweaks to headers

* lots of style tweaks + deduplications

* fix typograpth, need to fix color mode switches

* start on system stories

* unify shared elements

* add variance + fix tables

* more tweaks to status

* design tweaks

* add hub

* more tweaks

* rename DataTable

* clean up of default

* typography + meta stories

* add anchor story

* start text + hiddentext

* text done

* started snippet changes

* fixed code snippets

* meta and sorted done?"

* renamed + sorting

* more kenny edits

* more kenny edits + other new tab for links

* the last of it

* fix molecule order

* update production deploy (#2980)

* [gm-916] update storybook production deploy

* swap to relative pathing

* again

* feat(Organisms)  (#2978)

* added in Organisms stories

* remove old styleguide files

* Revert "remove old styleguide files"

This reverts commit baba497.

* feat(Atoms): migrate all Atom stories (#2972)

* create story template

* move template out of atoms

* update import

* skip to content

* withSource to sourceState

* update skip to content

* tag story

* add statuses

* radial progress story

* updates from figma

* toggle story

* update status

* pattern story

* update toggle interactive example

* illustrations story

* focus trap story

* update playground examples

* floating card story

* update illustrations subtitle

* drawer story

* update drawer story

* animation story

* add figma links

* card story

* about page

* progress bar story

* popovercontainer story

* loader stories

* fix about pages

* move examples below

* icon stories

* checkbox story

* add checkbox example

* most of input story

* Badges started (#2979)

* Badges started

* badges done

* add most GH links, need to test

* add github links to most pages

* remove comment

* finish input stories

* update more github links

* textarea story

* radio story

* update examples

* select story

* fix card usage guidelines

* feat(Atoms): adding in the remaining Atoms (#2982)

* finished badges

* added buttons

* added formelements

* updated about page

* minor touchups

* fixed minor ts error

* updated usage for CTAButton and IconButton

* selectdropdown story

* remove optional text

* update forminputs table of contents

* fix forminput table of contents links

* remove logo story

* remove placeholder text

* update main table of contents

* fix icon table of contents

* fix loaders table of contents links

* PR feedback

* uncomment link

---------

Co-authored-by: cassie spain <[email protected]>
Co-authored-by: Kenny Lin <[email protected]>

* remove old styleguide files (#2985)

---------

Co-authored-by: Amy Resnik <[email protected]>
Co-authored-by: Kenny Lin <[email protected]>

---------

Co-authored-by: Amy Resnik <[email protected]>
Co-authored-by: Kenny Lin <[email protected]>

---------

Co-authored-by: Jake Hiller <[email protected]>
Co-authored-by: Amy Resnik <[email protected]>
Co-authored-by: Kenny Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins was automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM was automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @jakemhiller