Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 71 new File icons and create new opacity preference #1116

Closed
wants to merge 5 commits into from
Closed

Add 71 new File icons and create new opacity preference #1116

wants to merge 5 commits into from

Conversation

iggy890
Copy link
Contributor

@iggy890 iggy890 commented Mar 6, 2023

Description

This PR adds 71 new file icons FileIcon.swift, this PR is a draft and file icons are being added.

Related Issue

Closes #1115

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

I cannot add all the file icons but here are 3:

shot 1

shot 2

shot 3

@lukepistrol
Copy link
Member

Needs #1113 to be merged first

@iggy890 iggy890 changed the title Add File icons Add 48 new File icons Mar 7, 2023
@iggy890 iggy890 changed the title Add 48 new File icons Add 58 new File icons Mar 7, 2023
@iggy890 iggy890 changed the title Add 58 new File icons Add 65 new File icons Mar 7, 2023
@matthijseikelenboom
Copy link
Contributor

The way this is written, is this even extendable? I don't see how extension developers can build upon this

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 7, 2023

The way this is written, is this even extendable? I don't see how extension developers can build upon this

It’s not hard to extend at all, in fact it’s quite easy.

@matthijseikelenboom
Copy link
Contributor

You do know that they cannot add an extra enum case right? As an extension developer, you don't have access to the implementation code of CodeEdit

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 7, 2023

You do know that they cannot add an extra enum case right? As an extension developer, you don't have access to the implementation code of CodeEdit

Didn’t know that, thanks for alerting me I’ll create a function to add extra enum cases.

@iggy890 iggy890 changed the title Add 65 new File icons Add 65 new File icons and create new opacity preference Mar 7, 2023
@iggy890 iggy890 changed the title Add 65 new File icons and create new opacity preference Add 69 new File icons and create new opacity preference Mar 7, 2023
@iggy890 iggy890 changed the title Add 69 new File icons and create new opacity preference Add 71 new File icons and create new opacity preference Mar 7, 2023
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 7, 2023

You do know that they cannot add an extra enum case right? As an extension developer, you don't have access to the implementation code of CodeEdit

Unfortunately you cannot add a new case to an enum: https://stackoverflow.com/questions/53113895/how-to-add-more-cases-for-enum-in-swift

@lukepistrol
Copy link
Member

You do know that they cannot add an extra enum case right? As an extension developer, you don't have access to the implementation code of CodeEdit

Unfortunately you cannot add a new case to an enum: https://stackoverflow.com/questions/53113895/how-to-add-more-cases-for-enum-in-swift

That's what @matthijseikelenboom was talking about 😉

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 7, 2023

You do know that they cannot add an extra enum case right? As an extension developer, you don't have access to the implementation code of CodeEdit

Unfortunately you cannot add a new case to an enum: https://stackoverflow.com/questions/53113895/how-to-add-more-cases-for-enum-in-swift

That's what @matthijseikelenboom was talking about 😉

Whoops, maybe I can resolve that in a future PR and for now create and issue

@matthijseikelenboom
Copy link
Contributor

matthijseikelenboom commented Mar 7, 2023

@iggy890 What issue are you going to create? What would it be about?

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 7, 2023

@matthijseikelenboom It would be called "Icon extendability", I'll create right now.

@matthijseikelenboom
Copy link
Contributor

@iggy890 No no, just leave it for now

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 7, 2023

@matthijseikelenboom Alright. ✅

@iggy890 iggy890 closed this Mar 9, 2023
@iggy890 iggy890 reopened this Mar 9, 2023
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 10, 2023

@lukepistrol Can this PR be changed to an active PR, I suspect the blocking tag is well, blocking it.

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 10, 2023

The 'blocking' label is there for a reason. This PR hardcodes these icons in place. @lukepistrol and @matthijseikelenboom are trying to tell you that we want these icons bundled in an icon set separate from SF Symbols so that developers writing extensions for CodeEdit can create their own icon sets to use in place of the default one we would create. This PR does not align with this goal and would have been thrown out if it were merged. I am closing this PR.

Edit: @lukepistrol @matthijseikelenboom is this something we want to get us by until that point? If so feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Icons for every file format and file format opacity
4 participants