-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 71 new File icons and create new opacity preference #1116
Conversation
Needs #1113 to be merged first |
The way this is written, is this even extendable? I don't see how extension developers can build upon this |
It’s not hard to extend at all, in fact it’s quite easy. |
You do know that they cannot add an extra enum case right? As an extension developer, you don't have access to the implementation code of CodeEdit |
Didn’t know that, thanks for alerting me I’ll create a function to add extra |
CodeEdit/Features/AppPreferences/Model/General/GeneralPreferences.swift
Outdated
Show resolved
Hide resolved
Unfortunately you cannot add a new case to an enum: https://stackoverflow.com/questions/53113895/how-to-add-more-cases-for-enum-in-swift |
That's what @matthijseikelenboom was talking about 😉 |
Whoops, maybe I can resolve that in a future PR and for now create and issue |
@iggy890 What issue are you going to create? What would it be about? |
@matthijseikelenboom It would be called "Icon extendability", I'll create right now. |
@iggy890 No no, just leave it for now |
@matthijseikelenboom Alright. ✅ |
@lukepistrol Can this PR be changed to an active PR, I suspect the |
The 'blocking' label is there for a reason. This PR hardcodes these icons in place. @lukepistrol and @matthijseikelenboom are trying to tell you that we want these icons bundled in an icon set separate from SF Symbols so that developers writing extensions for CodeEdit can create their own icon sets to use in place of the default one we would create. This PR does not align with this goal and would have been thrown out if it were merged. I am closing this PR. Edit: @lukepistrol @matthijseikelenboom is this something we want to get us by until that point? If so feel free to reopen. |
Description
This PR adds 71 new file icons
FileIcon.swift
, this PR is a draft and file icons are being added.Related Issue
Closes #1115
Checklist
Screenshots
I cannot add all the file icons but here are 3: