-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Icons for every file format and file format opacity #1115
Comments
@austincondiff Could you assign this to me? |
I'm not Austin, but here we go :) |
Thanks @0xWDG. |
We might do this in such a way that it allows for icon packs in the future? This being said, should we add these new symbols to CodeEditSymbols? @CodeEditApp/maintainers what do you think? |
You're right about this, even though |
I think this should be hold of. We want to give extension developers the possibility to build some sort of icon pack, and for that we first need an API architecture. If we build this right now, there is 95% chance that we'll have to rebuild it. Also this issue expects that we want to use SF Symbols, which hasn't even been discussed. I personally think that SF Symbols is ill fitted here, they are not designed for this purpose. |
Ok, I'll work on a different PR and commit all of my (current changes) to the PR. |
One Idea I got from using Optionally we could just use them as a font for the symbols. |
I think there are libraries to allow use SVGs directly in the project. This might be good to support different icons sets later down the road. |
Yeah, but the thing is, that those icons of a set need to be the same aspect ratio (squared). Otherwise scaling them correctly is practically impossible. You don't even need extra libraries Xcode supports svgs out-of-the-box. |
We can do that fairly easily. The view box should be a square aspect ratio regardless. |
"should" 😄 I had to work with icon sets at work which were all over the place, some tall, some wide, some square. And not even consistently. |
I think there are a lot of sets supported in VS code that could easily be ported that are all standardized. |
Maybe start a collection of those here or a link to an already existing collection. |
Hi! I created a file-icon association table using SF Symbols and a few custom symbols that you can use. The list covers the list iggy890 made above, other ones I found in other issues/discussions in this organization, and some that VS Code covers (except for MATLAB, but I'm working on Julia). I've tried to stick to using symbols as similar to the ones used in Xcode, but for some I'm not sure what color or symbol should be used. The Let me know what you think. |
I like these. Yes, code edit will allow extension developers to change the icons but I think that SF symbols, https://github.com/devicons/devicon, and a "no icons" option should be shipped as included and could be picked in the appearance section. Very elegant |
Thank you! I think that those would be great options for UX. And I love the whole idea of CodeEdit. I can't wait for the production release! |
Is your feature request related to a problem? Please describe.
Related to: #1014
Describe the solution you'd like
CodeEdit does not have
SF Symbols
icons for every language (including those it doesn't have syntax highlighting).Some filenames do not have their proper extensions because it would take too much time to research them.
Added to fork?
PR created?
PR ready for review?
File icon opacity?
Additional context
The
SF Symbols
library has a lot of icons that we could use for the languages.At some point I'm going to submit a PR from this fork: https://github.com/iggy890/CodeEdit/tree/file-icons
If you find anymore languages leave a comment below 👇
The text was updated successfully, but these errors were encountered: