Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Icons for every file format and file format opacity #1115

Open
58 of 70 tasks
iggy890 opened this issue Mar 6, 2023 · 18 comments
Open
58 of 70 tasks

✨ Icons for every file format and file format opacity #1115

iggy890 opened this issue Mar 6, 2023 · 18 comments
Assignees
Labels
enhancement New feature or request

Comments

@iggy890
Copy link
Contributor

iggy890 commented Mar 6, 2023

Is your feature request related to a problem? Please describe.

Related to: #1014

Describe the solution you'd like

CodeEdit does not have SF Symbols icons for every language (including those it doesn't have syntax highlighting).

Some filenames do not have their proper extensions because it would take too much time to research them.

  • .c
  • .cpp
  • .cc
  • .hpp
  • .r
  • .ruby
  • .svelte
  • .ts
  • .sql
  • .rust
  • .scala
  • .perl
  • .php
  • .kotlin
  • .lua
  • .matlab
  • .m (objective-c)
  • .julia
  • .cobol
  • .groovy
  • .d
  • .zip
  • .asm, .s, .inc, .wla, .SRC (assembly language)
  • .jar
  • .app
  • .mov, .mp4 (video formats)
  • .mp3, .wav (audio formats)
  • .heic, .gif, .tga, .bmp, .psd, .hdr, .pic, .webp, .avif, .ppm, .pgm, .pbm, .pnm, .tiff, .pdf, .bmp (picture formats)
  • .xcodeproj
  • .obj, .dae, .abc, .glb, .ply, .blend (3d model formats)
  • .dmg, .pkg (app installer formats)
  • .HTM
  • .key
  • .pptx
  • .xml
  • .class
  • .tex
  • .fon
  • .exe
  • .lz
  • .pyw
  • .gzip
  • .stl
  • .gcode
  • .dat
  • .sqlite
  • .doc
  • .docm
  • .docx
  • .log
  • .INFO
  • .jng
  • .PGM
  • .pnm
  • .pns
  • .TIFF
  • .block
  • .pyc
  • .m4v
  • .vob
  • .ppt
  • .pps
  • .tmp
  • .iso
  • .xlsx
  • .DS_Store

Added to fork?

  • Fork

PR created?

  • PR

PR ready for review?

  • Review

File icon opacity?

  • Opacity

Additional context

The SF Symbols library has a lot of icons that we could use for the languages.
At some point I'm going to submit a PR from this fork: https://github.com/iggy890/CodeEdit/tree/file-icons

If you find anymore languages leave a comment below 👇

@iggy890 iggy890 added the enhancement New feature or request label Mar 6, 2023
@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023

@austincondiff Could you assign this to me?

@0xWDG
Copy link
Collaborator

0xWDG commented Mar 6, 2023

@austincondiff Could you assign this to me?

I'm not Austin, but here we go :)

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023

Thanks @0xWDG.

@austincondiff
Copy link
Collaborator

We might do this in such a way that it allows for icon packs in the future? This being said, should we add these new symbols to CodeEditSymbols? @CodeEditApp/maintainers what do you think?

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 6, 2023

We might do this in such a way that it allows for icon packs in the future? This being said, should we add these new symbols to CodeEditSymbols? CodeEditApp/maintainers what do you think?

You're right about this, even though SF Symbols has updates we are still limited with a lot of programming languages.

@iggy890 iggy890 changed the title ✨ Icons for every language ✨ Icons for every language and File format Mar 6, 2023
@iggy890 iggy890 changed the title ✨ Icons for every language and File format ✨ Icons for every file format and file format opacity Mar 7, 2023
@matthijseikelenboom
Copy link
Contributor

I think this should be hold of. We want to give extension developers the possibility to build some sort of icon pack, and for that we first need an API architecture. If we build this right now, there is 95% chance that we'll have to rebuild it.

Also this issue expects that we want to use SF Symbols, which hasn't even been discussed. I personally think that SF Symbols is ill fitted here, they are not designed for this purpose.

@iggy890
Copy link
Contributor Author

iggy890 commented Mar 7, 2023

Ok, I'll work on a different PR and commit all of my (current changes) to the PR.

@lukepistrol
Copy link
Member

lukepistrol commented Mar 23, 2023

One Idea I got from using neovim a lot lately: What if we instead of SF Symbols use a DevIcons. They are available as SVGs and "just" need to be converted to SFSymbols (which tbh is a major chore task haha).

Optionally we could just use them as a font for the symbols.

@lukepistrol lukepistrol moved this from 🆕 New to 💬 Needs Clarification in CodeEdit Project Mar 23, 2023
@austincondiff
Copy link
Collaborator

I think there are libraries to allow use SVGs directly in the project. This might be good to support different icons sets later down the road.

@lukepistrol
Copy link
Member

lukepistrol commented Mar 23, 2023

Yeah, but the thing is, that those icons of a set need to be the same aspect ratio (squared). Otherwise scaling them correctly is practically impossible. You don't even need extra libraries Xcode supports svgs out-of-the-box.

@austincondiff
Copy link
Collaborator

We can do that fairly easily. The view box should be a square aspect ratio regardless.

@lukepistrol
Copy link
Member

We can do that fairly easily. The view box should be a square aspect ratio regardless.

"should" 😄 I had to work with icon sets at work which were all over the place, some tall, some wide, some square. And not even consistently.

@austincondiff
Copy link
Collaborator

I think there are a lot of sets supported in VS code that could easily be ported that are all standardized.

@lukepistrol
Copy link
Member

Maybe start a collection of those here or a link to an already existing collection.

@CurbaiCode
Copy link

CurbaiCode commented Mar 31, 2023

Hi! I created a file-icon association table using SF Symbols and a few custom symbols that you can use.

The list covers the list iggy890 made above, other ones I found in other issues/discussions in this organization, and some that VS Code covers (except for MATLAB, but I'm working on Julia). I've tried to stick to using symbols as similar to the ones used in Xcode, but for some I'm not sure what color or symbol should be used. The .exe symbol is split light/dark mode. Also, I looked through Xcode's contents but couldn't find the Python icon Apple uses.

Screen Shot 2023

Let me know what you think.

file-icons

@net-tech
Copy link

net-tech commented Apr 1, 2023

I like these. Yes, code edit will allow extension developers to change the icons but I think that SF symbols, https://github.com/devicons/devicon, and a "no icons" option should be shipped as included and could be picked in the appearance section. Very elegant

@CurbaiCode
Copy link

CurbaiCode commented Apr 3, 2023

Thank you! I think that those would be great options for UX. And I love the whole idea of CodeEdit. I can't wait for the production release!

@CurbaiCode
Copy link

Here is an update of my SF Symbols set, adding a few more custom symbols:

file-icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 💬 Needs Clarification
Development

Successfully merging a pull request may close this issue.

7 participants