Use with_connection instead of calling release_connection directly #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2018 15:50
…ince the latter may release a connection that belongs to someone else
|
FYI, I think the Travis failure is just some intermittent errors on their end, but I can't retrigger the build myself. |
|
Seems good to me |
n-rodriguez
reviewed
Aug 25, 2018
| :with_advisory_lock | ||
| ) | ||
| connection_pool.with_connection { | ||
| options.assert_valid_keys( |
There was a problem hiding this comment.
Maybe the check could happen before (or outside) the connection_pool.with_connection block to avoid useless connections?
|
We need to check that the code won't break with Databaseless setup. |
|
Just got back from vacation. |
|
I moved this project to the instructure-bridge organization (aka my employer) as #340 and will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to release_connection, added in #263, might release a connection that was opened outside of has_closure_tree (if the caller is loaded dynamically in the middle of some other operation). This is especially problematic if the connection has an ongoing transaction, as that transaction will be lost.
This PR changes has_closure_tree to use with_connection instead, which only releases a connection if it was acquired. If a connection already existed prior to the call to has_closure_tree, it won't be released.