Return database connection into pool after configuration #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When application code being loaded `has_closure_tree` method will get database connection implicitly and will not return it into the pool. In some circumstances this connection will not be available for request processing at runtime anymore.
|
Nice catch, thanks! I'll merge and reversion within a couple days.
…On Apr 12, 2017 10:50 AM, "Andrey Novikov" ***@***.***> wrote:
When application code being loaded has_closure_tree method will get
database connection implicitly and will not return it into the pool.
In some circumstances this connection will not be available for request
processing at runtime anymore.
In my case I've launched Rails app in Puma application server with one
thread and with DB pool size set to one and I was unable to do any requests
as only available connection was taken by closure_tree gem (I always get
ActiveRecord::ConnectionTimeoutError)
------------------------------
You can view, comment on, or merge this pull request online at:
#263
Commit Summary
- Return database connection into pool after configuration
File Changes
- *M* lib/closure_tree/has_closure_tree.rb
<https://github.com/mceachen/closure_tree/pull/263/files#diff-0> (2)
- *M* lib/closure_tree/has_closure_tree_root.rb
<https://github.com/mceachen/closure_tree/pull/263/files#diff-1> (2)
- *A* spec/pool_spec.rb
<https://github.com/mceachen/closure_tree/pull/263/files#diff-2> (27)
Patch Links:
- https://github.com/mceachen/closure_tree/pull/263.patch
- https://github.com/mceachen/closure_tree/pull/263.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#263>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANNOb9Zap3g-7MNHqO-FlRo3zG6qWbWks5rvQ70gaJpZM4M7wYc>
.
|
|
@Envek any information when you would release a new version with this. We just switched from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When application code being loaded
has_closure_treemethod will get database connection implicitly and will not return it into the pool.In some circumstances this connection will not be available for request processing at runtime anymore.
In my case I've launched Rails app in Puma application server with one thread and with DB pool size set to one and I was unable to do any requests as only available connection was taken by closure_tree gem (I always get
ActiveRecord::ConnectionTimeoutError)