Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #74

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Update README.md #74

merged 2 commits into from
Aug 26, 2022

Conversation

tomchor
Copy link
Contributor

@tomchor tomchor commented Aug 25, 2022

PULL REQUEST

Purpose and Content

@Yujie-W great package! I just downloaded (and started reading) your paper but I noticed you don't yet mention it in the README. This is just a reminder for you to do that so that people can properly cite it :)

Feel free to modify this PR yourself (with a text that's to your liking).

Cheers!

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #74 (666f5e2) into main (93f9909) will decrease coverage by 1.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   63.94%   62.89%   -1.05%     
==========================================
  Files           6        6              
  Lines         355      380      +25     
==========================================
+ Hits          227      239      +12     
- Misses        128      141      +13     
Impacted Files Coverage Δ
src/Indexer.jl 80.58% <0.00%> (-3.26%) ⬇️
src/Collector.jl 92.85% <0.00%> (-1.01%) ⬇️
src/Blender.jl 100.00% <0.00%> (ø)
src/Fetcher.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yujie-W
Copy link
Collaborator

Yujie-W commented Aug 26, 2022

@Yujie-W great package! I just downloaded (and started reading) your paper but I noticed you don't yet mention it in the README. This is just a reminder for you to do that so that people can properly cite it :)

Feel free to modify this PR yourself (with a text that's to your liking).

Thanks. I updated the deps in the docs folder to pass the build (Julia 1.8 does not work with the outdated Netcdf_jll).

@Yujie-W
Copy link
Collaborator

Yujie-W commented Aug 26, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 26, 2022

Build succeeded:

@bors bors bot merged commit 5afd448 into main Aug 26, 2022
@Yujie-W Yujie-W deleted the tc/credits branch August 26, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants