Conversation
Sbozzolo
force-pushed
the
gb/read!
branch
3 times, most recently
from
85f4f9d to
103c460
Compare
This commit adds a new in-place function `read!` to read data from files and uses this new method to reduce allocations in regridding.
It is a good idea to perform filesystem operations only with one process
AlexisRenchon
approved these changes
Aug 2, 2024
Member
|
maybe just squash the 3 commits? |
Member
Author
They are implement logically distinct changes, so I think it's best to leave them separate |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new in-place function
read!to read data from files and uses this new method to reduce allocations in regridding.Closes #81