Merged
Conversation
953756f to
4ca560d
Compare
Sbozzolo
reviewed
Oct 20, 2024
Sbozzolo
approved these changes
Oct 20, 2024
This commit adds a new in-place function `read!` to read data from files and uses this new method to reduce allocations in regridding.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a new function
read!that reads in data to a preallocated space in the DataHandler, as opposed to allocating at each call as the existingreaddoes. This requires the addition of apreallocated_read_datacache to theDataHandlerobject.It also requires that
readreturns a copy of the data in the case of a cache hit to avoid overwriting data in the cache (this was the cause of the bug in the original implementation).Note that we expect higher allocations when using
readdue to the addedcopy, but lower allocations usingread!overread. Internally, we now useread!now so users should see reduced allocations.This feature was initially introduced in #83, but there was a bug in that implementation so it has been reworked here
closes #81