Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ClimaAtmos aquaplanet_diagedmf.yml #802

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

juliasloan25
Copy link
Member

Purpose

closes #800

gpu_aquaplanet_diagedmf.yml no longer exists in atmos and should be replaced with aquaplanet_diagedmf.yml.

ClimaAtmos configs used in ClimaCoupler (as of 20 May 2024, after this PR)

  • config/model_configs/aquaplanet_diagedmf.yml
  • config/longrun_configs/longrun_aquaplanet_rhoe_equil_55km_nz63_allsky_diagedmf_0M.yml
  • config/longrun_configs/longrun_aquaplanet_rhoe_equil_55km_nz63_clearsky_0M_earth.yml
  • config/longrun_configs/longrun_aquaplanet_rhoe_equil_55km_nz63_clearsky_0M.yml
  • config/longrun_configs/longrun_aquaplanet_dyamond.yml

@juliasloan25
Copy link
Member Author

@charleskawczynski It doesn't look like any of the other atmos configs being used by ClimaCoupler have changed - would you agree? I added a list of the configs we're using in this PR description

@charleskawczynski
Copy link
Member

doesn't look like any of the other atmos configs being used by ClimaCoupler have changed - would you agree? I added a list of the configs we're using in this PR description

Perhaps? We'll likely change more since there's still quite a bit of duplication. Maybe we can flag those PRs, though, so that we can more easily trace what changes are needed in the coupler.

@juliasloan25
Copy link
Member Author

doesn't look like any of the other atmos configs being used by ClimaCoupler have changed - would you agree? I added a list of the configs we're using in this PR description

Perhaps? We'll likely change more since there's still quite a bit of duplication. Maybe we can flag those PRs, though, so that we can more easily trace what changes are needed in the coupler.

That would be great. Thank you for the review!

@juliasloan25 juliasloan25 merged commit f4d2599 into main May 20, 2024
9 checks passed
@juliasloan25 juliasloan25 deleted the js/longrun-namechange branch May 20, 2024 21:30
@LenkaNovak
Copy link
Collaborator

LenkaNovak commented May 20, 2024

Thanks so much, @juliasloan25 and @charleskawczynski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update longruns for ClimaAtmos config changes
3 participants