Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update longruns for ClimaAtmos config changes #800

Closed
LenkaNovak opened this issue May 20, 2024 · 4 comments · Fixed by #802
Closed

Update longruns for ClimaAtmos config changes #800

LenkaNovak opened this issue May 20, 2024 · 4 comments · Fixed by #802
Assignees
Labels
bug Something isn't working 🔥 Urgent

Comments

@LenkaNovak
Copy link
Collaborator

For example, gpu_aquaplanet_diagedmf.yml no longer exists, leading to breaking coupled longruns here.

@LenkaNovak LenkaNovak added the bug Something isn't working label May 20, 2024
@LenkaNovak
Copy link
Collaborator Author

@szy21 , presumably this just needs to be changed to aquaplanet_diagedmf.yml, or do you know if there have been any config changes from the previous version of that Atmos config file? Maybe some of the toml arguments?

Cc'ing @juliasloan25 for visibility.

@szy21
Copy link
Member

szy21 commented May 20, 2024

Ah, it is from this PR which should be a breaking change: CliMA/ClimaAtmos.jl#3008. I'm not very familiar with the recent filename changes, @charleskawczynski should know more. Maybe we can document which configs are used in the coupler, so that we can know whether a PR is a breaking change?

@charleskawczynski
Copy link
Member

Ah, yeah, I didn't realize that the coupler is using the ClimaAtmos yaml configs. That PR simply unifies some yaml files, so changing the filename should fix it. I'll add the breaking label to that PR.

@juliasloan25
Copy link
Member

ClimaAtmos configs used in ClimaCoupler (as of 20 May 2024)

  • config/model_configs/aquaplanet_diagedmf.yml
  • config/longrun_configs/longrun_aquaplanet_rhoe_equil_55km_nz63_allsky_diagedmf_0M.yml
  • config/longrun_configs/longrun_aquaplanet_rhoe_equil_55km_nz63_clearsky_0M_earth.yml
  • config/longrun_configs/longrun_aquaplanet_rhoe_equil_55km_nz63_clearsky_0M.yml
  • config/longrun_configs/longrun_aquaplanet_dyamond.yml
    cc @szy21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔥 Urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants