Alphabetical config arguments #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LenkaNovak
force-pushed
the
ln/alphabetical
branch
from
b378734
to
50035f8
Compare
LenkaNovak
force-pushed
the
ln/alphabetical
branch
from
50035f8
to
a98aea8
Compare
juliasloan25
reviewed
Feb 5, 2024
There was a problem hiding this comment.
I added a suggestion about using Linux's sort command to sort everything, which would move dt and FLOAT_TYPE for the files that have it. I think this would make it easier to standardize across repos, but if you'd rather keep this as-is that's also fine with me
juliasloan25
approved these changes
Feb 5, 2024
alphabetically sorted configs modify gpu run name sort after rebase use Linux sort
LenkaNovak
force-pushed
the
ln/alphabetical
branch
from
a0017a3
to
05a61d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #595