Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort config alphabetically #595

Closed
3 tasks done
LenkaNovak opened this issue Feb 2, 2024 · 5 comments · Fixed by #599
Closed
3 tasks done

Sort config alphabetically #595

LenkaNovak opened this issue Feb 2, 2024 · 5 comments · Fixed by #599
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@LenkaNovak
Copy link
Collaborator

LenkaNovak commented Feb 2, 2024

Components

  • alphabetical rearrangement of all configs
  • change name of the gpu run to preclude race conditions
  • fix path to the atmos standalone run in longruns

Future

  • could we apply this to climaformat.jl?
@LenkaNovak LenkaNovak added the 🍃 leaf Issue coupled to a PR label Feb 2, 2024
@LenkaNovak LenkaNovak mentioned this issue Feb 2, 2024
1 task
@szy21
Copy link
Member

szy21 commented Feb 2, 2024

The alphabetization is nice, but for atmos I find it easier for development when we order configs in physics groups - e.g. numerics, radiation, convection, microphysics, especially when the config file is long. This way people who work on a specific component can easily change the configs they want. But it may be different for the coupler, up to you:)

@LenkaNovak
Copy link
Collaborator Author

Hmm, I wonder if we could do something like you did for edmf with a prefix - e.g., edmfx_upwinding, so that we can sort alphabetically and order them in meaningful clusters at the same time? 🤔

@LenkaNovak
Copy link
Collaborator Author

alphabetical definitely makes our checking easier :)

@szy21
Copy link
Member

szy21 commented Feb 2, 2024

Hmm, I wonder if we could do something like you did for edmf with a prefix - e.g., edmfx_upwinding, so that we can sort alphabetically and order them in meaningful clusters at the same time? 🤔

That's possible. It will be a pretty big change so may not happen soon lol.

@LenkaNovak
Copy link
Collaborator Author

No worries, we'll stick with the coupler only cases for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants