Aim allocation monitoring at perf targets #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/alloc_table
branch
2 times, most recently
from
5ab9798
to
bfd2740
Compare
|
I think we need to fix code loading before we can do this--using I fixed this by reducing the resolution, which is fine since we're really mostly interested in the lines of code. |
charleskawczynski
force-pushed
the
ck/alloc_table
branch
4 times, most recently
from
5ede0e2
to
43fbda8
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2022
836: Aim allocation monitoring at perf targets r=charleskawczynski a=charleskawczynski This PR aims our allocation monitoring, at the performance targets, so that we get finer granularity of allocations across more functions. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2022
836: Aim allocation monitoring at perf targets r=charleskawczynski a=charleskawczynski This PR aims our allocation monitoring, at the performance targets, so that we get finer granularity of allocations across more functions. Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed: |
Remove threaded allocation table Increase mem alloc limits Increase mem request
charleskawczynski
force-pushed
the
ck/alloc_table
branch
from
421e25f
to
a9ed19a
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims our allocation monitoring, at the performance targets, so that we get finer granularity of allocations across more functions.