-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Xedra Evolved ] Chronomancy spells no longer gain xp. Unique level up mechanics. #79768
base: master
Are you sure you want to change the base?
Conversation
"responses": [ | ||
{ | ||
"condition": { "math": [ "u_spell_level('xedra_chronomancer_time_bubble') <= 0" ] }, | ||
"text": "Learn [<spell_name:xedra_chronomancer_time_bubble>]", | ||
"effect": [ | ||
{ "math": [ "u_chronomancer_menu_insight_cost = 50" ] }, | ||
{ "math": [ "u_chronomancer_menu_insight_cost = 30" ] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than typing out the difficulty for every response, you could use u_spell_difficulty() to dynamically calculate it. This would be a bit more verbose, but it would reduce extra changes needed if the spells difficulty is ever changed (I think you mentioned going to do that in another PR?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I just wasn't sure on the syntax and felt this would be faster. If you feel comfortable making the suggested change on one of them I'll add the exposed difficulty line and update the syntax on the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I loaded up the game with the following changes to the time bubble and they seemed to work:
"u_chronomancer_menu_insight_cost = 10 * u_spell_difficulty('xedra_chronomancer_time_bubble')"
"u_chronomancer_menu_insight_cost = u_spell_level('xedra_chronomancer_time_bubble') * u_spell_difficulty('xedra_chronomancer_time_bubble')"
Also, if you're up for it, the menu difficulty can be adjusted the same way: "_chronomancer_menu_difficulty = u_spell_difficulty('xedra_chronomancer_time_bubble')"
data/mods/Xedra_Evolved/dialogue/chronomancer_insight_menu.json
Outdated
Show resolved
Hide resolved
data/mods/Xedra_Evolved/dialogue/chronomancer_insight_menu.json
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary
Mods "XE Chronomancy Unique XP style"
Purpose of change
Every spellcasting school should have unique leveling methods in addition to unique spells. This is working towards that. Future PRs may include ending or drastically reducing Eater XP gains and making them gain a unique variable per Nether monster killed that can eventually be spent to level a spell. Dreamers will of course gain spell xp while sleeping or in portal storms or reaching certain special Nether locations for the first time. Inventor and Dreamsmith are actually in a good place.
Describe the solution
Changes the insight costs to be variable with spell difficulty.
Describe alternatives you've considered
None
Testing
Additional context