Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove house_w_foundation_palette & house_w_nest_palette #79758

Merged
merged 15 commits into from
Feb 21, 2025

Conversation

Milopetilo
Copy link
Contributor

Summary

Infrastructure "Removed outdated house_w_foundation_palette & house_nest_palette"

Purpose of change

The house_w palettes were older attempts at a house palette, which we now have with standard_domestic_palette, so I removed it since some mapgen was still using it.

Describe the solution

Go through every piece of mapgen that uses house_w_foundation_palette and convert them to use standard_domestic_migration_palette. Do the same for house_w_nest_palette. Convert house_w_nest_garden_palette to domestic_garden_nest_palette and put it in its own file, this is done because there's no equivalent palette (that I'm aware of) to convert them to. Also renamed a param in office skyscraper since it shares a name with a param in standard_domestic_abandoned_palette which was throwing errors.

Describe alternatives you've considered

Leave it be because it's not doing much harm.
Convert every house to use house_w_foundation_palette?

Testing

Game loads, houses look mostly the same.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 20, 2025
@Milopetilo
Copy link
Contributor Author

I've had to remove a line from a no hope palette since it was messing up the nests, I'll get a pr up tomorrow to give it a better fix.

@github-actions github-actions bot added Mods: No Hope Relating to the mod No Hope BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 20, 2025
@GuardianDll GuardianDll merged commit 2b1e39c into CleverRaven:master Feb 21, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: No Hope Relating to the mod No Hope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants