-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove house_w_foundation_palette & house_w_nest_palette #79758
Merged
GuardianDll
merged 15 commits into
CleverRaven:master
from
Milopetilo:House-w-palette-removing
Feb 21, 2025
Merged
Remove house_w_foundation_palette & house_w_nest_palette #79758
GuardianDll
merged 15 commits into
CleverRaven:master
from
Milopetilo:House-w-palette-removing
Feb 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've had to remove a line from a no hope palette since it was messing up the nests, I'll get a pr up tomorrow to give it a better fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: No Hope
Relating to the mod No Hope
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Removed outdated house_w_foundation_palette & house_nest_palette"
Purpose of change
The house_w palettes were older attempts at a house palette, which we now have with
standard_domestic_palette
, so I removed it since some mapgen was still using it.Describe the solution
Go through every piece of mapgen that uses
house_w_foundation_palette
and convert them to usestandard_domestic_migration_palette
. Do the same forhouse_w_nest_palette
. Converthouse_w_nest_garden_palette
todomestic_garden_nest_palette
and put it in its own file, this is done because there's no equivalent palette (that I'm aware of) to convert them to. Also renamed a param in office skyscraper since it shares a name with a param instandard_domestic_abandoned_palette
which was throwing errors.Describe alternatives you've considered
Leave it be because it's not doing much harm.
Convert every house to use
house_w_foundation_palette
?Testing
Game loads, houses look mostly the same.
Additional context