Update vcpkg commit to working hash. #69592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Build
Member
Author
|
Huh. Not good enough. Alrighty then. |
github-actions
bot
added
Code: Build
Packages were deprecated that core vcpkg functionality relied on. Update vcpkg to a commit where they handle that.
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Nov 25, 2023
see: CleverRaven/Cataclysm-DDA#69592 Co-authored-by: Andrew Krieger <[email protected]>
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Nov 25, 2023
see: CleverRaven/Cataclysm-DDA#69592 Co-authored-by: Andrew Krieger <[email protected]>
github-merge-queue bot
pushed a commit
to cataclysmbn/Cataclysm-BN
that referenced
this pull request
Nov 25, 2023
ci: bump vcpkg commit version see: CleverRaven/Cataclysm-DDA#69592 Co-authored-by: Andrew Krieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "Update vcpkg commit & windows llvm build configuration"
Purpose of change
Fixes Windows builds failing in GH CI. vcpkg occasionally forces an update because it relies on external packages not under its control, which can be removed, which then break anyone using older commits of vcpkg. It's terrible.
People using the llvm / lld build integration with visual studio will need to update their vcpkg setup to this commit and rebuild their vcpkg deps, typically by deleting
msvc-full-features/vcpkg_installedand rerunning the build in visual studio.Describe the solution
Update to the vcpkg commit that specifically handles this case, microsoft/vcpkg#29067. And also for pkg-config we need microsoft/vcpkg#31924.
Describe alternatives you've considered
Not.
Testing
Windows CI should pass on this PR.
Additional context