Fix weapon prof learning EoC #69276
Merged
Fix weapon prof learning EoC #69276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
Contributor
|
thanks, i was gonna fix the quarterstaff typo but my internet died after making the bugreport, i also had no idea about the other typos |
github-actions
bot
added
json-styled
Maleclypse
pushed a commit
to Maleclypse/Cataclysm-DDA
that referenced
this pull request
Nov 16, 2023
* Fix weapon prof learning EoC * Thank you bot Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "All weapon proficiencies can be learned by hitting"
Purpose of change
Closes #69274
Describe the solution
Correct typos in weapon prof EoC so the IDs referenced match with what's in
proficiencies/melee_weapons.jsonDescribe alternatives you've considered
None
Testing
Give character Quarterstaff Familiarity, whack something, see no errors on learning. Repeat for thrusting swords, maces, and fencing.
Additional context
Can #68990 be merged now 🙏Also checked practice recipes to make sure those didn't have typos, they didn't.