Skip to content

Add favorite category to spell casting menu & minor bugfix#68833

Merged
Maleclypse merged 4 commits intoCleverRaven:masterfrom
lispcoc:better_spell_menu
Oct 24, 2023
Merged

Add favorite category to spell casting menu & minor bugfix#68833
Maleclypse merged 4 commits intoCleverRaven:masterfrom
lispcoc:better_spell_menu

Conversation

@lispcoc
Copy link
Contributor

@lispcoc lispcoc commented Oct 23, 2023

Summary

Interface "Add favorite category to spell casting menu"

Purpose of change

Follow up #68761
Fix an issue where the left and right keys did not work in Debug > Change time menu

Describe the solution

Use the "*" key to register spells as favorites so that they can be grouped together on the favorites page.

Describe alternatives you've considered

Testing

image
image

Additional context

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` labels Oct 23, 2023
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Oct 23, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 23, 2023
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 24, 2023
@lispcoc lispcoc marked this pull request as ready for review October 24, 2023 03:01
@github-actions github-actions bot requested a review from KorGgenT October 24, 2023 03:28
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Qrox

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 24, 2023
@Maleclypse Maleclypse merged commit 5b86c71 into CleverRaven:master Oct 24, 2023
@lispcoc lispcoc deleted the better_spell_menu branch October 24, 2023 12:49
detahramet pushed a commit to detahramet/Cataclysm-DDA that referenced this pull request Nov 6, 2023
…en#68833)

* add favorite

* Update data/raw/keybindings.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* clang fix

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Maleclypse pushed a commit to Maleclypse/Cataclysm-DDA that referenced this pull request Nov 16, 2023
…en#68833)

* add favorite

* Update data/raw/keybindings.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* clang fix

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants