Skip to content

Conversation

@lispcoc
Copy link
Contributor

@lispcoc lispcoc commented Sep 8, 2023

Summary

Features "Add EOC condition: weapon category"

Purpose of change

There is no way to know what type of weapon player has.

Describe the solution

Add new condition "has_wielded_with_weapon_category"

Describe alternatives you've considered

As the number of functions that retrieve item information has increased, it may be better to provide wrapper function rather than preparing individual functions.
Something like:

{ "u_has_wielded_with": { "weapon_category": "SHORT_SWORDS" } }

Testing

See TALK_TEST_ITEM_WIELDED
wield butcher knife
{ "u_has_wielded_with_weapon_category": "KNIVES" } => true
{ "u_has_wielded_with_weapon_category": "LONG_SWORDS" } => false

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 8, 2023
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [Markdown] Markdown issues and PRs and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 8, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 8, 2023
@lispcoc lispcoc marked this pull request as ready for review September 8, 2023 12:44
@Maleclypse Maleclypse merged commit e0694d0 into CleverRaven:master Sep 8, 2023
@lispcoc lispcoc deleted the w_cat_condition branch September 24, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants