Skip to content

Aluminum Revolution 3: The Oxide Returns#60635

Merged
Fris0uman merged 9 commits intoCleverRaven:masterfrom
Karol1223:aluminum-stepladder-fix
Sep 1, 2022
Merged

Aluminum Revolution 3: The Oxide Returns#60635
Fris0uman merged 9 commits intoCleverRaven:masterfrom
Karol1223:aluminum-stepladder-fix

Conversation

@Karol1223
Copy link
Contributor

Summary

Balance "Yet more changes connected to aluminum"

Purpose of change

As discussions went on in the discord it was brought to my attention that I messed up the disassembly recipe for my aluminum stepladder. Then it turned out that there were issues with the lighters too. And someone pointed out frames probably shouldn't break into ingots. The PR Butterfly Effect.

Describe the solution

  • Smashing aluminum stepladders or either of the aluminum frames will give scrap aluminum instead of full-blown ingots.
  • Disassembling aluminum stepladders will now yield appropriate amount of material and in scrap instead of ingots, also uses hammering now.
  • Both aluminum frame recipes have been adjusted to have slightly lower material cost to be in line with their mass. They also are no longer reversible but have a disassembly recipe yielding scrap.
  • The currently disassemblable lighters now only give pilot lights. They are too small to give proper raw resources.
  • Refillable butane lighter can now be disassembled into a pilot light.

Describe alternatives you've considered

Considered adding a new item to represent the lighter spark being different than pilot lights but during research, it turned out the line between the two gets really blurry at times so it stayed as is. I also considered changing the recipe and material for the antenna, which is another mess of an item, but it needs a bit more cleanup and it'll come in its own PR later on.

Testing

No crashes, disassembled work as intended.

Additional context

Hopefully, I can start the antenna PR tomorrow if all goes to plan, until then they will stay as the last problem item that I know of. Having said that, if there are any more out there, I'd be very glad if someone notified me about them.

@Karol1223 Karol1223 marked this pull request as ready for review August 31, 2022 20:32
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Vehicles Vehicles, parts, mechanics & interactions Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 31, 2022
@Fris0uman Fris0uman merged commit 89e1f92 into CleverRaven:master Sep 1, 2022
@Karol1223 Karol1223 deleted the aluminum-stepladder-fix branch November 3, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants