Aluminum Revolution 3: The Oxide Returns#60635
Merged
Fris0uman merged 9 commits intoCleverRaven:masterfrom Sep 1, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Yet more changes connected to aluminum"
Purpose of change
As discussions went on in the discord it was brought to my attention that I messed up the disassembly recipe for my aluminum stepladder. Then it turned out that there were issues with the lighters too. And someone pointed out frames probably shouldn't break into ingots. The PR Butterfly Effect.
Describe the solution
Describe alternatives you've considered
Considered adding a new item to represent the lighter spark being different than pilot lights but during research, it turned out the line between the two gets really blurry at times so it stayed as is. I also considered changing the recipe and material for the antenna, which is another mess of an item, but it needs a bit more cleanup and it'll come in its own PR later on.
Testing
No crashes, disassembled work as intended.
Additional context
Hopefully, I can start the antenna PR tomorrow if all goes to plan, until then they will stay as the last problem item that I know of. Having said that, if there are any more out there, I'd be very glad if someone notified me about them.